Scripting Helpers is winding down operations and is now read-only. More info→
Log in to vote
0
Why does my set color button not work and turn everything black?
So I wanted to make a theme and when you clicked the button it would change everything into a blue theme. But instead of changing everything into a light blue and dark blue combination everything turns black. Can anyone tell me why?
The following code is a part of the theme menu that would change color of a admin GUI on my experimental game.
My code:
001 | -- Color |
002 | |
003 | local DarkerBlue = 53,56,255 |
004 | |
005 | local LighterBlue = 101,103,255 |
006 | |
007 | |
008 |
009 | -- Elements |
010 |
011 | local FrameD1 = script.Parent.Parent |
012 |
013 | local FrameD2 = script.Parent.Parent.Parent.Universo |
014 |
015 | local FrameL1 = script.Parent.Parent.inside |
016 |
017 | local FrameL2 = script.Parent.Parent.Parent.Universo.About |
018 |
019 | local FrameL3 = script.Parent.Parent.Parent.Universo.Games |
020 |
021 | local FrameL4 = script.Parent.Parent.Parent.Universo.Home |
022 |
023 | local FrameL5 = script.Parent.Parent.Parent.Universo.Settings |
024 |
025 | local DButton1 = script.Parent.Parent.Parent.Universo.Home.Btools |
026 |
027 | local DButton2 = script.Parent.Parent.Parent.Universo.Home.FlingM |
028 |
029 | local DButton3 = script.Parent.Parent.Parent.Universo.Home.KillM |
030 |
031 | local DButton4 = script.Parent.Parent.Parent.Universo.Home.FlyOFF |
032 |
033 | local DButton5 = script.Parent.Parent.Parent.Universo.Home.FlyON |
034 |
035 | local DButton6 = script.Parent.Parent.Parent.Universo.Home.NoColideON |
036 |
037 | local DButton7 = script.Parent.Parent.Parent.Universo.Home.NoColideOFF |
038 |
039 | local DButton8 = script.Parent.Parent.Parent.Universo.Home.Nohat |
040 |
041 | local DButton9 = script.Parent.Parent.Parent.Universo.Home.JHBox |
042 |
043 | local DButton10 = script.Parent.Parent.Parent.Universo.Home.JHSet |
044 |
045 | local DButton11 = script.Parent.Parent.Parent.Universo.Home.WSBox |
046 |
047 | local DButton12 = script.Parent.Parent.Parent.Universo.Home.WSSet |
048 |
049 | local DButton13 =script.Parent.Blue |
050 |
051 | local DButton14 =script.Parent.Darkmode |
052 |
053 | local DButton15 =script.Parent.Green |
054 |
055 | local DButton16 =script.Parent.Lightmode |
056 |
057 | local DButton17 =script.Parent.Orange |
058 |
059 | local DButton18 =script.Parent.Purple |
060 |
061 | local DButton19 =script.Parent.Red |
062 |
063 | local DButton20 =script.Parent.Yellow |
064 |
065 | local DButton21 = script.Parent.Parent.Parent.Universo.Settings.Delte |
066 |
067 | local DButton22 = script.Parent.Parent.Parent.Universo.Settings.DragRepair |
068 |
069 | local DButton23 = script.Parent.Parent.Parent.Universo.Settings.OPBox |
070 |
071 | local DButton24 = script.Parent.Parent.Parent.Universo.Settings.OPSet |
072 |
073 | local DButton25 = script.Parent.Parent.Parent.Universo.Settings.Themes |
074 |
075 | local DButton26 = script.Parent.Parent.Parent.Universo.Settings.Update |
076 |
077 | local LButton1 = script.Parent.Parent.Parent.Universo.AboutB |
078 |
079 | local LButton2 = script.Parent.Parent.Parent.Universo.GamesB |
080 |
081 | local LButton3 = script.Parent.Parent.Parent.Universo.HomeB |
082 |
083 | local LButton4 = script.Parent.Parent.Parent.Universo.SettingsB |
084 |
085 |
086 |
087 | script.Parent.Blue.MouseButton1Click:Connect(function() |
088 |
089 | |
090 |
091 | FrameD1.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
092 |
093 | FrameD2.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
094 |
095 | DButton1.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
096 |
097 | DButton2.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
098 |
099 | DButton3.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
100 |
101 | DButton4.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
102 |
103 | DButton5.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
104 |
105 | DButton6.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
106 |
107 | DButton7.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
108 |
109 | DButton8.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
110 |
111 | DButton9.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
112 |
113 | DButton10.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
114 |
115 | DButton11.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
116 |
117 | DButton12.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
118 |
119 | DButton13.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
120 |
121 | DButton14.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
122 |
123 | DButton15.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
124 |
125 | DButton16.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
126 |
127 | DButton17.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
128 |
129 | DButton18.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
130 |
131 | DButton19.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
132 |
133 | DButton20.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
134 |
135 | DButton21.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
136 |
137 | DButton22.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
138 |
139 | DButton23.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
140 |
141 | DButton24.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
142 |
143 | DButton25.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
144 |
145 | DButton26.BackgroundColor3 = Color3.new(Color3.fromRGB(DarkerBlue)) |
146 |
147 | FrameL1.BackgroundColor3 = Color3.new(Color3.fromRGB(LighterBlue)) |
148 |
149 | FrameL2.BackgroundColor3 = Color3.new(Color3.fromRGB(LighterBlue)) |
150 |
151 | FrameL3.BackgroundColor3 = Color3.new(Color3.fromRGB(LighterBlue)) |
152 |
153 | FrameL4.BackgroundColor3 = Color3.new(Color3.fromRGB(LighterBlue)) |
154 |
155 | FrameL5.BackgroundColor3 = Color3.new(Color3.fromRGB(LighterBlue)) |
156 |
157 | LButton1.BackgroundColor3 = Color3.new(Color3.fromRGB(LighterBlue)) |
158 |
159 | LButton2.BackgroundColor3 = Color3.new(Color3.fromRGB(LighterBlue)) |
160 |
161 | LButton3.BackgroundColor3 = Color3.new(Color3.fromRGB(LighterBlue)) |
162 |
163 | LButton4.BackgroundColor3 = Color3.new(Color3.fromRGB(LighterBlue)) |
164 |
165 | end) |
1 answer
Log in to vote
1
Instead of trying to make a new color3 for every line, you should instead make the color3 where you define your variables. Also RGB color3s can only take values between 0 and 1, so you should divide all numbers by 255, like:
1 | local DarkerBlue = Color3.new(53/255 ,56/255 ,255/255) |
2 | local LighterBlue = Color3.new(101/255, 103/255, 255/255) |
So instead of
1 | Color3.new(Color3.fromRGB()) |
you should use the new variables you just defined. You can also greatly reduce the amount of lines of code you have by using loops. More info on loops here: https://developer.roblox.com/articles/Roblox-Coding-Basics-Loops
Hope this helps!
0
Thank you very much for the solution! Lualaxy 78 — 6y