[SOLVED MYSELF]How to make a player's screen go white for a bit and then fade away without lagging?

Asked by

6 years ago

Edited 6 years ago

[ALREADY SOLVED]

This is the third time I am asking this question since the last two times I asked I didn't get an answer.

I am making a stun system that when the player gets hit by a survivor with a baseball bat, he gets stunned and his screen turns white. It works perfectly, but I am having a big problem involving lag.

I am currently using a GUI with a blank frame with the size set to {0, 1000}, {0, 1000} and when the player gets stunned the GUI gets cloned to the player's PlayerGui, and the stunned player's FPS drops dramatically and I have no idea why.

I wanted to know if there is a way to fix the lag or if there is a different way to do it what doesn't lag.

Script just incase you need it

01--<Variables>--
02local players = game:GetService("Players")
03local repStorage = game:GetService("ReplicatedStorage")
04local debris = game:GetService("Debris")
05 
06local remotesFolder = repStorage:WaitForChild("Remotes")
07local GUIsFolder = repStorage:WaitForChild("GUIs")
08 
09local equipmentRemote = remotesFolder:WaitForChild("EquipmentRemote")
10 
11local stunnedGUI = GUIsFolder:WaitForChild("StunnedGUI")
12 
13--<Functions>--
14local function castEquipment(player)
15    local wPlayer = workspace:WaitForChild(player.Name)
16 
17    if not wPlayer:FindFirstChild("Survivor") then return end
18    if wPlayer:FindFirstChild("CantUseEquipment") then return end
19 
20    local humanoid = wPlayer:WaitForChild("Humanoid")
21    local equipment = wPlayer:WaitForChild("Equipment")
22    local equipmentAnimation = wPlayer:WaitForChild("EquipmentAnimation")
23 
24    local hitSFX = equipment:WaitForChild("HitSFX")
25    local swingSFX = equipment:WaitForChild("SwingSFX")
26 
27    swingSFX:Play()
28 
29    local equipmentAnimationTrack = humanoid:LoadAnimation(equipmentAnimation)
30    equipmentAnimationTrack:Play()
31 
32    local cantUseEquipment = Instance.new("BoolValue", wPlayer)
33    cantUseEquipment.Name = "CantUseEquipment"
34 
35    local isUsingEquipment = Instance.new("BoolValue", wPlayer)
36    isUsingEquipment.Name = "IsUsingEquipment"
37 
38    local stats = wPlayer:WaitForChild("Stats")
39 
40    local equipmentSpeed = stats:WaitForChild("EquipmentSpeed")
41    local equipmentCoolDown = stats:WaitForChild("EquipmentCoolDown")
42    local equipmentFunction = stats:WaitForChild("EquipmentFunction")
43 
44    debris:AddItem(cantUseEquipment, equipmentCoolDown.Value)
45    debris:AddItem(isUsingEquipment, equipmentSpeed.Value)
46 
47    local function castEquipmentFunction(hit)
48        if not wPlayer:FindFirstChild("IsUsingEquipment") then return end
49        if hit.Parent:FindFirstChild("IsHitByEquipment") then return end
50        if hit.Parent:FindFirstChild("Survivor") then return end
51        if hit.Parent.Name == player.Name then return end
52        if string.match(hit.Parent.Name, "Dummy") then return end
53 
54        local humanoid = hit.Parent:FindFirstChild("Humanoid")
55 
56        if humanoid then
57            if equipmentFunction.Value == "Stun" then
58                humanoid.WalkSpeed = 0
59 
60                local victimStats = hit.Parent:WaitForChild("Stats")
61                local victimDefaultWalkSpeed = victimStats:WaitForChild("DefaultWalkSpeed")
62 
63                local sVictim = players:WaitForChild(player.Name)
64                local sVictimPlayerGUI = sVictim:WaitForChild("PlayerGui")
65 
66                local newStunnedGUI = stunnedGUI:Clone()
67                stunnedGUI.Parent = sVictimPlayerGUI
68 
69                wait(2)
70 
71                for i = 1, 100 do
72                    newStunnedGUI.BackgroundTransparency = newStunnedGUI.BackgroundTransparency + (.01)
73                    wait(.01)
74                end
75 
76                humanoid.WalkSpeed = victimDefaultWalkSpeed.Value
77            end
78        end
79    end
80 
81    for i, v in pairs(wPlayer:GetChildren()) do
82        if v:IsA("Part") or v:IsA("BasePart") or v:IsA("MeshPart") or v:IsA("UnionOperation") then
83            v.Touched:Connect(castEquipmentFunction)
84        end
85    end
86end
87 
88--<Callers>--
89equipmentRemote.OnServerEvent:Connect(castEquipment)
 View all 89 lines...

You would use the tween service. The "lag" is probably down to another bit of code you are using. A simple fade will not cause the fps to drop. Use the micro profiler to check what is causing the "lag" User#5423 17 — 6y

I honestly don't think that is the case since if I make the GUI smaller the FPS doesn't drop, it's the size of the GUI and I want to keep it's size. arthurdaniel91 72 — 6y

The size of the GUI will have little impact on performance? User#5423 17 — 6y

I think you are missing something here. Try and replicate the "lag" in a blank project. User#5423 17 — 6y

View all comments (8 more)

When you get hit by a survivor, your walkspeed is set to 0 and the GUI is cloned, when the GUI is cloned, the FPS drops to 1 arthurdaniel91 72 — 6y

One big problemis that you are trying to change the gui fom the server so yes it will "lag" User#5423 17 — 6y

And you have no debounce for your castEquipmentFunction meaning it will also run multiple times. User#5423 17 — 6y

Yeah that might be it, thanks, I will try to make the GUI client-sided now arthurdaniel91 72 — 6y

Actually, there is a debounce at line 49 that (return end) thing works as a debounce. arthurdaniel91 72 — 6y

I am not sure it will work as you expect. but these are things only you can check. also remember that each time the remote runs you are connecting new Touched functions. Very very easy to exploit. User#5423 17 — 6y

Depends, my style of scripting might be way different from other developers and a bit hard to crack. arthurdaniel91 72 — 6y

"When you get hit by a survivor" did you connect a Touched event to a part? Show the code for it. awesomeipod 607 — 6y

[SOLVED MYSELF]How to make a player's screen go white for a bit and then fade away without lagging?

2 answers

Answer this question