Why is it saying that I'm staff instead of guest?
So basically when a player joins it's supposed to check if their userid is in the table, if it is then their rank value will be staff, if not, it will be guest. I didn't put my ID in the table but it still sets my value as staff instead of guest.
01 | local staff = {"11", "131226890", "169602215"} |
02 |
03 | game.Players.PlayerAdded:Connect(function(plr) |
04 | local userid = plr.UserId |
05 | local leader = Instance.new("Folder") |
06 | leader.Name = "leaderstats" |
07 | leader.Parent = plr |
08 |
09 | local rank = Instance.new("StringValue") |
10 | rank.Name = "RANK" |
11 | rank.Parent = leader |
12 | for i, userid in pairs(staff) do |
13 | if userid then |
14 | rank.Value = "STAFF" |
15 | else |
16 | rank.Value = "GUEST" |
17 | end |
18 | end |
19 | end) |
0
2 answers
Problem
Why is it saying that I'm staff instead of guest?
Whats wrong
First you're not even comparing if the player's UserId and the userid when iterating are equal. Second you're overwriting your original reference to userid. In this case you're checking if userid has truthiness. Strings have truthiness and so the conditional will always be true
Example
1 | if "abc" then |
2 | print"true" |
3 | else |
4 | print"false" |
5 | end |
>>true
Solution
Use a different variable name and a actually compare whether they are equal when iterating. Also we will want to use tostring on plr.UserId since the indexes inside our staff array are strings Also we are using break to stop the loop when they're staff to prevent it from continuing.
Example
01 | local staff = {"39939779", "131226890", "169602215"} |
02 |
03 | game.Players.PlayerAdded:Connect(function(plr) |
04 | local userid = tostring(plr.UserId) |
05 | local leader = Instance.new("Folder") |
06 |
07 | leader.Name = "leaderstats" |
08 | leader.Parent = plr |
09 |
10 | local rank = Instance.new("StringValue") |
11 |
12 | rank.Name = "RANK" |
13 | rank.Parent = leader |
14 |
15 | for i, staffUserId in pairs(staff) do |
To fix this do this:
01 | local staff = {"11", "131226890", "169602215"} |
02 |
03 | game.Players.PlayerAdded:Connect(function() |
04 | local userid = plr.UserId |
05 | local leader = Instance.new("Folder") |
06 | leader.Name = "leaderstats" |
07 | leader.Parent = plr |
08 |
09 | local rank = Instance.new("StringValue") |
10 | rank.Name = "RANK" |
11 | rank.Parent = leader |
12 | rank.Value = "Guest" |
13 | for i,v in pairs(staff) do |
14 | if userid == v then |
15 | rank.Value = "Staff" |
16 | end |
17 | end |
18 | end) |
Simple