Scripting Helpers is winding down operations and is now read-only. More info→

[UNSOLVED] Help with a Huge Script (2)?

Asked by

SlickPwner 534

10 years ago

So instead of editing my last thread, I just decided to put it into a new Question because I changed it so much. It still doesn't work, but it's a lot cleaner, and in two scripts now. So, if you didn't see the last thread, I'm trying to script an RPG game. I want it so that when a player connects, a function assigns a bunch of BoolValues and NumberValues to represent Experience, Levels, HP, etc. Whenever I test it, it gives me in the output "Gold is not a valid member of Player", "Gems is not a valid member of Player" etc, for each of the Values, and I'm not sure what I did wrong. Here's the code:

01--THIS IS IN A REGULAR SCRIPT, NOT LOCALSCRIPT
02--Player value Variables
03Gold = Instance.new("NumberValue")
04Gems = Instance.new("NumberValue")
05PlayerLevel = Instance.new("NumberValue")
06Exp = Instance.new("NumberValue")
07HP = Instance.new("NumberValue")
08Quest1 = Instance.new("BoolValue")
09Quest2 = Instance.new("BoolValue")
10Quest3 = Instance.new("BoolValue")
11Quest4 = Instance.new("BoolValue")
12Quest5 = Instance.new("BoolValue")
13Player = game.Players.LocalPlayer
14Gold = 10
15Gems = 0
16PlayerLevel = 1
17 
18--Gui frame variables
19ScreenGui = game.StarterGui.ScreenGui
20ShopBG = ScreenGui.ShopBG
21QuestsBG = ScreenGui.QuestsBG
22StatsBG = ScreenGui.StatsBG
23OptionsBG = ScreenGui.OptionsBG
24 
25--Start of functions
26wait(3)
27 
28 
29a = game.Players.LocalPlayer:GetChildren()
30 
31function assignValues() --assigns LocalPlayer all necessary values
32repeat wait() until Player --waits until Player is loaded before assigning values
33for i,v in pairs(a) do
34    if v:IsA("BoolValue" or "NumberValue") then --makes sure that the Player doesn't have values assigned already
35        Player.MaxHealth = Player.HP.Value
36    else --if they don't have values, then it assigns them values
37 
38    Gold.Parent = Player
39    Gold.Name = "Gold"
40    Gold.Value = 10
41    Gems.Parent = Player
42    Gems.Name = "Gems"
43    Gems.Value = 0
44    PlayerLevel.Parent = Player
45    PlayerLevel.Name = "PlayerLevel"
46    PlayerLevel.Value = 1
47    Exp.Parent = Player
48    Exp.Name = "Exp"
49    HP.Parent = Player
50    HP.Name = "HP"
51    Quest1.Parent = Player
52    Quest1.Name = "Quest1"
53    Quest1.Value = false
54    Quest2.Parent = Player
55    Quest2.Name = "Quest2"
56    Quest2.Value = false
57    Quest3.Parent = Player
58    Quest3.Name = "Quest3"
59    Quest3.Value = false
60    Quest4.Parent = Player
61    Quest4.Name = "Quest4"
62    Quest4.Value = false
63    Quest5.Parent = Player
64    Quest5.Name = "Quest5"
65    Quest5.Value = false
66 
67end    
68end
69end
70 
71 
72game.Players.PlayerAdded:connect(assignValues)
 View all 72 lines...

There is another script that assigns XP and Levels up the Player. I'm not sure if you need to see that too, but I'll include the code:

01--THIS IS IN A LOCALSCRIPT
02--Player value Variables
03Gold = Instance.new("NumberValue")
04Gems = Instance.new("NumberValue")
05PlayerLevel = Instance.new("NumberValue")
06Exp = Instance.new("NumberValue")
07HP = Instance.new("NumberValue")
08Quest1 = Instance.new("BoolValue")
09Quest2 = Instance.new("BoolValue")
10Quest3 = Instance.new("BoolValue")
11Quest4 = Instance.new("BoolValue")
12Quest5 = Instance.new("BoolValue")
13Player = game.Players.LocalPlayer
14Gold = 10
15Gems = 0
16PlayerLevel = 1
17 
18--Gui frame variables
19ScreenGui = game.StarterGui.ScreenGui
20ShopBG = ScreenGui.ShopBG
21QuestsBG = ScreenGui.QuestsBG
22StatsBG = ScreenGui.StatsBG
23OptionsBG = ScreenGui.OptionsBG
24 
25--Start of functions
26wait(3)
27 
28 
29while true do
30local xps = {0, 100, 300, 600, 1000, 1500, 2000, 2500, 3000, 4000, 5000, 6500, 8000, 9500, 11000, 12500, 14000, 15500, 18000, 21000, 25000, 30000, 35000, 40000, 45000, 50000, 57500, 65000, 72500, 82500, 100000};
31local xp = Player.Exp.Value;
32local level = 1;
33while xps[level] and xps[level] <= xp do
34    level = level + 1;
35end
36 
37Player.HP.Value = 200 + 100 * Player.PlayerLevel.Value;
38 
39end
 View all 39 lines...

What script is triggering the error? What line? Because there remains to be nothing which could trigger it in any of these scripts BlueTaslem 18071 — 10y

I'm not getting anything in the output but "Gold is not a valid member of Player" for all of my Variables I set. SlickPwner 534 — 10y

3 answers

Answered by

RedCombee 585

10 years ago

The reason you're having issues is because you are rewriting the variables "Gold" and "Gems" as non-instances. This means that they are linked to the script and will not be found in the player.

In the script you have:

`1`	`Gold` `=` `Instance.new("NumberValue")`

and:

`1`	`Gold` `=` `10`

therefore you are rewriting the same variable. In order to fix this problem;

`1`	`Gold` `=` `Instance.new("NumberValue")`

`2`	`Gold.Value` `=` `10`

and then remove the line of code that sets its value to 10 after it is created.

You are also being repetitive, because you set the value of Gold twice in the script.

While this is also a mistake in the script, it still wouldn't trigger the error he named BlueTaslem 18071 — 10y

I changed it, though I still haev the same error. The script just isn't inserting the Values. SlickPwner 534 — 10y

Answered by

Shawnyg 4330

10 years ago

One reason is that in line 13 and 29 of script 1, you attempted to get the LocalPlayer which is only accessible from a Local Script. Looking at the second script, it seems it has the same problem on line 13. Change both of them to local scripts.

I changed both of them to LocalScripts and I still have the same problem. SlickPwner 534 — 10y

Answered by

Perci1 4988

10 years ago

Since game.Players.LocalPlayer only works through local script, loop through all the player with a for loop instead, if you want to affect all the players.

1for i,player in pairs(game.Players:GetPlayers()) do
2print(player)
3end

I just changed it to a LocalScript. The values still aren't being assigned though. SlickPwner 534 — 10y

[UNSOLVED] Help with a Huge Script (2)?

3 answers

Answer this question