Scripting Helpers is winding down operations and is now read-only. More info→

I can't save money data and I don't know why?

Asked by

sheepposu 561

6 years ago

Edited 6 years ago

I've stayed up all night trying to get this to work but it just wouldn't . The code makes sense to me, so I can't figure out why it won't work. The output says no errors, just returning a nil value for trying to find the player Id. Which means it is not properly saving my Id to the data bank.

Heres the code. I've labeled it. The code is in a regular script inside 'ServerScriptService'

01--Creates the data Store as ds
02local ds = game:GetService("DataStoreService"):GetDataStore("-xBuckDatax-")
03 
04game.Players.PlayerAdded:Connect(function(player)
05    -- saves the player Id as key
06    local key = "Player_"..player.UserId
07    local folder = Instance.new("Folder",player)
08    folder.Name = "leaderstats"
09    local money = Instance.new("IntValue",folder)
10    money.Name = 'ObbyBucks<|>'
11    local moneyalready
12    --moneyalready is the id of the player
13    local success, err = pcall(function()
14        moneyalready.Value = ds:GetAsync(key)
15    end)
16    -- if it found the players Id, It made money equivilent to what was saved in the data store 
17    if success then
18        money.Value = moneyalready
19    else
20        --If not, money is equivilent to 100 and it saves that to the data store
21        money.Value = 100
22        ds:SetAsync(key, 100)
23    end
24end)
25 
26-- when someone is leaving...
27game.Players.PlayerRemoving:Connect(function(player)
28    local key = "Player_"..player.UserId
29    --saves their key and money to the data store
30    ds:SetAsync(key, player.leaderstats["ObbyBucks<|>"].Value)
31end)
 View all 31 lines...

I noticed on line 14 that you have the Value you want to save indexed in the get async parameters you just need to Put the key Inside and leave out the "BlahBlah.Value" so: DataStore:GetAsync(Key) Cyrakohl 108 — 6y

1 answer

Answered by

zblox164 531

6 years ago

Edited 6 years ago

You should save using tables. This will make it easier in the future to add other values too. I fixed up your code below but keep in mind this is untested.

01local Players = game:GetService("Players")
02local DataStoreService = game:GetService("DataStoreService")
03local DataStore = DataStoreService:GetDataStore("-xBuckDatax-")
04 
05-- Making the saving inside a function it shortened your code by a bit.
06local function Save(player)
07    local key = "Player_"..player.UserId
08 
09    local save = {
10        ["ObbyBucks"] = player.leaderstats["ObbyBucks<|>"].Value
11    }
12 
13    --saves their key and money to the data store
14    local success, err = pcall(function()
15        DataStore:SetAsync(key, save)
16    end)
17 
18    if not success then
19        warn("Failed to over-write data"..tostring(err))
20        return
21    end
22end
23 
24-- I made this a function so it can be called whenever
25local function Load(player)
26    -- saves the player Id as key
27    local key = player.UserId
28 
29    local folder = Instance.new("Folder")
30    folder.Name = "leaderstats"
31    folder.Parent = player -- setting the parent in the .new is deprecated
32 
33    local money = Instance.new("IntValue")
34    money.Name = "ObbyBucks<|>"
35    money.Parent = folder
36 
37    local moneyAlready
38 
39    local success, err = pcall(function()
40        moneyAlready.Value = DataStore:GetAsync(key)
41    end)
42 
43    if not success then
44        warn("Failed to read data"..tostring(err))
45        return
46    end
47 
48    if moneyAlready then
49        money.Value = moneyAlready.ObbyBucks
50    else
51        Save(player)
52    end
53end
54 
55Players.PlayerAdded:Connect(Load)
56Players.PlayerRemoving:Connect(Save)
 View all 56 lines...

All I did was improve the code.

What I did:

Split the DataStore variables, made the saving and loading in a function that you control when it's called, editing the save and load system, removed deprecated code.

More information on DataStores

So the past 40 min I have been testing it and looking over it and finally I've come out with it not working. This script is great. Thankyou. I posted a vid of me testing it out right here - https://youtu.be/VB7j4XKfXgM You may be able to find the prob. sheepposu 561 — 6y

Im going to assume he solved your problem from that comment alone so I'll accept the answer on your behalf. Next time accept the answer that helped you the most. User#24403 69 — 6y

It didn't solve my problem tho sheepposu 561 — 6y

Do you have data stores enabled? zblox164 531 — 6y

I can't save money data and I don't know why?

1 answer

Answer this question