Scripting Helpers is winding down operations and is now read-only. More info→

Please help my script keeps breaking and not working? (Read desc)

Asked by

Da_ve5 0

6 years ago

01print("Cash Leaderboard Loaded")
02 
03 
04function onPlayerEntered(newPlayer)
05 
06    local stats = Instance.new("IntValue")
07    stats.Name = "leaderstats"
08 
09    local cash = Instance.new("IntValue")
10    cash.Name = "Money"       --name of currency (e.g. cash, money, resources, bucks, etc.)
11    cash.Value = 1000      --starting money.
12 
13    cash.Parent = stats
14    stats.Parent = newPlayer
15end
16 
17 
18 
19game.Players.ChildAdded:connect(onPlayerEntered)
20end
21  end
22 
23game.Players.PlayerAdded:connect(function(p)
24local stats = Instance.new("IntValue", p)
25stats.Name = "leaderstats"
26local money = Instance.new("IntValue", stats)
27money.Name = "Cash"
28money.Value = 100
29while true do
30wait(5)
31money.Value = money.Value + 10
32end
33end)
 View all 33 lines...

It won't give me money nor I can't see it on the leaderboard. Please help.

2 answers

Answered by

Tommydogs22 2

6 years ago

Hey,

You've got two unnecessary "end"s on line 20 and 21.

You usually have an end after an if, an function and so on.

I also changed ChildAdded to PlayerAdded, that is better and then it wont break if something else is inserted into Players.

Here is the code with the problem solved:

01print("Cash Leaderboard Loaded")
02 
03 
04function onPlayerEntered(newPlayer)
05 
06    local stats = Instance.new("IntValue")
07    stats.Name = "leaderstats"
08 
09    local cash = Instance.new("IntValue")
10    cash.Name = "Money"       --name of currency (e.g. cash, money, resources, bucks, etc.)
11    cash.Value = 1000      --starting money.
12 
13    cash.Parent = stats
14    stats.Parent = newPlayer
15end
16 
17 
18 
19game.Players.PlayerAdded:connect(onPlayerEntered)
20 
21game.Players.PlayerAdded:connect(function(p)
22local stats = Instance.new("IntValue", p)
23stats.Name = "leaderstats"
24local money = Instance.new("IntValue", stats)
25money.Name = "Cash"
26money.Value = 100
27while true do
28wait(5)
29money.Value = money.Value + 10
30end
31end)
 View all 31 lines...

thanks Da_ve5 0 — 6y

Answered by

RequiredModule 38

6 years ago

The first problem is that when you are making a leaderboard you first have to make a model and name it 'leaderstats'.

This will work, I removed the first function because I didn't see the purpose of it

01print("Cash Leaderboard Loaded")
02 
03game.Players.PlayerAdded:connect(function(p)
04local stats = Instance.new("Model")
05stats.Parent = p
06stats.Name = "leaderstats"
07local money = Instance.new("IntValue")
08money.Parent = stats
09money.Name = "Cash"
10money.Value = 100
11while true do
12wait(5)
13money.Value = money.Value + 10
14end
15end)

it doesn't have to be a model, it can be anything with the name "leaderstats" theking48989987 2147 — 6y

Please help my script keeps breaking and not working? (Read desc)

2 answers

Answer this question