Scripting Helpers is winding down operations and is now read-only. More info→

What's wrong with this datastore code and how can I fix it?

Asked by

6 years ago

I've been trying to make a character customization GUI in which all of the character values save. However, everything works fine until when the player leaves. When they leave, the values don't update, they stay the same as they were previously when I joined the game. When I use a datastore editor plugin, and change them, they load as the values I changed them to, but when I change them in studio or in the game, the values appear to change but they still don't save when I leave.

Here's my datastore code:

01local DataStore = game:GetService("DataStoreService"):GetDataStore("CustomizationData")
02 
03game.Players.PlayerAdded:Connect(function(player)
04    wait(1)
05    --Creating the customization values for the player
06    local Folder = Instance.new("Folder", player)
07    Folder.Name = (player.Name.."Values")
08 
09    local SkinTone = Instance.new("IntValue", Folder)
10    SkinTone.Name = "SkinTone"
11 
12    local HairOne = Instance.new("IntValue", Folder)
13    HairOne.Name = "HairOne"
14 
15    local HairTwo = Instance.new("IntValue", Folder)
16    HairTwo.Name = "HairTwo"
17 
18    local HairColour = Instance.new("IntValue", Folder)
19    HairColour.Name = "HairColour"
20 
21    local Shirt = Instance.new("IntValue", Folder)
22    Shirt.Name = "Shirt"
23 
24    local Pants = Instance.new("IntValue", Folder)
25    Pants.Name = "Pants"
26 
27    local Key = (player.Name.."Data")
28 
29    --Setting the values based on the datastore
30    local Get_Data = DataStore:GetAsync(Key)
31    if Get_Data then
32        SkinTone.Value = Get_Data[1]
33        HairOne.Value = Get_Data[2]
34        HairTwo.Value = Get_Data[3]
35        HairColour.Value = Get_Data[4]
36        Shirt.Value = Get_Data[5]
37        Pants.Value = Get_Data[6]
38    else
39        SkinTone.Value = 1
40        HairOne.Value = 1
41        HairTwo.Value = 1
42        HairColour.Value = 1
43        Shirt.Value = 1
44        Pants.Value = 1
45    end
46    for i, v in pairs(Folder:GetChildren()) do
47        v.Changed:Connect(function()
48            DataStore:SetAsync(Key, {SkinTone.Value, HairOne.Value, HairTwo.Value, HairColour.Value, Shirt.Value, Pants.Value})
49            print("Data changed, set")
50            print(SkinTone.Value)
51        end)
52    end
53end)
54 
55game.Players.PlayerRemoving:Connect(function(player)
56    local Key = (player.Name.."Data")
57    local Folder = player:FindFirstChild(player.Name.."Values")
58    local SkinTone = Folder.SkinTone
59    print (SkinTone.Value)
60    local HairOne = Folder.HairOne
61    local HairTwo = Folder.HairTwo
62    local HairColour = Folder.HairColour
63    local Shirt = Folder.Shirt
64    local Pants = Folder.Pants
65    print(SkinTone.Value)
66    print("Saved")
67    DataStore:SetAsync(Key, {SkinTone.Value, HairOne.Value, HairTwo.Value, HairColour.Value, Shirt.Value, Pants.Value})
68end)
 View all 68 lines...

Use BindToClose greatneil80 2647 — 6y

1 answer

Answered by

rower86 35

6 years ago

I suggest making the function that begins at line 55 a variable for this, your problem is that the saving code doesn't run before the game closes when the last player of a server leaves. To fix this use the built in function BindToClose. BindToClose fully runs a code right before the server closes.

01local function SavePlayerStats(player)
02        local Key = (player.Name.."Data")
03        local Folder = player:FindFirstChild(player.Name.."Values")
04        local SkinTone = Folder.SkinTone
05        print (SkinTone.Value)
06        local HairOne = Folder.HairOne
07        local HairTwo = Folder.HairTwo
08        local HairColour = Folder.HairColour
09        local Shirt = Folder.Shirt
10        local Pants = Folder.Pants
11        print(SkinTone.Value)
12        print("Saved")
13        DataStore:SetAsync(Key, {SkinTone.Value, HairOne.Value, HairTwo.Value, HairColour.Value, Shirt.Value, Pants.Value})
14end
15 
16game:BindToClose(function()
17    for i, player in pairs(game.Players:GetPlayers()) do
18        SavePlayerStats(player)
19    end
20end) -- the BindToClose function will save the player's data before the server closes -- and also ensures that multiple player's data will save if there is a server crash or something (which is what the loop does)
21 
22game.Players.PlayerRemoving:Connect(function()
23    SavePlayerStats(player)
24end) -- when a player leaves but the server is not closing, their data will save
 View all 24 lines...

`SetAsync` yields, so if it takes too long and there's a few players, some might not get their data saved; the solution's to use a coroutine. TheeDeathCaster 2368 — 6y

Even after implementing this into it, it's still failing to save the data. Any other solutions? Archimeus 0 — 6y

Try using this method - https://www.youtube.com/watch?v=PhtniVQbwlk rower86 35 — 6y

What's wrong with this datastore code and how can I fix it?

1 answer

Answer this question