Scripting Helpers is winding down operations and is now read-only. More info→

My while loop won't work even though VALUE is true?

Asked by

retrobricks 162

6 years ago

Edited 6 years ago

Even though pressed is true the loop won't start?

btw there is a value called pressed and it is false

01wait(5)
02--Varibles
03local player = game.Players.LocalPlayer
04local mouse = player:GetMouse()
05local pressed = false
06local character = game.Workspace[player.Name]
07local RoundNumber = 10
08 
09--Round function
10local function Round(Number)
11    return math.floor((Number / RoundNumber) + 0.5) * RoundNumber
12end
13 
14--Wall
15while pressed == true do
16    print("test")
17    local x = character.LowerTorso.Position.x
18    local y = character.LowerTorso.Position.y
19    local z = character.LowerTorso.Position.z
20    game.Workspace.TransparentTestWall.Position = Vector3.new(Round(x), y+7.8, Round(z) -16.5)
21    wait(0.01)
22end
23 
24mouse.KeyDown:Connect(function(key)
25    if key == "q" then
26        pressed = true
27        print(pressed)
28    end
29end)
 View all 29 lines...

no retrobricks 162 — 6y

*wait (0.01)* Doesn't work anymore, only *(0.1)* works now. dawidu156 5 — 6y

its a local script retrobricks 162 — 6y

yes retrobricks 162 — 6y

View all comments (8 more)

in the script retrobricks 162 — 6y

il edit it for the whole script retrobricks 162 — 6y

Im not certain this is the issue but, try putting your Keydown function above the while loop in the script. DinozCreates 1070 — 6y

already have... retrobricks 162 — 6y

once the script runs to the point of the while loop and it sees that pressed is false, it will go past it. its not going to wait for the value to turn to true. you have to use an event for that or an infinite loop Gey4Jesus69 2705 — 6y

.1* Ziffixture 6913 — 6y

I would just do while wait() do and put if statement in it. (if pressed == true then) CrazyTwinkle -1 — 6y

That is bad practice. I wouldn't recommend it. User#25115 0 — 6y

2 answers

Answered by

User#25115 0

6 years ago

Edited 6 years ago

Hello there! Your issue is common to many and unique to none. We should be able to get your script working pretty quickly. I'll just list the issues here for a quick overview:

You assume that a while loop keeps checking after the condition is determined to be false.
You are using KeyDown, a deprecated event.
You are defining the character through the workspace, which is not good practice.
You have a wait(5) at the top of your script for no reason.
I couldn't find anything about LowerTorso. I'm not sure if it exists. I'll be using the HumanoidRootPart instead.

Now that I've listed the problems, let's go about solving them. First of all, your while loop will stop checking the condition once it's false. Here's a simpler example so you can see why:

1local x = 1
2while x < 5 do
3    x = x + 1
4    print(x)
5end
6print("loop is done")
7x = 3
8-- Nothing else prints

As you can see, this won't work for what you are trying to do. There are two alternatives to your problem (I will include examples at the end of my answer):

1.) Put the while loop in a function that is called whenever q is pressed.

2.) Put the while loop in the event listener directly.

The next problem is that you are using KeyDown, a deprecated event. If you look here, you can see a message that says, "Mouse events have been superseded by UserInputService which should be used in all new work." Clearly, we are intended to use UserInputService instead. For this answer, I'm just going to cover how to detect a key being pressed(If you want a button to pop up for a mobile user, you may want to consider using ContextActionService instead). Here's an example of how you would implement UserInputService to detect the q key being pressed with InputBegan:

01--[[
02    GetService is the recommended method 
03    for getting services, especially on the client.
04--]]
05local userInputService = game:GetService("UserInputService") 
06 
07userInputService.InputBegan:Connect(function(inputObj, gameProcessed)
08    if not gameProcessed and inputObj.KeyCode == Enum.KeyCode.Q then
09        print("Pressed")
10    end
11end)

Quick note about the gameProcessed parameter from the API reference:

Indicates whether the game engine internally observed this input and acted on it. Generally this refers to UI processing, so if a button was touched or clicked from this input, gameProcessedEvent would be true. This is also true for input events connected via ContextActionService.

Finally, that wait(5) at the top of your script is unnecessary. If you're using the proper methods in their proper places, there is no need to yield. You can use the :Wait() method of the CharacterAdded event to wait for the character to load in, if it hasn't already.

Ok, here you are. Your final script should look like one of these two options:

01--[[ Services ]]--
02 
03local players = game:GetService("Players")
04local userInputService = game:GetService("UserInputService")
05 
06--[[ Variables ]]--
07 
08local player = players.LocalPlayer
09local pressed = false
10local character = player.Character or player.CharacterAdded:Wait()
11local wall = workspace.TransparentTestWall -- define variables for things you are using
12local RoundNumber = 10
13 
14--[[ Functions ]]--
15 
16local function Round(Number)
17    return math.floor((Number / RoundNumber) + 0.5) * RoundNumber
18end
19 
20local function changePos()
21    while pressed do -- pressed == true is redundant
22        print("test")
23 
24        local torsoPos = character.HumanoidRootPart.Position
25        local x = hrpPos.x
26        local y = hrpPos.y
27        local z = hrpPos.z
28 
29        wall.Position = Vector3.new(Round(x), y+7.8, Round(z) -16.5)
30 
31        wait(0.01)
32    end
33end
34 
35userInputService.InputBegan:Connect(function(inputObj, gameProcessed)
36    if not gameProcessed and inputObj.KeyCode == Enum.KeyCode.Q then
37        print("Pressed")
38        if pressed then -- I included a way to turn it off
39            pressed = false
40        else
41            pressed = true
42            changePos()
43        end
44    end
45end)
 View all 45 lines...

01--[[ Services ]]--
02 
03local players = game:GetService("Players")
04local userInputService = game:GetService("UserInputService")
05 
06--[[ Variables ]]--
07 
08local player = players.LocalPlayer
09local pressed = false
10local character = player.Character or player.CharacterAdded:Wait()
11local wall = workspace.TransparentTestWall -- define variables for things you are using
12local RoundNumber = 10
13 
14--[[ Functions ]]--
15 
16local function Round(Number)
17    return math.floor((Number / RoundNumber) + 0.5) * RoundNumber
18end
19 
20userInputService.InputBegan:Connect(function(inputObj, gameProcessed)
21    if not gameProcessed and inputObj.KeyCode == Enum.KeyCode.Q then
22        print("Pressed")
23        if pressed then -- I included a way to turn it off
24            pressed = false
25        else
26            pressed = true
27            while pressed do -- pressed == true is redundant
28                print("test")
29 
30                local hrpPos = character.HumanoidRootPart.Position
31                local x = hrpPos.x
32                local y = hrpPos.y
33                local z = hrpPos.z
34 
35                wall.Position = Vector3.new(Round(x), y+7.8, Round(z) -16.5)
36 
37                wait(0.01)
38            end
39        end
40    end
41end)
 View all 41 lines...

Personally, I prefer the former, but it's really up to you.

I hope this helps. Have a great day scripting!

Note that anything you do client side will not replicate to the server. If you want to have that functionality, you'll have to use remotes. More on those here: https://wiki.roblox.com/index.php?title=Remote_Functions_%26_Events User#25115 0 — 6y

If you have any additional comments or questions, feel free to ask them below. User#25115 0 — 6y

Your a god. retrobricks 162 — 6y

Answered by

Gey4Jesus69 2705

6 years ago

Edited 6 years ago

Try this:

01wait(5)
02--Varibles
03local UIS = game:GetService("UserInputService")
04local player = game.Players.LocalPlayer
05local mouse = player:GetMouse()
06local pressed = Instance.new("BoolValue")
07pressed.Name = "Pressed" --so we can run .Changed
08pressed.Parent = player
09local character = player.Character or player.CharacterAdded:Wait() --never scan in workspace for character
10local RoundNumber = 10
11 
12--Round function
13local function Round(Number)
14    return math.floor((Number / RoundNumber) + 0.5) * RoundNumber
15end
16 
17--Wall
18pressed:GetPropertyChangedSignal("Value"):Connect(function()
19    while pressed.Value == true do
20        print("test")
21        local x = character.LowerTorso.Position.x
22        local y = character.LowerTorso.Position.y
23        local z = character.LowerTorso.Position.z
24        game.Workspace.TransparentTestWall.Position = Vector3.new(Round(x), y+7.8, Round(z) -16.5)
25        wait(0.01)
26    end
27end)
28 
29UIS.InputBegan:Connect(function(key,gameProc) --mouse.KeyDown deprecated
30    if not gameProc then --if not interacting with core gui
31        if key.KeyCode == Enum.KeyCode.Q then
32            pressed.Value = true
33        end
34    end
35end)
 View all 35 lines...

Note my comments, as well as the fact that changes to parts in workspace via the client will not replicate to the server. If you don't want this change to occur locally, you'll have to use remote events.

Answers beginning with "Try this:" are generally bad. User#25115 0 — 6y

i explained my answer in the code so whatever Gey4Jesus69 2705 — 6y

My while loop won't work even though VALUE is true?

2 answers

I hope this helps. Have a great day scripting!

Answer this question