Scripting Helpers is winding down operations and is now read-only. More info→

Instance of "hint" not removing?

Asked by

FearlessX96 74

6 years ago

As simple as this code is. I can't seem to find out why it won't work.

1script.Parent.Touched:Connect(function()
2msg = Instance.new("Hint", workspace)
3msg.Text = "Hello It's Me!"
4wait(5)
5msg:Remove()
6end)

I touch the part, it fires an event and the message pops up in workspace. After 5 seconds it doesn't remove itself though...

Remove() is deprecated in favor of Destroy() DinozCreates 1070 — 6y

2 answers

Answered by

User#5423 17

6 years ago

Edited 6 years ago

You are using a global variable which is part of the problem. The other part to this problem is that the Touched event will run each time something touches it.

With both of these problems it is possible to override the global variable leaking Hint instances.

Scenario:-

Touched event run
Create new instance and set it to the global variable wait 5
Touched event run
Create new instance and set it to the global variable overwriting the existing Hint instance
(wait 5 end)
Destroy msg
Destroy the same msg

To resolve this you can use a debounce to prevent the event from running the function again while it is being used in another thread (each event call is a new thread in Roblox).

Using local variables would also solve this problem as the variable would only be accessible from within the function itself and each call to this function would have its own new set of variables created. In this case you only have one which holds the Hint instance.

There are other options such as the Debris service but on this level it does not really matter how you delete the Hint instance (but do not use Remove).

To solve this we would just add a debounce and make the variable local as it is good practice.

01local deb = false -- debounce is accessible outside the function so it is shared
02script.Parent.Touched:Connect(function()
03    if deb then return end -- prevent calls from running this code
04    deb = true -- enable debounce
05 
06    -- create Hint 
07    local msg = Instance.new("Hint", workspace)
08    msg.Text = "Hello It's Me!"
09    wait(5)
10    msg:Destroy() -- pls use Destroy
11 
12    deb = false -- reset
13end)

Hope this helps.

Answered by

stef0206 125

6 years ago

Edited 6 years ago

Try this!

01ready = true
02 
03script.Parent.Touched:Connect(function()
04    if ready == true then
05        ready = false
06        msg = Instance.new("Hint", workspace)
07        msg.Text = "Hello It's Me!"
08        wait(5)
09        msg:Destroy()
10        ready = true
11    end
12end)

Hope this helps! All I did was Remove() To Destroy() and add a debounce so the script can only fire once it's finished

Instance of "hint" not removing?

2 answers

Answer this question