Scripting Helpers is winding down operations and is now read-only. More info→

My script is suppose to do a function if happen = true, but the first part of it isent working?

Asked by

danglt 185

6 years ago

Edited 6 years ago

My script will run and the first part will work changing tvalue but for some reason after that when i make happen = true after that it makes it true but then the happen.Changed function doesent activate, I have no idea why.

I put a print under the changed function and I got no print, so the problem is the Changed Function not working in the beginning

001local vipid = 5785777
002 
003local Players = game:GetService("Players")
004 
005local ews = game.Workspace.EventModel
006local efolder = game.Lighting.EventModels
007local evalues = game.ReplicatedStorage.EventValues
008local tvalue = game.ReplicatedStorage.Values.tvalue
009local aevent = game.ReplicatedStorage.Values.aevent
010local acevent = game.ReplicatedStorage.Values.caevent
011local happen = game.ReplicatedStorage.Values.happen
012local aname = game.ReplicatedStorage.Values.ename
013local money = game.ReplicatedStorage.Values.money
014 
015local events = {"FloorIsLava","Event","BlackHole"}
016 
017 
018 
019tvalue.Value = 5          --------------------------- PROBLEM STARTS HERE
020        wait(1)
021        tvalue.Value = 4
022        wait(1)
023        tvalue.Value = 3
024        wait(1)
025        tvalue.Value = 2
026        wait(1)
027        tvalue.Value = 1
028        wait(1)
029        happen.Value = true
030        wait()
031 
032happen.Changed:Connect(function()
033    local apick = math.random(1,3)
034    if happen.Value == true and acevent.Value == true then
035        happen.Value = false
036        if aevent.Value == "FloorIsLava" then
037            aname.Value = "FloorIsLava"
038            aevent.Value = ""
039            acevent.Value = false
040            wait()
041            print("AFloorIsLava")
042            local fur = efolder.FloorIsLava.Furniture
043            local lava = efolder.FloorIsLava.Lava
044            fur.Parent = ews
045            tvalue.Value = 15
046            wait(1)
047            tvalue.Value = 14
048            wait(1)
049            tvalue.Value = 13
050            wait(1)
051            tvalue.Value = 12
052            wait(1)
053            tvalue.Value = 11
054            wait(1)
055            tvalue.Value = 10
056            wait(1)
057            tvalue.Value = 9
058            wait(1)
059            tvalue.Value = 8
060            lava.Parent = ews
061            wait(1)
062            tvalue.Value = 7
063            wait(1)
064            tvalue.Value = 6
065            wait(1)
066            tvalue.Value = 5
067            wait(1)
068            tvalue.Value = 4
069            wait(1)
070            tvalue.Value = 3
071            wait(1)
072            tvalue.Value = 2
073            wait(1)
074            tvalue.Value = 1
075            wait(1)
076            tvalue.Value = 0
077            lava.Parent = efolder.FloorIsLava
078            fur.Parent = efolder.FloorIsLava
079for i, player in pairs(Players:GetPlayers()) do
080    if game:GetService("MarketplaceService"):UserOwnsGamePassAsync(player.UserId,vipid) then
081        player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
082            player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50 + 20
083            else    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
084            player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50
085    end
086 
087            end
088aname.Value = "Intermission"
089        tvalue.Value = 5
090        wait(1)
091        tvalue.Value = 4
092        wait(1)
093        tvalue.Value = 3
094        wait(1)
095        tvalue.Value = 2
096        wait(1)
097        tvalue.Value = 1
098        wait(1)
099        happen.Value = true
100 
101 
102        elseif aevent.Value == "BlackHole" then
103            aevent.Value = ""
104            aname.Value = "BlackHole"
105            acevent.Value = false
106            wait()
107            print("BlackHole")
108            happen.Value = false
109            game.Workspace.Map.Ground.Velocity = Vector3.new(30,0,0)
110            local bh = game.Lighting.EventModels.BlackHole
111            bh.Parent = game.Workspace.EventModel
112            for i, player in pairs(Players:GetPlayers()) do
113                player.Character.Humanoid.PlatformStand = true
114end
115tvalue.Value = 15
116            wait(1)
117            tvalue.Value = 14
118            wait(1)
119            tvalue.Value = 13
120            wait(1)
121            tvalue.Value = 12
122            wait(1)
123            tvalue.Value = 11
124            wait(1)
125            tvalue.Value = 10
126            wait(1)
127            tvalue.Value = 9
128            wait(1)
129            tvalue.Value = 8
130            wait(1)
131            tvalue.Value = 7
132            wait(1)
133            tvalue.Value = 6
134            wait(1)
135            tvalue.Value = 5
136            wait(1)
137            tvalue.Value = 4
138            wait(1)
139            tvalue.Value = 3
140            wait(1)
141            tvalue.Value = 2
142            wait(1)
143            tvalue.Value = 1
144            wait(1)
145            tvalue.Value = 0
146            bh.Parent = game.Lighting.EventModels
147            game.Workspace.Map.Ground.Velocity = Vector3.new(0,0,0)
148            for i, player in pairs(Players:GetPlayers()) do
149                player.Character.Humanoid.PlatformStand = false
150                aname.Value = "Intermission"
151        for i, player in pairs(Players:GetPlayers()) do
152    if game:GetService("MarketplaceService"):UserOwnsGamePassAsync(player.UserId,vipid) then
153        player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
154            player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50 + 20
155            else    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
156            player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50
157 
158            end
159aname.Value = "Intermission"
160        tvalue.Value = 5
161        wait(1)
162        tvalue.Value = 4
163        wait(1)
164        tvalue.Value = 3
165        wait(1)
166        tvalue.Value = 2
167        wait(1)
168        tvalue.Value = 1
169        wait(1)
170        happen.Value = true
171end
172        end
173end
174    elseif happen.Value == true and acevent.Value == false then
175        if apick == 1 then
176                        aevent.Value = ""
177            aname.Value = "BlackHole"
178            acevent.Value = false
179            wait()
180            print("BlackHole")
181            happen.Value = false
182            game.Workspace.Map.Ground.Velocity = Vector3.new(30,0,0)
183            local bh = game.Lighting.EventModels.BlackHole
184            bh.Parent = game.Workspace.EventModel
185            for i, player in pairs(Players:GetPlayers()) do
186                player.Character.Humanoid.PlatformStand = true
187end
188tvalue.Value = 15
189            wait(1)
190            tvalue.Value = 14
191            wait(1)
192            tvalue.Value = 13
193            wait(1)
194            tvalue.Value = 12
195            wait(1)
196            tvalue.Value = 11
197            wait(1)
198            tvalue.Value = 10
199            wait(1)
200            tvalue.Value = 9
201            wait(1)
202            tvalue.Value = 8
203            wait(1)
204            tvalue.Value = 7
205            wait(1)
206            tvalue.Value = 6
207            wait(1)
208            tvalue.Value = 5
209            wait(1)
210            tvalue.Value = 4
211            wait(1)
212            tvalue.Value = 3
213            wait(1)
214            tvalue.Value = 2
215            wait(1)
216            tvalue.Value = 1
217            wait(1)
218            tvalue.Value = 0
219            bh.Parent = game.Lighting.EventModels
220            game.Workspace.Map.Ground.Velocity = Vector3.new(0,0,0)
221            for i, player in pairs(Players:GetPlayers()) do
222                player.Character.Humanoid.PlatformStand = false
223                aname.Value = "Intermission"
224                end
225        for i, player in pairs(Players:GetPlayers()) do
226    if game:GetService("MarketplaceService"):UserOwnsGamePassAsync(player.UserId,vipid) then
227        player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
228            player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50 + 20
229            else    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
230            player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50
231    end
232 
233            end
234aname.Value = "Intermission"
235        tvalue.Value = 5
236        wait(1)
237        tvalue.Value = 4
238        wait(1)
239        tvalue.Value = 3
240        wait(1)
241        tvalue.Value = 2
242        wait(1)
243        tvalue.Value = 1
244        wait(1)
245        happen.Value = true
246        elseif apick == 2 then
247            happen.Value = false
248            aname.Value = "FloorIsLava"
249        print("FloorIsLava")
250        print("AFloorIsLava")
251            local fur = efolder.FloorIsLava.Furniture
252            local lava = efolder.FloorIsLava.Lava
253            fur.Parent = ews
254            tvalue.Value = 15
255            wait(1)
256            tvalue.Value = 14
257            wait(1)
258            tvalue.Value = 13
259            wait(1)
260            tvalue.Value = 12
261            wait(1)
262            tvalue.Value = 11
263            wait(1)
264            tvalue.Value = 10
265            wait(1)
266            tvalue.Value = 9
267            wait(1)
268            tvalue.Value = 8
269            lava.Parent = ews
270            wait(1)
271            tvalue.Value = 7
272            wait(1)
273            tvalue.Value = 6
274            wait(1)
275            tvalue.Value = 5
276            wait(1)
277            tvalue.Value = 4
278            wait(1)
279            tvalue.Value = 3
280            wait(1)
281            tvalue.Value = 2
282            wait(1)
283            tvalue.Value = 1
284            wait(1)
285            tvalue.Value = 0
286            lava.Parent = efolder.FloorIsLava
287            fur.Parent = efolder.FloorIsLava
288for i, player in pairs(Players:GetPlayers()) do
289    if game:GetService("MarketplaceService"):UserOwnsGamePassAsync(player.UserId,vipid) then
290        player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
291            player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50 + 20
292            else    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
293            player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50
294    end
295 
296            end
297aname.Value = "Intermission"
298        tvalue.Value = 5
299        wait(1)
300        tvalue.Value = 4
301        wait(1)
302        tvalue.Value = 3
303        wait(1)
304        tvalue.Value = 2
305        wait(1)
306        tvalue.Value = 1
307        wait(1)
308        happen.Value = true
309        elseif apick == 3 then
310            happen.Value = false
311            aname.Value = "event3"
312        print("event3")
313        for i, player in pairs(Players:GetPlayers()) do
314    if game:GetService("MarketplaceService"):UserOwnsGamePassAsync(player.UserId,vipid) then
315        player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
316            player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50 + 20
317            else    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
318            player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50
319    end
320 
321            end
322aname.Value = "Intermission"
323        tvalue.Value = 5
324        wait(1)
325        tvalue.Value = 4
326        wait(1)
327        tvalue.Value = 3
328        wait(1)
329        tvalue.Value = 2
330        wait(1)
331        tvalue.Value = 1
332        wait(1)
333        happen.Value = true
334aname.Value = "Intermission"
335        tvalue.Value = 5
336        wait(1)
337        tvalue.Value = 4
338        wait(1)
339        tvalue.Value = 3
340        wait(1)
341        tvalue.Value = 2
342        wait(1)
343        tvalue.Value = 1
344        wait(1)
345        happen.Value = true
346        end
347        end
348 
349    end)
 View all 349 lines...

Your script requires that both acevent and happen are true, not just happen, check that acevent is true at the same time SerpentineKing 3885 — 6y

There is a spot for that... elseif happen.Value == true and acevent.Value == false then... Also as i stated if i put a print under the changed, It dosent print danglt 185 — 6y

I'd recommend learning how to use for loops. User#25115 0 — 6y

Are you sure that "Changed" is a valid event of "happen", since it should at least print if it is SerpentineKing 3885 — 6y

View all comments (2 more)

Yes, as if i change it manually it works danglt 185 — 6y

Good lord... if that isn't spaghetti code then I don't know what is. T0XN 276 — 6y

2 answers

Answered by

Overscores 381

6 years ago

Edited 6 years ago

The Changed event hasn't been registered yet by your code, and therefore never runs. You have to move it before you change the value if you want it to run.

1--This is what you have, will never print "It changed!"
2myValue.Value = 5
3myValue.Changed:Connect(function()
4    print("It changed!")
5end)

1--This is what you should have, this will print "It changed!"
2myValue.Changed:Connect(function()
3    print("It changed!")
4end)
5myValue.Value = 5

I don't have access to studios right now because I'm on a school chromebook but when I get home ill see if it works and ill accept danglt 185 — 6y

Answered by

DinozCreates 1070

6 years ago

Edited 6 years ago

This isnt an answer i just wanted to fix your gross indention and add some basic for loops. On line 108 i think there was an extra end, i commented it out.

001local vipid = 5785777
002 
003local Players = game:GetService("Players")
004 
005local ews = game.Workspace.EventModel
006local efolder = game.Lighting.EventModels
007local evalues = game.ReplicatedStorage.EventValues
008local tvalue = game.ReplicatedStorage.Values.tvalue
009local aevent = game.ReplicatedStorage.Values.aevent
010local acevent = game.ReplicatedStorage.Values.caevent
011local happen = game.ReplicatedStorage.Values.happen
012local aname = game.ReplicatedStorage.Values.ename
013local money = game.ReplicatedStorage.Values.money
014 
015local events = {"FloorIsLava","Event","BlackHole"}
016 
017tvalue.Value = 5
018for i = 1, 5 do
019    tvalue.Value = tvalue.Value -1     --------------------------- PROBLEM STARTS HERE
020        wait(1)
021end
022 
023happen.Value = true
024wait()
025 
026happen.Changed:Connect(function()
027    local apick = math.random(1,3)
028    if happen.Value == true and acevent.Value == true then
029        happen.Value = false
030        if aevent.Value == "FloorIsLava" then
031            aname.Value = "FloorIsLava"
032            aevent.Value = ""
033            acevent.Value = false
034            wait()
035            print("AFloorIsLava")
036            local fur = efolder.FloorIsLava.Furniture
037            local lava = efolder.FloorIsLava.Lava
038            fur.Parent = ews
039            tvalue.Value = 15
040            wait(1)
041            for i = 1, 7 do
042                tvalue.Value = tvalue.Value - 1
043                wait(1)
044            end
045            lava.Parent = ews
046            for i = 1, 8 do
047                tvalue.Value = tvalue.Value - 1
048                wait(1)
049            end
050            lava.Parent = efolder.FloorIsLava
051            fur.Parent = efolder.FloorIsLava
052            for i, player in pairs(Players:GetPlayers()) do
053                if game:GetService("MarketplaceService"):UserOwnsGamePassAsync(player.UserId,vipid) then
054                    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
055                    player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50 + 20
056                else
057                    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
058                    player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50
059                end
060            end
061            aname.Value = "Intermission"
062            tvalue.Value = 5
063            for i = 1, 5 do
064                tvalue.Value = tvalue.Value - 1
065                wait(1)
066            end
067            happen.Value = true
068 
069        elseif aevent.Value == "BlackHole" then
070            aevent.Value = ""
071            aname.Value = "BlackHole"
072            acevent.Value = false
073            wait()
074            print("BlackHole")
075            happen.Value = false
076            game.Workspace.Map.Ground.Velocity = Vector3.new(30,0,0)
077            local bh = game.Lighting.EventModels.BlackHole
078            bh.Parent = game.Workspace.EventModel
079            for i, player in pairs(Players:GetPlayers()) do
080                player.Character.Humanoid.PlatformStand = true
081            end
082            tvalue.Value = 15
083            for i = 1, 15 do
084                tvalue.Value = tvalue.Value - 1
085            wait(1)
086        end
087 
088        bh.Parent = game.Lighting.EventModels
089        game.Workspace.Map.Ground.Velocity = Vector3.new(0,0,0)
090        for i, player in pairs(Players:GetPlayers()) do
091            player.Character.Humanoid.PlatformStand = false
092            aname.Value = "Intermission"
093            if game:GetService("MarketplaceService"):UserOwnsGamePassAsync(player.UserId,vipid) then
094                    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
095                        player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50 + 20
096                    else
097                player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
098                        player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50
099                    end
100        aname.Value = "Intermission"
101            tvalue.Value = 5
102        for i = 1, 5 do
103            tvalue.Value = tvalue.Value - 1
104            wait(1)
105        end
106            happen.Value = true
107    end
108    --end
109    elseif happen.Value == true and acevent.Value == false then
110            if apick == 1 then
111            aevent.Value = ""
112            aname.Value = "BlackHole"
113            acevent.Value = false
114            wait()
115            print("BlackHole")
116            happen.Value = false
117            game.Workspace.Map.Ground.Velocity = Vector3.new(30,0,0)
118            local bh = game.Lighting.EventModels.BlackHole
119            bh.Parent = game.Workspace.EventModel
120            for i, player in pairs(Players:GetPlayers()) do
121                player.Character.Humanoid.PlatformStand = true
122            end
123            tvalue.Value = 15
124            for i = 1, 15 do
125                tvalue.Value = tvalue.Value - 1
126                wait(1)
127            end
128            bh.Parent = game.Lighting.EventModels
129            game.Workspace.Map.Ground.Velocity = Vector3.new(0,0,0)
130            for i, player in pairs(Players:GetPlayers()) do
131                player.Character.Humanoid.PlatformStand = false
132                aname.Value = "Intermission"
133            end
134            for i, player in pairs(Players:GetPlayers()) do
135                if game:GetService("MarketplaceService"):UserOwnsGamePassAsync(player.UserId,vipid) then
136                    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
137                    player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50 + 20
138                else
139                    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
140                    player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50
141                end
142            end
143            aname.Value = "Intermission"
144                tvalue.Value = 5
145            for i = 1, 5 do
146                tvalue.Value = tvalue.Value - 1
147                wait(1)
148            end
149                happen.Value = true
150            elseif apick == 2 then
151            happen.Value = false
152            aname.Value = "FloorIsLava"
153            print("FloorIsLava")
154            print("AFloorIsLava")
155            local fur = efolder.FloorIsLava.Furniture
156            local lava = efolder.FloorIsLava.Lava
157            fur.Parent = ews
158            tvalue.Value = 15
159            wait(1)
160            for i = 1, 7 do
161                tvalue.Value = tvalue.Value - 1
162                wait(1)
163            end
164            lava.Parent = ews
165            for i = 1, 8 do
166                tvalue.Value = tvalue.Value - 1
167                wait(1)
168            end
169            lava.Parent = efolder.FloorIsLava
170            fur.Parent = efolder.FloorIsLava
171            for i, player in pairs(Players:GetPlayers()) do
172                if game:GetService("MarketplaceService"):UserOwnsGamePassAsync(player.UserId,vipid) then
173                    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
174                    player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50 + 20
175                else   
176                    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
177                    player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50
178                end
179 
180            end
181            aname.Value = "Intermission"
182            tvalue.Value = 5
183            for i = 1, 5 do
184                tvalue.Value = tvalue.Value - 1
185                wait(1)
186            end
187            happen.Value = true
188        elseif apick == 3 then
189            happen.Value = false
190            aname.Value = "event3"
191            print("event3")
192            for i, player in pairs(Players:GetPlayers()) do
193                if game:GetService("MarketplaceService"):UserOwnsGamePassAsync(player.UserId,vipid) then
194                    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
195                    player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50 + 20
196                else
197                    player.leaderstats.Events.Value = player.leaderstats.Events.Value + 1
198                    player.leaderstats.Coins.Value = player.leaderstats.Coins.Value + 50
199                end
200 
201            end
202            aname.Value = "Intermission"
203            tvalue.Value = 5
204            for i = 1, 5 do
205                tvalue.Value = tvalue.Value - 1
206                wait(1)
207            end
208            happen.Value = true
209            aname.Value = "Intermission"
210                tvalue.Value = 5
211            for i = 1, 5 do
212                tvalue.Value = tvalue.Value - 1
213                wait(1)
214            end
215                happen.Value = true
216            end
217        end
218end)
 View all 218 lines...

My script is suppose to do a function if happen = true, but the first part of it isent working?

2 answers

Answer this question