Scripting Helpers is winding down operations and is now read-only. More info→

DataStore Saved with 2 leaderstats but not with 4?

Asked by

LennyPlayzYT 269

6 years ago

I made a DataStore Service with 2 lstats (Leaderstats) and it worked, but I tried adding 2 more (4) and then it broke. Any ideas?

001local dataStores = game:GetService("DataStoreService")
002local ds1 = dataStores:GetDataStore("CashDataStore")
003local ds2 = dataStores:GetDataStore("LevelDataStore")
004local ds3 = dataStores:GetDataStore("RankDataStore")
005local ds4 = dataStores:GetDataStore("Total XP")
006local defaultCash = 0
007local playersLeft = 0
008local defaultLevel = 1
009local defaultRank = "InK"
010local DefaultXP = 0
011 
012 
013--[[
014    Ok So LStats Are
015    Cash
016    Level
017    Rank
018    XP
019--]]
020game.Players.PlayerAdded:Connect(function(player)
021 
022 playersLeft = playersLeft + 1
023 
024 local leaderstats = Instance.new("Folder")
025 leaderstats.Name = "leaderstats"
026 leaderstats.Parent = player
027 
028 local Cash = Instance.new("IntValue")
029 Cash.Name = "Cash"
030 Cash.Value = 0
031 Cash.Parent = leaderstats
032 
033 local Level = Instance.new("IntValue")
034 Level.Name = "Level"
035 Level.Value = 1
036 Level.Parent = leaderstats
037 
038 local Rank = Instance.new("StringValue")
039 Rank.Name = "Rank"
040 Rank.Value = "Innocent Killer"
041 Rank.Parent = leaderstats
042 
043 local XP = Instance.new("IntValue")
044 XP.Name = "XP"
045 XP.Value = 0
046 XP.Parent = leaderstats
047 
048 
049 
050 
051 player.CharacterAdded:Connect(function(character)
052 
053  character.Humanoid.Died:Connect(function(character)
054   --Whenever Somebody dies, this event will run
055 
056   if character.Humanoid and character.Humanoid:FindFistChild("creator") then
057    game.ReplicatedStorage.Status.Value = tostring(character.Humanoid.creator.Value).." KILLED "..player.Name
058   end
059   if character:FindFirstChild("GameTag") then
060    character.GameTag:Destroy()
061   end
062 
063   player.LoadCharacter()
064  end)
065 
066 
067 end)
068 
069--[[
070DATASTORE PLEASE HELP HERE
071DATASTORE PLEASE HELP HERE
072DATASTORE PLEASE HELP HERE
073DATASTORE PLEASE HELP HERE
074DATASTORE PLEASE HELP HERE
075]]
076 
077 local player_data
078 local player_data2
079 local player_data3
080 local player_data4
081 
082 pcall(function()
083  player_data = ds1:GetAsync(player.UserId.."-Cash") -- 1736284-Cash
084  player_data2 = ds2:GetAsync(player.UserId.."-Level") --1736284 Levels
085  player_data3 = ds3:GetAsync(player.UserId.."-Rank")
086  player_data4 = ds4:GetAsync(player.UserId.."-XP")
087 end)
088 
089 if player_data ~= nil then
090  --Player has saved data , load it in
091  Cash.Value = player_data
092 else
093  --New Player
094  Cash.Value = defaultCash
095 end
096 
097if player_data2 ~= nil then
098    Level.Value = player_data2
099else
100    Level.Value = defaultLevel
101end
102 
103if player_data3 ~= nil then
104    Rank.Value = player_data3
105else
106    Rank.Value = defaultRank
107end
108 
109if player_data4 ~= nil then
110    XP.Value = player_data4
111else
112    XP.Value = DefaultXP
113end
114 
115end)
116 
117local bindableEvent = Instance.new("BindableEvent")
118 
119game.Players.PlayerRemoving:Connect(function(player)
120 
121 pcall(function()
122  ds1:SetAsync(player.UserId.."-Cash", player.leaderstats.Cash.Value)
123  ds2:SetAsync(player.UserId.."-Level", player.leaderstats.Level.Value)
124  ds3:SetAsync(player.UserId.."-Rank", player.leaderstats.Rank.Value)
125  ds4:SetAsync(player.UserId.."-XP", player.leaderstats.XP.Value)
126  print('All ds saved')
127  playersLeft = playersLeft - 1
128  bindableEvent:Fire()
129 end)
130 
131end)
132 
133game:BindToClose(function()
134 --This will be triggered upon shutdown
135 while playersLeft > 0 do
136  bindableEvent.Event:Wait()
137end
138end)
 View all 138 lines...

Change line 5 to // local ds4 = dataStores:GetDataStore("Total_XP") \\ NiniBlackJackQc 1562 — 6y

You can save them all into one datastore. Using multiple at once will easily reach the per minute saving limit of datastores. Rheines 661 — 6y

So what do I do? LennyPlayzYT 269 — 6y

1 answer

Answered by

stef0206 125

6 years ago

Edited 6 years ago

The problem is probally that you are setting the XP and Rank to a saved value, when there most likely is none, try this, might be something else

001local dataStores = game:GetService("DataStoreService")
002local ds1 = dataStores:GetDataStore("CashDataStore")
003local ds2 = dataStores:GetDataStore("LevelDataStore")
004local ds3 = dataStores:GetDataStore("RankDataStore")
005local ds4 = dataStores:GetDataStore("Total XP")
006local defaultCash = 0
007local playersLeft = 0
008local defaultLevel = 1
009local defaultRank = "InK"
010local DefaultXP = 0
011 
012 
013--[[
014    Ok So LStats Are
015    Cash
016    Level
017    Rank
018    XP
019--]]
020game.Players.PlayerAdded:Connect(function(player)
021 
022 playersLeft = playersLeft + 1
023 
024 local leaderstats = Instance.new("Folder")
025 leaderstats.Name = "leaderstats"
026 leaderstats.Parent = player
027 
028 local Cash = Instance.new("IntValue")
029 Cash.Name = "Cash"
030 Cash.Value = 0
031 Cash.Parent = leaderstats
032 
033 local Level = Instance.new("IntValue")
034 Level.Name = "Level"
035 Level.Value = 1
036 Level.Parent = leaderstats
037 
038 local Rank = Instance.new("StringValue")
039 Rank.Name = "Rank"
040 Rank.Value = "Innocent Killer"
041 Rank.Parent = leaderstats
042 
043 local XP = Instance.new("IntValue")
044 XP.Name = "XP"
045 XP.Value = 0
046 XP.Parent = leaderstats
047 
048 
049 
050 
051 player.CharacterAdded:Connect(function(character)
052 
053  character.Humanoid.Died:Connect(function(character)
054   --Whenever Somebody dies, this event will run
055 
056   if character.Humanoid and character.Humanoid:FindFistChild("creator") then
057    game.ReplicatedStorage.Status.Value = tostring(character.Humanoid.creator.Value).." KILLED "..player.Name
058   end
059   if character:FindFirstChild("GameTag") then
060    character.GameTag:Destroy()
061   end
062 
063   player.LoadCharacter()
064  end)
065 
066 
067 end)
068 
069--[[
070DATASTORE PLEASE HELP HERE
071DATASTORE PLEASE HELP HERE
072DATASTORE PLEASE HELP HERE
073DATASTORE PLEASE HELP HERE
074DATASTORE PLEASE HELP HERE
075]]
076 
077 local player_data
078 local player_data2
079 local player_data3
080 local player_data4
081 
082 pcall(function()
083  player_data = ds1:GetAsync(player.UserId.."-Cash") or defaultCash-- 1736284-Cash
084  player_data2 = ds2:GetAsync(player.UserId.."-Level") or defaultLevel--1736284 Levels
085  player_data3 = ds3:GetAsync(player.UserId.."-Rank") or defaultRank
086  player_data4 = ds4:GetAsync(player.UserId.."-XP") or DefaultXP
087 end)
088 
089 if player_data ~= nil then
090  --Player has saved data , load it in
091  Cash.Value = player_data
092 else
093  --New Player
094  Cash.Value = defaultCash
095 end
096 
097if player_data2 ~= nil then
098    Level.Value = player_data2
099else
100    Level.Value = defaultLevel
101end
102 
103if player_data3 ~= nil then
104    Rank.Value = player_data3
105else
106    Rank.Value = defaultRank
107end
108 
109if player_data4 ~= nil then
110    XP.Value = player_data4
111else
112    XP.Value = DefaultXP
113end
114 
115end)
116 
117local bindableEvent = Instance.new("BindableEvent")
118 
119game.Players.PlayerRemoving:Connect(function(player)
120 
121 pcall(function()
122  ds1:SetAsync(player.UserId.."-Cash", player.leaderstats.Cash.Value)
123  ds2:SetAsync(player.UserId.."-Level", player.leaderstats.Level.Value)
124  ds3:SetAsync(player.UserId.."-Rank", player.leaderstats.Rank.Value)
125  ds4:SetAsync(player.UserId.."-XP", player.leaderstats.XP.Value)
126  print('All ds saved')
127  playersLeft = playersLeft - 1
128  bindableEvent:Fire()
129 end)
130 
131end)
132 
133game:BindToClose(function()
134 --This will be triggered upon shutdown
135 while playersLeft > 0 do
136  bindableEvent.Event:Wait()
137end
138end)
 View all 138 lines...

Hopes this helps

DataStore Saved with 2 leaderstats but not with 4?

1 answer

Answer this question