Scripting Helpers is winding down operations and is now read-only. More info→

Why doesn't it save, all leaderstats saves except this one?

Asked by

6 years ago

No idea what's wrong with the fishvalue, I want it other leaderstat but not in leaderstats, I want it like hidden leaderstat which helps script but to not make it visible on leaderstats.. Here is my script

01local DataStoreService = game:GetService("DataStoreService")
02local CashDS = DataStoreService:GetDataStore("CashDS-")
03local IbDS = DataStoreService:GetDataStore("IbDS-")
04local CatchesDS = DataStoreService:GetDataStore("CatchesDS-")
05local FishValueDS = DataStoreService:GetDataStore("FishValueDS-")
06 
07game.Players.PlayerAdded:Connect(function(plr)
08    local stats = Instance.new("IntValue",plr)
09    stats.Name = "leaderstats"
10    local cash = Instance.new("IntValue",stats)
11    cash.Name = "Cash"
12    local ib = Instance.new("IntValue",stats)
13    ib.Name = "InBucket"
14    local xp = Instance.new("IntValue",stats)
15    xp.Name = "Catches"
16    local fv = Instance.new("IntValue",plr)
17    fv.Name = "FishValue"
18 
19    cash.Value = CashDS:GetAsync(tostring(plr.userId)) or 0
20    ib.Value = IbDS:GetAsync(tostring(plr.userId)) or 0
21    xp.Value = CatchesDS:GetAsync(tostring(plr.userId)) or 0
22    fv.Value = FishValueDS:GetAsync(tostring(plr.userId)) or 0
23 
24    CashDS:SetAsync(tostring(plr.userId),cash.Value)
25    IbDS:SetAsync(tostring(plr.userId), ib.Value)
26    CatchesDS:SetAsync(tostring(plr.userId), xp.Value)
27    FishValueDS:SetAsync(tostring(plr.userId),fv.Value)
28 
29    cash.Changed:connect(function() 
30        CashDS:SetAsync(tostring(plr.userId), cash.Value)
31    end)
32 
33    ib.Changed:connect(function()
34        IbDS:SetAsync(tostring(plr.userId), ib.Value)
35    end)
36 
37    xp.Changed:connect(function()
38        CatchesDS:SetAsync(tostring(plr.userId), xp.Value)
39    end)
40 
41    fv.Changed:connect(function()
42        FishValueDS:SetAsync(tostring(plr.userId), fv.Value)
43    end)
44end)
 View all 44 lines...

Why are you using individual data stores for each value. You can use one giant data store and save a table instead User#24403 69 — 6y

I have changed it to one but that doesnt matter kapipi12 133 — 6y

1 answer

Answered by

arshad145 392

6 years ago

Hello,

Please accept this answer.

01local DataStoreService = game:GetService("DataStoreService")
02local DS = DataStoreService:GetDataStore("Single_DS")
03 
04game.Players.PlayerAdded:Connect(function(plr)
05    local key = tostring(plr.UserId)
06    local stats = Instance.new("IntValue") -- Avoid using one line instance parenting.
07    local cash = Instance.new("IntValue")
08    local ib = Instance.new("IntValue")
09    local xp = Instance.new("IntValue")
10    local fv = Instance.new("IntValue")
11 
12    stats.Name = "leaderstats"
13    cash.Name = "Cash"
14    ib.Name = "InBucket"
15    xp.Name = "Catches"
16    fv.Name = "FishValue"
17 
18    stats.Parent = plr
19    cash.Parent = stats
20    ib.Parent = stats
21    xp.Parent = stats
22    fv.Parent = plr
23 
24    local data = DS:GetAsync(key)
25 
26    if data then
27        for i, v in pairs(data) do
28            print("Loaded " .. i,v )
29        end
30        for i,v in pairs(stats:GetChildren()) do
31            v.Value = data[v.Name]
32        end
33        fv.Value = data[fv.Name]
34    else
35        for i,v in pairs(stats:GetChildren()) do
36            v.Value = 0
37        end
38        fv.Value = 0
39        data = {}
40        for i,v in pairs(player.leaderstats:GetChildren()) do
41            data[v.Name] = v.Value
42        end
43        data[fv.Name] = fv.Value
44        for i, v in pairs(data) do
45            print("saved " .. i,v )
46        end
47        DS:SetAsync(key, data)
48    end
49end)
50 
51game.Players.PlayerRemoving:Connect(function(player)
52    local key = tostring(player.UserId)
53    local data = {}
54    for i,v in pairs(player.leaderstats:GetChildren()) do
55        data[v.Name] = v.Value
56    end
57    data[player.FishValue.Name] = player.FishValue.Value
58    for i, v in pairs(data) do
59        print("saved " .. i,v )
60    end
61    DS:SetAsync(key, data)
62end)
 View all 62 lines...

This was resolved on discord server. arshad145 392 — 6y

Why doesn't it save, all leaderstats saves except this one?

1 answer

Answer this question