Scripting Helpers is winding down operations and is now read-only. More info→

Sprites are moving when they shouldn't?

Asked by

BrockRocksYourSocks 48

6 years ago

(Yes, I'm making a sprite-based game. Don't ask why.)

01local label = script.Parent
02local RunService = game:GetService("RunService")
03local Debris = game:GetService("Debris")
04local length = label:WaitForChild("Length")
05local width = label:WaitForChild("Width")
06local angle = label:WaitForChild("Angle")
07local delaytime = label:WaitForChild("Delay")
08local life = label:WaitForChild("Lifetime")
09local t = label:WaitForChild("Transparency")
10 
11local delayLine = Instance.new("Frame")
12delayLine.Parent = label
13delayLine.Name = "DelayLine"
14delayLine.Size = UDim2.new(0, 1, length.Value, 0)
15delayLine.AnchorPoint = Vector2.new(0, 0)
16delayLine.BorderSizePixel = 0
17delayLine.BackgroundColor3 = Color3.fromRGB(255, 255, 255)
18delayLine.BackgroundTransparency = 0.5
19delayLine.Position = UDim2.new(0, 0, 0, 0)
20 
21local hitbox = Instance.new("Frame")
22hitbox.Parent = label
23hitbox.AnchorPoint = Vector2.new(0.5, 0.5)
24hitbox.Size = UDim2.new(0.33, 0, 1, 0)
25hitbox.Position = UDim2.new(0.5, 0, 0.5, 0)
26hitbox.BackgroundTransparency = 1
27 
28local hitboxScript = game.ReplicatedStorage.BulletScripts:WaitForChild("LinearHitboxScript"):Clone()
29hitboxScript.Parent = hitbox
30hitboxScript.Disabled = true
31 
32delay(delaytime.Value, function()
33    label:TweenSize(UDim2.new(0, width.Value, 0, length.Value), "Out", "Quad", 0.25, false, function()
34        Debris:AddItem(label, life.Value)
35    end)
36end)
37 
38function getRealAngle(a)
39    local val = math.abs(a - 180)
40 
41    if a > 180 then
42        val = val * -1
43    end
44 
45    return val
46end
47 
48label:GetPropertyChangedSignal("Size"):Connect(function()
49    if label.Size == UDim2.new(0, 1, 0, 1) then
50        delayLine.Visible = true
51        label.ImageTransparency = 1
52        hitboxScript.Disabled = true
53    else
54        delayLine.Visible = false
55        label.ImageTransparency = t.Value
56        hitboxScript.Disabled = false
57    end
58end)
59 
60RunService.RenderStepped:Connect(function()
61    label.Rotation = getRealAngle(angle.Value)
62end)
 View all 62 lines...

When the sprite is created, its size is set to UDim2.new(0, 1, 0, 1). After a certain amount of time passes, the sprite expands to its true size, determined by the values of Length and Width.

However, when the sprite's size changes, it moves towards the bottom of the screen, even though I don't have anything that changes the position in the script. Is there a way to fix it?

Here's the function that creates these sprites, in case it helps with figuring out the problem:

01function lib:CreateStraightLaser(x, y, angle, length, width, delaytime, graphic, timer)
02    local RealLaser = getShotData(graphic)
03    local BoundBox = RealLaser.Bound
04    local sLaserScript = ExtraScriptsDirectory:WaitForChild("StraightLaserScript")
05 
06    local sLaser = Instance.new("ImageLabel")
07    sLaser.Name = RealLaser.Name
08    sLaser.Position = UDim2.new(0, x, 0, y)
09    sLaser.Size = UDim2.new(0, 1, 0, 1)
10    sLaser.AnchorPoint = Vector2.new(0.5, 0)
11    sLaser.BackgroundTransparency = 1
12    sLaser.Image = ShotSheetImage
13    sLaser.ImageRectOffset = BoundBox.Min
14    sLaser.ImageRectSize = Vector2.new(BoundBox.Width, BoundBox.Height)
15    sLaser.ImageTransparency = 1
16 
17    local l = Instance.new("NumberValue")
18    l.Parent = sLaser
19    l.Name = "Length"
20    l.Value = length
21 
22    local a = Instance.new("NumberValue")
23    a.Parent = sLaser
24    a.Name = "Angle"
25    a.Value = angle
26 
27    local w = Instance.new("NumberValue")
28    w.Parent = sLaser
29    w.Name = "Width"
30    w.Value = width
31 
32    local d = Instance.new("NumberValue")
33    d.Parent = sLaser
34    d.Name = "Delay"
35    d.Value = delaytime
36 
37    local life = Instance.new("NumberValue")
38    life.Parent = sLaser
39    life.Name = "Lifetime"
40    life.Value = timer
41 
42    local t = Instance.new("NumberValue")
43    t.Parent = sLaser
44    t.Name = "Transparency"
45    t.Value = RealLaser.Transparency
46 
47    local newLaserScript = sLaserScript:Clone()
48    newLaserScript.Parent = sLaser
49    newLaserScript.Disabled = false
50 
51    sLaser.Parent = getLocalPlayerGui()
52 
53    return sLaser
54end
 View all 54 lines...

use TweenSizeAndPosition to change the item's size and position simultaneosly. It needs to change position to because it, by default, expands the iterm towards the bottom of the screen. Trew86 175 — 6y

1 answer

Answered by

Trew86 175

6 years ago

Edited 6 years ago

When you change the size of a GUI object, it by default expands towards the bottom right corner of the screen. Therefore, you not only have to tween the size, but also the position. To do this, I used TweenSizeAndPosition, with another parameter after the endSize being the endPosition. The endPosition I set to the original position minus half of the width and half of the length to "center" it. Let me know if it works!

01local label = script.Parent
02local RunService = game:GetService("RunService")
03local Debris = game:GetService("Debris")
04local length = label:WaitForChild("Length")
05local width = label:WaitForChild("Width")
06local angle = label:WaitForChild("Angle")
07local delaytime = label:WaitForChild("Delay")
08local life = label:WaitForChild("Lifetime")
09local t = label:WaitForChild("Transparency")
10 
11local delayLine = Instance.new("Frame")
12delayLine.Parent = label
13delayLine.Name = "DelayLine"
14delayLine.Size = UDim2.new(0, 1, length.Value, 0)
15delayLine.AnchorPoint = Vector2.new(0, 0)
16delayLine.BorderSizePixel = 0
17delayLine.BackgroundColor3 = Color3.fromRGB(255, 255, 255)
18delayLine.BackgroundTransparency = 0.5
19delayLine.Position = UDim2.new(0, 0, 0, 0)
20 
21local hitbox = Instance.new("Frame")
22hitbox.Parent = label
23hitbox.AnchorPoint = Vector2.new(0.5, 0.5)
24hitbox.Size = UDim2.new(0.33, 0, 1, 0)
25hitbox.Position = UDim2.new(0.5, 0, 0.5, 0)
26hitbox.BackgroundTransparency = 1
27 
28local hitboxScript = game.ReplicatedStorage.BulletScripts:WaitForChild("LinearHitboxScript"):Clone()
29hitboxScript.Parent = hitbox
30hitboxScript.Disabled = true
31 
32delay(delaytime.Value, function()
33    label:TweenSizeAndPosition(UDim2.new(0, width.Value, 0, length.Value), label.Position-UDim2.new(0, width.Value *0.5, 0, length.Value * 0.5),  "Out", "Quad", 0.25, false, function()
34        Debris:AddItem(label, life.Value)
35    end)
36end)
37 
38function getRealAngle(a)
39    local val = math.abs(a - 180)
40 
41    if a > 180 then
42        val = val * -1
43    end
44 
45    return val
46end
47 
48label:GetPropertyChangedSignal("Size"):Connect(function()
49    if label.Size == UDim2.new(0, 1, 0, 1) then
50        delayLine.Visible = true
51        label.ImageTransparency = 1
52        hitboxScript.Disabled = true
53    else
54        delayLine.Visible = false
55        label.ImageTransparency = t.Value
56        hitboxScript.Disabled = false
57    end
58end)
59 
60RunService.RenderStepped:Connect(function()
61    label.Rotation = getRealAngle(angle.Value)
62end)
 View all 62 lines...

That prevents it from moving to the bottom of the screen, but now the sprite moves backwards when it resizes, when it's supposed to stay in one place. BrockRocksYourSocks 48 — 6y

I tried doing this with a GUI object in Studio and I noticed that my solution works with Scale but not with Offset. Offset is a bit more finnicky so if you want to stick with offset, you'll have to do a lot of tests to figure out what the right endPosition is. Trew86 175 — 6y

Sprites are moving when they shouldn't?

1 answer

Answer this question