health display script doesn't work, no errors in console?
here is the script:
1 | local humanoid = script.Parent.Humanoid |
2 | local health = humanoid.Health |
3 | local maxHealth = humanoid.MaxHealth |
4 |
5 | script.Parent.Name = health.."/"..maxHealth |
6 |
7 | script.Parent.Humanoid.HealthChanged:Connect(function() |
8 | script.Parent.Name = health.."/"..maxHealth |
9 | end) |
im trying to make the name of the model say how much health it has left in this format:
health / maxhealth
it does not update and shows no errors in the console
0
0
0
2 answers
The problem here is the fact that you wrongly assume that the health variable is a reference to the property of the Humanoid. When the property changes, your health variable will not update. HealthChanged passes the new health as a parameter, so use that instead.
1 | local humanoid = script.Parent.Humanoid |
2 |
3 | script.Parent.Name = humanoid.Health.."/"..humanoid.MaxHealth |
4 |
5 | script.Parent.Humanoid.HealthChanged:Connect(function(health) |
6 | script.Parent.Name = health.."/"..humanoid.MaxHealth |
7 | end) |
Reference vs Value
It is important that you know the difference between a reference and a value.
Reference
In Lua, for example, tables are passed by reference.
01 | local tbl1 = {"hello", "world", "foo", "bar"} |
02 | local tbl2 = {"hello", "world", "foo", "bar"} |
03 | local tbl1reference = tbl1 |
04 | table.insert(tbl1, "test") |
05 |
06 | for _, v in ipairs({tbl1, tbl2, tbl1reference}) do |
07 | print(table.concat(v, ", ")) |
08 | end |
09 |
10 | --[[ |
11 | output: |
12 | hello, world, foo, bar, test |
13 | hello, world, foo, bar |
14 | hello, world, foo, bar, test |
15 |
16 | --]] |
tbl1 and tbl1reference hold the same exact table in memory and tbl2 does not, even if it has the same values in the same positions. Changes made to tbl1 or tbl1reference will affect tbl1 and tbl1reference.
Value
However things like booleans and numbers are passed simply via value.
01 | local _string = "hello" |
02 | local _string_value = _string |
03 | _string = "world" |
04 | print(_string_value) |
05 |
06 | local bool1 = false |
07 | local bool1_val = bool1 |
08 | bool1 = true |
09 | print(bool1) --> true |
10 | print(bool1_val) --> false |
Even though _string_value was set to _string, both variables have different memory and modifying one value does not change the other.
0
Well, the problem here seems to be that the health variable isn't changed when the health of the humanoid changes, which means the script is still using the original health of the humanoid rather than the current health of the humanoid.
Luckily the health changed event has a handy argument, the new health , which can be used for this purpose
1 | local humanoid = script.Parent.Humanoid |
2 | local health = humanoid.Health |
3 | local maxHealth = humanoid.MaxHealth |
4 |
5 | script.Parent.Name = health.."/"..maxHealth |
6 |
7 | script.Parent.Humanoid.HealthChanged:Connect(function(newHealth) |
8 | script.Parent.Name = newHealth.."/"..maxHealth |
9 | end) |
Addition: if you plan on also changing the max health of the player, you would also have to use an updated version of the maxHealth variable
1 | local humanoid = script.Parent.Humanoid |
2 | local health = humanoid.Health |
3 | local maxHealth = humanoid.MaxHealth |
4 |
5 | script.Parent.Name = health.."/"..maxHealth |
6 |
7 | script.Parent.Humanoid.HealthChanged:Connect(function(newHealth) |
8 | script.Parent.Name = newHealth.."/"..humanoid.MaxHealth |
9 | end) |
0