Scripting Helpers is winding down operations and is now read-only. More info→

Death wall that kills you is to laggy? Help.

Asked by

6 years ago

So I got a game where there is an arena and people fight in it. Then I got an Event which triggers that 4 walls spawn and they shrink so all players are forced to move in the middle of the arena. Everything works fine etc BUT If I want to add a deathscript to the walls so they acutally kill you if you touch it, the performance will completly go down. I think its because it is checking everything it touches something to see if it is a hum or not.

Any Idea how to handle this performance wise and only kill the player?

1function KillPlayer(part)
2    h = part.Parent:findFirstChild("Humanoid")
3    if h ~= nil then
4        h.Health = 0
5    end
6end
7 
8script.Parent.Touched:connect(KillPlayer)

u might wanna try h:TakeDamage(100) TheluaBanana 946 — 6y

or use breakjoints theking48989987 2147 — 6y

or h:TakeDamage(h.MaxHealth) EliteRayGawnX2 124 — 6y

Weird. It shouldn't cause a peformance drop Amiaa16 3227 — 6y

View all comments (7 more)

unless there is some other factor at play here theking48989987 2147 — 6y

:TakeDamage() doesn't damage the player if they have a force field tho User#23365 30 — 6y

just use debounce Metraria 17 — 6y

Maybe try adding a wait() ? That always helps me with lag TheGreenSuperman 85 — 6y

Breakjoints didnt work, tried it too. Paintertable 171 — 6y

Breakjoints didnt work, i tried it too. so weird. Paintertable 171 — 6y

You guys need to read my text on top. Im moving the walls btw, so im using TweenService maybe that. Paintertable 171 — 6y

2 answers

Answered by

chess123mate 5873

6 years ago

I can imagine this lagging if:

You have this script copied in tens or hundreds of parts
The wall parts are very large

You say these parts are moving using TweenService. If the walls are also large, I'm not surprised it's lagging! You are likely asking Roblox to essentially scan a huge area and report to you every part that it can find every frame (since TweenService runs constantly).

To fix this, you need a different approach - every frame, use math to check whether a player is "in bounds" or else in contact with the death wall. If they're out of bounds (but still in the map area -- ex, not in a lobby), then set their health to 0.

alright! Thats a nice answer. Thats probably it because the Walls are pretty huge due to the arena size. Thanks and I'LL use another code for it :)) Is it better to move it with CFrame then? Paintertable 171 — 6y

Switching to CFrame won't solve the problem (and Tweening is a good choice anyway) - you need to have a loop that checks to see if anyone is colliding with a wall every frame (ex a "while true do wait() --[[check players here]] end" loop). chess123mate 5873 — 6y

Answered by

firestarroblox123 440

6 years ago

Edited 6 years ago

You probably need to use a debounce.

If you don't know what a debounce is here's a basic explanation:

01local debounce = true
02 
03function touched()
04    if debounce == true then
05        debounce = false
06        print("I have been touched!")
07        wait() -- How many seconds until it can be touched again
08        debounce = true
09    end
10end
11 
12script.Parent.Touched:connect(touched)

So if you wanted to apply this to your script then you would write something like this:

01local debounce = true
02 
03function KillPlayer(part)
04    if debounce == true then
05        debounce = false
06        h = part.Parent:findFirstChild("Humanoid")
07        if h ~= nil then
08            h.Health = 0
09        end
10        wait()
11        debounce = true
12    end
13end
14 
15script.Parent.Touched:connect(KillPlayer)

I hoped this helped you!

This might work. I'll try it later out, Thanks! Paintertable 171 — 6y

It didnt.. That is so weird. Im using TweenService to move the walls btw. Paintertable 171 — 6y

Maybe give me a example of moving the Object etc plus killing players? Paintertable 171 — 6y

Debounce won't help much - the original script doesn't have any yielding commands (so it's not needed for correctness); all it does is skip some of the Touch events. chess123mate 5873 — 6y

Ah I see. firestarroblox123 440 — 6y

Death wall that kills you is to laggy? Help.

2 answers

Answer this question