Scripting Helpers is winding down operations and is now read-only. More info→

How do I create a sequenced ordered data store leaderboard?

Asked by

Tweakified 117

6 years ago

Edited 6 years ago

Hello,

Recently, I have created a leaderboard script in ServerScriptService for my game. It controls creating a stage, cash and wins leaderboard, which works great using DataStore2 :)

I have had a couple of issues on a part of this leaderboard, the ordered data store part.

Firstly, it does not order the wins in a high to low order. It has sequenced the players in a 'last updated' order.

For example:

What my leaderboard is showing:

https://cdn.discordapp.com/attachments/356675974928007168/518192064706379787/unknown.png

What I'm trying to get it to show:

https://cdn.discordapp.com/attachments/356675974928007168/518192333758398535/example.png

Secondly, I am having issues where the leaderboard doesn't appear at all. But then other times it appears. I think it is because ROBLOX has troubles with data stores ATM. That's why I switched to DataStore2 on standard data stores. If that is the answer to the problem, how do I use my ordered data store on the DataStore2 system?

This is an example on the leaderboard not appearing:

https://cdn.discordapp.com/attachments/356675974928007168/518193965791576092/unknown.png

This is the DataStore2 module and system:

Module: https://www.roblox.com/library/1936396537/DataStore2-Data-Loss-Prevention-and-Caching

Description: https://devforum.roblox.com/t/how-to-use-datastore2-data-store-caching-and-data-loss-prevention/136317

This is my current code for the leaderboard script in ServerScriptStorage:

The parts of the code that is relevant to the ordered data store leaderboard are lines 1-52.

001local DataStore2 = require(game.ServerScriptService:WaitForChild("MainModule"))
002local ODS = game:GetService("DataStoreService"):GetOrderedDataStore("WinsFixed")
003local Pages = ODS:GetSortedAsync(false,10)
004local Data = Pages:GetCurrentPage()
005local GUI1=game.StarterGui.LeaderboardUI
006local GUI2=game.StarterGui.LeaderboardUI1
007 
008local function Update()
009    local succ,err = pcall(function()
010        local Template = GUI1.Template
011            for i,v in pairs(GUI1.MainFrame:GetChildren()) do
012                if v:IsA("Frame") then
013                    v:Destroy()
014                end
015            end
016        local Template2 = GUI2.Template
017            for i,v in pairs(GUI2.MainFrame:GetChildren()) do
018                if v:IsA("Frame") then
019                    v:Destroy()
020                end
021            end
022        for a,k in pairs(Data) do
023            local PlayerName = k.key
024            local PlayerPoints = k.value
025            local NewTemp = Template:Clone()
026            NewTemp.Name = PlayerName
027            NewTemp.FrameName.Text = PlayerName
028            NewTemp.FrameValue.Text = PlayerPoints
029            NewTemp.Visible = true
030            NewTemp.Parent = GUI1.MainFrame
031            NewTemp:Clone().Parent = GUI2.MainFrame
032        end
033    end)
034    if err then
035        warn("An error has occurred when trying to update leaderboard: " .. err)
036        Update()
037    end
038end
039 
040game.Workspace.ChildAdded:Connect(function(object)
041    local player = game.Players:GetPlayerFromCharacter(object)
042    if player ~= nil then
043        local ls = player:WaitForChild("leaderstats")
044        local sl = game.Workspace:FindFirstChild(ls.Stage.Value)
045        object.UpperTorso.CFrame = object.UpperTorso.CFrame + Vector3.new(0,3,0)
046        wait()
047        object.UpperTorso.CFrame = sl.CFrame + Vector3.new(0,3,0)
048        while wait(60*3) do
049            Update()
050        end
051    end
052end)
053 
054game.Players.PlayerAdded:Connect(function(player)
055 
056    local cashDataStore = DataStore2("cash",player)
057    local deathsDataStore = DataStore2("deaths",player)
058    local standardDataStore = DataStore2("standard",player)
059    local perfectDataStore = DataStore2("perfect",player)
060    local speedDataStore = DataStore2("speed",player)
061 
062    local leaderstats = Instance.new("Folder",player)
063    leaderstats.Name = "leaderstats"
064 
065    local winstats = Instance.new("Folder",player)
066    winstats.Name = "winstats"
067 
068    local stage = Instance.new("IntValue",leaderstats)
069    stage.Name = "Stage"
070    stage.Value = 1
071 
072    local cash = Instance.new("IntValue",leaderstats)
073    cash.Name = "Cash"
074 
075    local deaths = Instance.new("IntValue",winstats)
076    deaths.Name = "Deaths"
077 
078    local BestPerfect = Instance.new("IntValue",winstats)
079    BestPerfect.Name = "BestPerfect"
080 
081    local BestStandard = Instance.new("IntValue",winstats)
082    BestStandard.Name = "BestStandard"
083 
084    local BestSpeed = Instance.new("IntValue",winstats)
085    BestSpeed.Name = "BestSpeed"
086 
087    local specialmode = Instance.new("BoolValue",winstats)
088    specialmode.Name = "Special"
089 
090    local mode = Instance.new("StringValue",leaderstats)
091    mode.Name = "Mode"
092    mode.Value = "Standard"
093 
094    local perfectmode = Instance.new("BoolValue",winstats)
095    perfectmode.Name = "Perfect"
096 
097    local speedmode = Instance.new("BoolValue",winstats)
098    speedmode.Name = "Speed"
099 
100    local Wins = Instance.new("NumberValue",winstats)
101    Wins.Name = "Wins"
102 
103    local function cashUpdate(updatedValue)
104        cash.Value = cashDataStore:Get(updatedValue)
105    end
106 
107    local function deathsUpdate(updatedValue)
108        deaths.Value = deathsDataStore:Get(updatedValue)
109    end
110 
111    local function BestStandardUpdate(updatedValue)
112        BestStandard.Value = standardDataStore:Get(updatedValue)
113    end
114 
115    local function BestPerfectUpdate(updatedValue)
116        BestPerfect.Value = perfectDataStore:Get(updatedValue)
117    end
118 
119    local function BestSpeedUpdate(updatedValue)
120        BestSpeed.Value = speedDataStore:Get(updatedValue)
121    end
122 
123    cashUpdate(0)
124    cashDataStore:OnUpdate(cashUpdate)
125 
126    deathsUpdate(0)
127    deathsDataStore:OnUpdate(deathsUpdate)
128 
129    BestStandardUpdate(0)
130    standardDataStore:OnUpdate(BestStandardUpdate)
131 
132    BestPerfectUpdate(0)
133    perfectDataStore:OnUpdate(BestPerfectUpdate)
134 
135    BestSpeedUpdate(0)
136    speedDataStore:OnUpdate(BestSpeedUpdate)
137 
138    player.CharacterAdded:Connect(function(Character)
139        local d = true
140        Character:WaitForChild("Humanoid").Died:Connect(function()
141            if (d) then
142                d = false
143                local deathsDataStore = DataStore2("deaths",player)
144                deathsDataStore:Increment(1, 0)
145            end
146        end)
147    end)
148 
149    while true do
150        wait()
151        if (player.winstats.BestPerfect.Value == 11) and (player.leaderstats.Stage.Value > player.winstats.BestSpeed.Value) then
152            if player.winstats.Perfect.Value ~= true then
153                local speedDataStore = DataStore2("speed",player)
154                speedDataStore:Set(player.leaderstats.Stage.Value)
155            end
156 
157        elseif (player.winstats.BestStandard.Value == 11) and (player.leaderstats.Stage.Value > player.winstats.BestPerfect.Value) then
158            local perfectDataStore = DataStore2("perfect",player)
159            perfectDataStore:Set(player.leaderstats.Stage.Value)
160 
161        elseif player.leaderstats.Stage.Value > player.winstats.BestStandard.Value then
162            local standardDataStore = DataStore2("standard",player)
163            standardDataStore:Set(player.leaderstats.Stage.Value)
164 
165        end
166 
167        wait(40)
168        local cashDataStore = DataStore2("cash",player)
169        cashDataStore:Increment(1, 0)
170    end
171end)
172 
173game.Players.PlayerRemoving:Connect(function(plr)
174    local Wins = plr.winstats.Wins
175    if Wins then
176        ODS:IncrementAsync(plr.Name, Wins.Value)
177    end
178end)
 View all 178 lines...

Any advice you can give will be appricated.

1 answer

Answered by

Tweakified 117

6 years ago

Edited 6 years ago

Hello,

I have asked a couple of roblox scripting pros about this. They said this: First of all, they don't think ordered data stores are compatible with DataStore2.

Secondly, the reason why the leaderboard doesn't appear all the time is that the script is needed to include a new pcall function. As shown in the script.

Thirdly, the reason why the leaderboard isn't displaying in the correct order is that the UiListLayout of the actual UI has been setup incorrectly. These are the correct settings for my leaderboard:

https://cdn.discordapp.com/attachments/356675974928007168/524317164220579843/unknown.png

Another reason why the leaderboard didn't display in the correct order, is that I needed to include a new line of code which ordered the leaderboard, as it updated. Here is the corrected version of the code:

01local DataStore2 = require(game.ServerScriptService:WaitForChild("MainModule"))
02local ODS = game:GetService("DataStoreService"):GetOrderedDataStore("WinsFixed")
03local GUI1=game.StarterGui.LeaderboardUI
04local GUI2=game.StarterGui.LeaderboardUI1
05 
06local function load()
07    local succ,err = pcall(function()            --New pcall function
08        warn("Successfully loaded the leaderboard")
09        local Pages = ODS:GetSortedAsync(true,10)
10        local Data = Pages:GetCurrentPage()
11        local Template = GUI1.Template
12 
13        for i,v in pairs(GUI1.MainFrame:GetChildren()) do
14            if v:IsA("Frame") then
15                v:Destroy()
16            end
17        end
18        local Template2 = GUI2.Template
19        for i,v in pairs(GUI2.MainFrame:GetChildren()) do
20            if v:IsA("Frame") then
21                v:Destroy()
22            end
23        end
24        local succ2,err2 = pcall(function()
25            for a,k in pairs(Data) do
26                local PlayerName = k.key
27                local PlayerPoints = k.value
28                local NewTemp = Template:Clone()
29                NewTemp.Name = PlayerName
30                NewTemp.LayoutOrder = 10-a    --New line
31                NewTemp.FrameName.Text = PlayerName
32                NewTemp.FrameValue.Text = PlayerPoints
33                NewTemp.Visible = true
34                NewTemp.Parent = GUI1.MainFrame
35                NewTemp:Clone().Parent = GUI2.MainFrame
36            end
37        end)
38        if err2 then
39            warn("No data to process")
40            return
41        end
42    end)
43    if err then
44        warn("Failed to load the leaderboard")
45        load()
46    end
47end
 View all 47 lines...

I have got rid of the 'Update' function and joined the two functions together for simplicity. Hope this helps.

Thanks for replying to yourself, I am now finding this useful. TomsGames 225 — 5y

How do I create a sequenced ordered data store leaderboard?

1 answer

Answer this question