Scripting Helpers is winding down operations and is now read-only. More info→

Why does this data saving script not work at all?

Asked by

6 years ago

This script is supposed to create and save a subset of player stats that is supposed to be saved and loaded upon the player joining and leaving respectively.

When I increase/change one of the data points and leave and rejoin, the data does not load. This script is currently being tested on a private game, if that matters at all.

What is the issue with it? Output gave me nothing to work with.

01local DataStores = game:GetService("DataStoreService")
02local PlayersDataStore = DataStores:GetDataStore("Players")
03local FindValues = {
04"Rank","XP","Prestige","Heists";
05--Add any new variable!
06}
07local TypeValues = {
08    Rank = "IntValue"; --Or int whatever is fine...
09    XP = "IntValue";
10    Prestige = "IntValue";
11    Heists = "IntValue";
12}
13 
14function SetupPlayer(Player)
15local LeaderStats = Instance.new("Folder",Player)
16LeaderStats.Name = "perm"
17local ValueObjects = {}
18for i,v in pairs(FindValues)do
19    local VALUE = Instance.new(TypeValues[v] or "StringValue",LeaderStats)
20    VALUE.Name = v
21    ValueObjects[i] = VALUE
22end
23 
24local LeaderTable = {}
25local PlayerDS = PlayersDataStore:GetAsync(Player.UserId)
26 
27if not PlayerDS then --For new players!
28    local SetTable = {}
29    for i,v in pairs(ValueObjects)do
30        SetTable[FindValues[i]] = v.Value
31    end
32    PlayersDataStore:SetAsync(Player.UserId,SetTable)
33    PlayerDS = PlayersDataStore:GetAsync(Player.UserId)
34end
35 
36for i,v in pairs(ValueObjects)do
37    v.Value = LeaderTable[FindValues[i]]
38end
39 
40PlayersDataStore:SetAsync(Player.UserId,PlayerDS)
41 
42spawn(function()
43    while wait(10)do --Autosave
44        for i,v in pairs(ValueObjects)do
45        PlayerDS[FindValues[i]] = v.Value
46    end
47    PlayersDataStore:SetAsync(Player.UserId,PlayerDS)
48    end
49    end)
50end
51 
52game.Players.PlayerAdded:connect(SetupPlayer)
 View all 52 lines...

1 answer

Answered by

awesomeipod 607

6 years ago

Edited 6 years ago

There are a few issues with your script:

1) It is difficult to read, create separate functions for each task so it can be more organized (save and load data function).

2) The tables are unnecessary and it was hard to understand it. I suggest to create a variable for each value. It'll be more organized and efficient.

3) 'connect' is deprecated, use 'Connect' instead.

4) DO NOT set the parent in the Instance.new parameters. It's a faster way but it was proved that it can slow down the script.

01local Players = game:GetService("Players")
02local DataStores = game:GetService("DataStoreService")
03local PlayersDataStore = DataStores:GetDataStore("Players")
04 
05local function SavePlayerData(Player)
06    if Player then
07        local Leaderstats = Player:FindFirstChild("perm")
08        if Leaderstats then
09            local XPValue, RankValue, HeistsValue, PrestigeValue
10            XPValue = Leaderstats:FindFirstChild("XP")
11            RankValue = Leaderstats:FindFirstChild("Rank")
12            HeistsValue = Leaderstats:FindFirstChild("Heists")
13            PrestigeValue = Leaderstats:FindFirstChild("Prestige")
14            if XPValue and RankValue and HeistsValue and PrestigeValue then
15                local PlayerDS = PlayersDataStore:GetAsync(Player.UserId)
16                if PlayerDS then
17                    local SavingTable = {
18                        ["XP"] = XPValue.Value,
19                        ["Rank"] = RankValue.Value,
20                        ["Heists"] = HeistsValue.Value,
21                        ["Prestige"] = PrestigeValue.Value
22                    }
23                    print("saved " .. Player.Name .. "'s leaderstats")
24                    PlayerDataStore:SetAsync(Player.UserId, SavingTable)
25                end
26            end
27        end
28    end
29end
30 
31local function LoadPlayerData(Player, XPValue, RankValue, HeistsValue, PrestigeValue)
32    if Player then
33        local PlayerDS = PlayersDataStore:GetAsync(Player.UserId) -- this will return the 'SavingTable'
34        if PlayerDS then
35            XPValue.Value = PlayerDS.XP
36            RankValue.Value = PlayerDS.Rank
37            HeistsValue.Value = PlayerDS.Heists
38            PrestigeValue.Value = PlayerDS.Prestige
39            print("loaded " .. Player.Name .. "'s leaderstats")
40        else
41            print("new player")
42            PlayerDataStore:SetAsync(Player.UserId, nil)
43        end
44    end
45end
46 
47local function SetupPlayer(Player)
48    --create leaderstats folder
49    local Leaderstats = Instance.new("Folder")
50    Leaderstats.Name = "perm"
51    Leaderstats.Parent = Player
52 
53    --create value function
54    local function createNewValue(valueName)
55        local newValue = Instance.new("IntValue")
56        newValue.Name = valueName
57        newValue.Parent = Leaderstats
58        return newValue
59    end
60 
61    --create values
62    local XPValue, RankValue, HeistsValue, PrestigeValue
63 
64    XPValue = createNewValue("XP")
65    RankValue = createNewValue("Rank")
66    HeistsValue = createNewValue("Heists")
67    PrestigeValue = createNewValue("Prestige")
68 
69    --load data
70    LoadPlayerData(Player, XPValue, RankValue, HeistsValue, PrestigeValue)
71 
72    --autosaving
73    spawn(function()
74        while Player do
75            wait(10)
76            if Player then
77                SavePlayerData(Player)
78            end
79        end
80    end)
81end
82 
83Players.PlayerAdded:Connect(SetupPlayer)
 View all 83 lines...

Don't forget to add a PlayerRemoving event so you can save players data when they leave the game. awesomeipod 607 — 6y

Make sure studio access to API services is enabled as well awesomeipod 607 — 6y

PlayerDataStore:SetAsync(Player.UserId, SavingTable) is undefined in the script? CoolJohnnyboy 121 — 6y

They're in lines 24 42 awesomeipod 607 — 6y

View all comments (2 more)

Instead of SetAsync to update a player's data who already has data and isn't new, shouldn't you use UpdateAsync? User#22980 0 — 6y

Yes but they both have the same function awesomeipod 607 — 6y

Why does this data saving script not work at all?

1 answer

Answer this question