Scripting Helpers is winding down operations and is now read-only. More info→

While true do function only works once, why?

Asked by

captain_bboy 22

5 years ago

Edited 5 years ago

Hello, I'm making a self-check-in system for a hotel game and I needed to store if the room is taken or not. For this, I made a Folder with BoolValues. For some reason, the script runs at the start but does not keep testing for the BoolValue. It goes off the starting value and not the updated one, but my print keeps printing.

Here are the scrips:

(0 = not taken | 1 = taken)

while true do
    if script.Parent.Value == 1 then
        game.ReplicatedStorage.RoomTaken["Room 101"].Value = true
    elseif script.Parent.Value == 0 then
        game.ReplicatedStorage.RoomTaken["Room 101"].Value = false
wait(0.5)
    end
end

while true do
    if game.ReplicatedStorage.RoomTaken["Room 101"].Value == false then
        script.Parent.BrickColor = BrickColor.new("Medium green")
        print("Green")
    elseif game.ReplicatedStorage.RoomTaken["Room 101"].Value == true then
        script.Parent.BrickColor = BrickColor.new("Bright red")
        print("Red")
wait(1)
end
end

Put in CodeBox yHasteeD 1819 — 5y

Done. captain_bboy 22 — 5y

MMmmh while true do. While TRUE do. Why are we using this? Why not watch for the value changing then call our action. DinozCreates 1070 — 5y

Could you give me an example? captain_bboy 22 — 5y

View all comments (2 more)

1.) while true do is not a function. 2.) It is never a good idea to create an infinite loop with no ending condition. 3.) If there is an event that can take the place of a loop, use it (in your case that would be the Changed event). 4.) Your first if statement in both scenarios has no yield inside of it. That means if your Value does not change fast enough from 1/false, your game will crash. User#25115 0 — 5y

Finally, your main issue is likely that your Value is not 1.) being correctly changed, or 2.) being correctly accessed. User#25115 0 — 5y

1 answer

Answered by

DinozCreates 1070

5 years ago

Edited 5 years ago

Example, see if this works better

 script.Parent.Changed:Connect(function()
    if script.Parent.Value == 1 then
        game.ReplicatedStorage.RoomTaken["Room 101"].Value = true
    print("True")
    elseif script.Parent.Value == 0 then
        game.ReplicatedStorage.RoomTaken["Room 101"].Value = false
    print("False")
    wait(0.5)
        end
    end)

 game.ReplicatedStorage.RoomTaken["Room 101"].Changed:Connect(function()
    if game.ReplicatedStorage.RoomTaken["Room 101"].Value == false then
        script.Parent.BrickColor = BrickColor.new("Medium green")
        print("Green")
    elseif game.ReplicatedStorage.RoomTaken["Room 101"].Value == true then
        script.Parent.BrickColor = BrickColor.new("Bright red")
        print("Red")
wait(1)
    end
end)

use script.Parent:GetPropertyChangedSignal("Value"):Connect(function() User#23365 30 — 5y

I editted it Expo, but what exactly does this do differently? I know that this SHOULD work as is, but is this more efficient? DinozCreates 1070 — 5y

It isn't working. captain_bboy 22 — 5y

Did you try it the original way or how it is now DinozCreates 1070 — 5y

View all comments (4 more)

Both. captain_bboy 22 — 5y

Are the values changing? Add prints and see if the script is doing its job. Or just watch the values. DinozCreates 1070 — 5y

I editted the thing DinozCreates 1070 — 5y

:GetPropertyChangedSignal() only listens for a certain property, Changed listens for every property (not really) User#23365 30 — 5y

While true do function only works once, why?

1 answer

Answer this question