Scripting Helpers is winding down operations and is now read-only. More info→

How could i remove a player from a Table when he died or disconnected?

Asked by

Paintertable 171

6 years ago

Edited 6 years ago

So this is kinda complicated to explain but im just gonna give you my whole Script so you might be able to understand what i did here. So i got a District System going like the Hunger games and i know how to check, how many Players are alive. But my major problem is to make a "Death/Leave" Script so it updates the Table when a player dies or disconnects. The Problem here is that If i want to check how many Players are alive i use

1if #Players == 0 then
2            print("Everybody died")
3            break
4        end

which is the only way i believe in this code. If i want to use _G.Districts it wont work. #Players gives me an Number of how many are in the table i believe.

So Is there a better way to write this script? Is there even a way to get my Death/Leave script working? Im so confused by now and my head hurts.

Here is my Whole Script + my attempt to write a Death and Leave Script. Basicly what i wanna know is how to make a death and leave script and make it comportable with mine. Thanks alot if you're still reading <3

DEATH AND LEAVE SCRIPT

01game:GetService("Players").PlayerAdded:Connect(function(player)
02    player.CharacterAdded:Connect(function(character)
03        character:WaitForChild("Humanoid").Died:Connect(function()
04        local Update = {}
05        for i, v in pairs(_G.Districts) do
06            if v ~= player.Name then
07               table.insert(Update,1,v)
08            end
09        end
10    _G.Districts = Update
11        end)
12    end)
13end)
14 
15game:GetService("Players").PlayerRemoving:Connect(function(player)
16 
17    local Update = {}
18    for i, v in pairs(_G.Districts) do
19        if v ~= player.Name then
20            table.insert(Update,1,v)
21        end
22 
23    end
24    _G.Districts = Update
25end)
 View all 25 lines...

MAIN SCRIPT

01--//Services
02local Players = game:GetService("Players")
03local ReplicatedStorage = game:GetService("ReplicatedStorage")
04 
05--//Remotes
06local Remotes = ReplicatedStorage:WaitForChild("Remotes")
07    local Names = Remotes:WaitForChild("Names")
08    local Round = Remotes:WaitForChild("Round")
09 
10--//Variables 
11local Tributspawn = workspace:WaitForChild("Tribut")
12 
13--//Functions
14    function Shuffle(Table)
15    local Size = (#Table)
16    for i = Size, 1, -1 do
17        local RandomObject = Random.new():NextInteger(1, Size)
18        Table[i], Table[RandomObject] = Table[RandomObject], Table[i]
19        end
20    return Table
21end
22 
23--//Main
24while true do
25    wait(3)
26    _G.Districts = {}
27local Players = (Shuffle(game:GetService("Players"):GetPlayers()))
28 
29for i = (1),(math.ceil(#Players/2)) do
30    _G.Districts[#_G.Districts + 1] = {}
31end
32 
33for Player = (1),(#Players) do
34    local DesiredDistrict = (math.ceil(Player/2))
35    table.insert(_G.Districts[DesiredDistrict], Players[Player])
36Names:FireAllClients(DesiredDistrict,Players[Player])
37wait(2)
38end
39    print("Round starts")
40        for t = 10,0,-1 do
41        wait(1)
42            print(t)
43            if #Players == 0 then
44            print("Everybody died")
45            break
46        end
47    end
48end
 View all 48 lines...

1 answer

Answered by

User#5423 17

6 years ago

Edited 6 years ago

You should avoid using _G as any scripts are able to read / make changes to this. Instead I would use a module script to manage this task.

There are a lot of ways this can be done but for this example I will show a self contained process which will return a round object. The idea behind this is so you would then be able to expand the functionality of what a round is.

01-- module script code
02local f = {}
03local plrServ = game:GetService("Players")
04 
05-- vars
06local curRound = nil
07 
08-- returns the cur round object or nil
09function f:GetCurRound()
10    return curRound
11end
12 
13-- roundTime, the time for this round
14function f:NewRound(roundTime)
15    -- example validation for rounds
16    if curRound then error("round is active cannot make a new round") end
17 
18    local round = {} -- our new round object
19    local conObj = {} -- active event connections
20    local endTime = tick() + roundTime -- cal total time of round
21    local totalPlayers = 0 -- player count for round
22    local plrList = {}
23 
24    -- to avoid duplication of code
25    local function rmPlayerFromList(plr)
26        if plrList[plr] then -- if plauer is in the list
27            plrList[plr] = nil -- remove player
28            totalPlayers = totalPlayers - 1 -- dec player count
29        end
30    end
31 
32    for _, plr in pairs(plrServ:GetPlayers()) do
33        if plr.Character then -- check for a players model ?
34            local hum = plr.Character:FindFirstChild("Humanoid")
35 
36            -- check humanoid is not dead
37            if hum and hum:GetState() ~= Enum.HumanoidStateType.Dead then
38 
39                -- add this valid player to the list
40                conObj[#conObj+1] = hum.Died:Connect(function()
41                    rmPlayerFromList(plr)
42                    print(plr.Name, " died")
43                end)
44 
45                totalPlayers = totalPlayers + 1 -- inc player count
46                plrList[plr] = true -- the value is just a place holdder
47            end
48        end
49    end
50 
51    -- add the player removing 
52    conObj[#conObj+1] = plrServ.PlayerRemoving:Connect(function(plr)
53        rmPlayerFromList(plr)
54        print(plr.Name, " left")
55    end)
56 
57    -- returns the player count for the round
58    function round:GetPlayerCount()
59        return totalPlayers 
60    end
61 
62    -- returns true if the round is still active
63    function round:IsActive()
64        return tick() < endTime 
65    end
66 
67    -- ends the round and curRound variable
68    function round:End()
69        for _, con in pairs(conObj) do
70            con:Disconnect()
71        end
72 
73        -- cleanup
74        conObj = nil
75        totalPlayers = 0
76        plrList = nil
77        curRound = nil
78    end
79 
80    -- returns an array of players in theround
81    function round:GetPlayers()
82        local lst = {}
83        for _, plr in pairs(plrList) do
84            lst[#lst+1] = plr
85        end
86        return
87    end
88 
89    -- set this as the active round
90    curRound = round
91    return round -- return round object
92end
93 
94return f -- return our table of functions 
 View all 94 lines...

Example script

01local round = require(script.Parent.ModuleScript)
02 
03while true do
04    local newRound = round:NewRound(10)
05 
06    while newRound:IsActive() do
07        print(newRound:GetPlayerCount(), "Players in round")
08        wait(1)
09    end
10 
11    print("round end")
12    newRound:End()
13end

I know this is a lot to work with at first but the round object returned is safe to use in other scripts. Please comment if there are parts of this code you do not understand and I will add additional info below.

Usefull links

OOP in Lua

OOP in Lua dev forum

RBXScriptConnection

Hope this helps.

I see you did a lot of work there, sadly my knowledge is not good enough for this kind of code. I never invented time into ModuleScripts etc also sadly i dont know how to make it comportable with mine. Still you did a great job, i tested it in a new game and it works well :) Paintertable 171 — 6y

You can do a lot of things with modules. A module script will only run once upon using the function require. It helps lead to better code design by reusing code and making for better code strucures ie one thing does one task. User#5423 17 — 6y

How could i remove a player from a Table when he died or disconnected?

1 answer

Usefull links

Answer this question