Red light running fine script doesn't subtract $300 from the player's $$$ leaderstat?
So, in my game, if you run a red light, you get a $300 fine. What triggers this is a person passing through a detector while the light it is below is red. At least, that's what supposed to happen. It is not happening. Why??? No output errors or anything, it just doesn't work. The script is a LocalScript that is inside of the detector.
1 | local Part = script.Parent |
2 | Part.Touched:Connect(function(hit) |
3 | if hit.Parent:FindFirstChild("Humanoid") and script.Parent.Parent.TrafficLight1.TSM.Red.PointLight.Brightness == 8 then |
4 | game.Players.LocalPlayer.leaderstats.Money.Value = game.Players.LocalPlayer.leaderstats.Money.Value - 300 |
5 | end |
6 | end) |
0
0
0
0
1 answer
Local Scripts
The point of local scripts is to make edits to something only a client can see. UI or local parts can only be seen by a single client, so those are edited via local scripts. If you're making changes to the game, you need to use a server sided (or normal)
How to Get Player with a Server Script
Use GetPlayerFromCharacter. The argument is the player's character and it will return the character.
1 | local Players = game:GetService("Players") |
2 |
3 | local player = Players:GetPlayerFromCharacter(Character) --"Character" will be the model |
4 | if player then --If the player is real then... |
5 | print(player.Name.." is a player.") |
6 | else --If the player is not real then... |
7 | print("Not a player...") |
8 | end |
Implementing with a Touched event
Here's how your code would look like if you combined it with GetPlayerFromCharacter.
1 | local Part = script.Parent |
2 | Part.Touched:Connect(function(hit) |
3 | local player = game:GetService("Players"):GetPlayerFromCharacter(hit.Parent) |
4 | if player and script.Parent.Parent.TrafficLight1.TSM.Red.PointLight.Brightness == 8 then |
5 | player.leaderstats.Money.Value = player.leaderstats.Money.Value - 300 |
6 | end |
7 | end) |
Debouncing
If you were to use the code as is, you'd notice that you are losing a lot more cash than just 300. The reason is because this code is being run once for every single body part and cosmetic the player is wearing. Meaning, if a player is wearing 3 hats, he could lose up to $2,700 at once! If you put a debounce, it will prevent the code from running again until a certain condition is met. In this example, the condition is time:
01 | --Button can only be pressed once every 5 seconds |
02 | local debounce = false --can be named anything; variable doesn't have to be a bool, it's just easier that way |
03 |
04 | script.Parent.Touched:Connect(function() |
05 | if not debounce then --If debounce is false then... |
06 | debounce = true --Make it true, so this script wont run again! |
07 | print("Activated") |
08 | wait(5) --After 5 seconds, make debounce false again |
09 | debounce = false --Now the script is ready to be pressed again |
10 | end |
11 | end) |
Final Product
01 | local Part = script.Parent |
02 | local debounce = false |
03 |
04 | Part.Touched:Connect(function(hit) |
05 | local player = game:GetService("Players"):GetPlayerFromCharacter(hit.Parent) |
06 | if not debounce and player and script.Parent.Parent.TrafficLight1.TSM.Red.PointLight.Brightness == 8 then |
07 | debounce = true |
08 | player.leaderstats.Money.Value = player.leaderstats.Money.Value - 300 |
09 | wait(1.5) --or however long it takes for the player to cross the red light in seconds |
10 | debounce = false |
11 | end |
12 | end) |
Hope it helps!
1
0