This script I've created doesn't save, but has no errors. Please help?

Asked by

6 years ago

So, here's the script:

001local ReplicatedStorage = game:GetService("ReplicatedStorage")
002local DS = game:GetService("DataStoreService"):GetDataStore("Statsandstuff")
003 
004 
005game.Players.PlayerAdded:Connect(function(plr)
006    local player = plr
007    repeat wait() until player.Character
008 
009    local hitbox = Instance.new("Part")
010    local weld = Instance.new("Weld",hitbox)
011    hitbox.Parent = player.Character
012    hitbox.Name = "PlayerHitBox"
013    hitbox.Size = Vector3.new(3.85, 5.74, 1.19)
014    hitbox.Position = Vector3.new(player.Character.UpperTorso.Position.X,player.Character.UpperTorso.Position.Y - 2,player.Character.UpperTorso.Position.Z)
015    hitbox.Transparency = 1
016    hitbox.CanCollide = false
017    weld.Part0 = hitbox
018    weld.Part1 = player.Character.HumanoidRootPart
019 
020    local folder = Instance.new("Folder")
021    folder.Name = player.Name
022    folder.Parent = ReplicatedStorage
023 
024    local folder2 = Instance.new("Folder")
025    folder2.Name = player.Name
026    folder2.Parent = game:GetService("ServerScriptService")
027 
028    local vars = Instance.new("Folder") 
029    vars.Parent = folder
030    vars.Name = "Vars"
031 
032    local Int = Instance.new("NumberValue")
033    Int.Parent = vars
034    Int.Name = "Intelligence"
035 
036    local Lev = Instance.new("NumberValue")
037    Lev.Parent = vars
038    Lev.Name = "Level"
039 
040    local Points = Instance.new("NumberValue")
041    Points.Parent = vars
042    Points.Name = "Points"
043 
044    local Quirk = Instance.new("StringValue")
045    Quirk.Parent = vars
046    Quirk.Name = "Quirk"
047 
048    local QuirkD = Instance.new("NumberValue")
049    QuirkD.Parent = vars
050    QuirkD.Name = "QuirkDevelopment"
051 
052    local Stam = Instance.new("NumberValue")
053    Stam.Parent = vars
054    Stam.Name = "Stamina"
055 
056    local Str = Instance.new("NumberValue")
057    Str.Parent = vars
058    Str.Name = "Strength"
059 
060    local XP = Instance.new("NumberValue")
061    XP.Parent = vars
062    XP.Name = "XP"
063 
064    local XPTL = Instance.new("NumberValue")    
065    XPTL.Parent = vars
066    XPTL.Name = "XPtolevel"
067 
068    local savedstuff = DS:GetAsync(plr.userId)
069    if savedstuff then
070        for i,v in pairs(savedstuff) do
071            if i % 2 == 0 then
072                ReplicatedStorage[plr.Name].Vars:FindFirstChild(savedstuff[i-1]).Value = v
073            end
074        end
075 
076    else
077    Int.Value = 1
078    Lev.Value = 0
079    Points.Value = 0
080    Quirk.Value = "Quirkless"
081    QuirkD.Value = 1
082    Stam.Value = 1
083    Str.Value = 1
084    XP.Value = 0
085    XPTL.Value = 50
086    end
087 
088end)
089 
090local function savestuff(plr)
091    local saveddata = {}
092    for i,v in pairs(ReplicatedStorage[plr.Name].Vars:GetChildren()) do
093        saveddata[#saveddata + 1] = v.Name
094        saveddata[#saveddata + 1] = v.Value 
095    end
096    DS:SetAsync(plr.userId, saveddata)
097end
098 
099game.Players.PlayerRemoving:Connect(function(plr)
100    savestuff(plr)
101end)
 View all 101 lines...

I get no errors whatsoever, but it won't save. Please help!

Ignore the hitbox stuff, that is irrelevant. AgencyDrone 0 — 6y

Player removing must be changed to game:BindToClose because Player removing doesn't work any more for datastores greatneil80 2647 — 6y

Possibly on line 7 have wait() until plr.Character.Loaded == true iladoga 129 — 6y

So whenever I use BindToClose it stalls the game and nearly crashes studio until saying it didn't work and is either in a queue or stopped the script. AgencyDrone 0 — 6y

This script I've created doesn't save, but has no errors. Please help?

Answer this question