Pathfinding NPCs Lag in Game, how do i fix?

Asked by

6 years ago

I've seen many players reporting this problem but i can never seem to update my script to fix this problem. When NPCs are wandering, they always seem to stop and start moving, along with a short pause of animation. some people say things about humanoid.MoveToFinished:Wait() but i'm not sure if it has anything to do with the script i'm using. Here is the script I am using, be warned it's long.

001    local players = Info.Players:GetPlayers()
002    local closestCharacter, closestCharacterDistance
003 
004    for i=1, #players do
005        local player = players[i]
006 
007        if player.Neutral or player.TeamColor ~= Settings.FriendlyTeam.Value then
008            local character = player.Character
009 
010            if character ~= nil and character:FindFirstChild('Humanoid') ~= nil and character.Humanoid:IsA('Humanoid') then
011                local distance = player:DistanceFromCharacter(Monster:GetCFrame().p)
012 
013                if distance < Monster:GetMaximumDetectionDistance() then
014                    if closestCharacter == nil then
015                        closestCharacter, closestCharacterDistance = character, distance
016                    else
017                        if closestCharacterDistance > distance then
018                            closestCharacter, closestCharacterDistance = character, distance
019                        end
020                    end
021                end
022            end
023        end
024    end
025 
026 
027    if closestCharacter ~= nil then
028        Mind.CurrentTargetHumanoid.Value = closestCharacter.Humanoid
029    end
030end
031 
032function Monster:TryRecomputePath()
033    if Data.AutoRecompute or tick() - Data.LastRecomputePath > 1/Info.RecomputePathFrequency then
034        Monster:RecomputePath()
035    end
036end
037 
038function Monster:GetTargetCFrame()
039    local targetHumanoid = Mind.CurrentTargetHumanoid.Value
040 
041    if Monster:TargetIsValid() then
042        return targetHumanoid.Torso.CFrame
043    else
044        return CFrame.new()
045    end
046end
047 
048function Monster:IsAlive()
049    return Self.Humanoid.Health > 0 and Self.Humanoid.Torso ~= nil
050end
051 
052function Monster:TargetIsValid()
053    local targetHumanoid = Mind.CurrentTargetHumanoid.Value
054 
055    if targetHumanoid ~= nil and targetHumanoid:IsA 'Humanoid' and targetHumanoid.Torso ~= nil and targetHumanoid.Torso:IsA 'BasePart' then
056        return true
057    else
058        return false
059    end
060end
061 
062function Monster:HasClearLineOfSight()
063    -- Going to cast a ray to see if I can just see my target
064    local myPos, targetPos = Monster:GetCFrame().p, Monster:GetTargetCFrame().p
065 
066    local hit, pos = Workspace:FindPartOnRayWithIgnoreList(
067        Ray.new(
068            myPos,
069            targetPos - myPos
070        ),
071        {
072            Self,
073            Mind.CurrentTargetHumanoid.Value.Parent
074        }
075    )
076 
077 
078    if hit == nil then
079        return true
080    else
081        return false
082    end
083end
084 
085function Monster:RecomputePath()
086    if not Data.Recomputing then
087        if Monster:IsAlive() and Monster:TargetIsValid() then
088            if Monster:HasClearLineOfSight() then
089                Data.AutoRecompute = true
090                Data.PathCoords = {
091                    Monster:GetCFrame().p,
092                    Monster:GetTargetCFrame().p
093                }
094 
095                Data.LastRecomputePath = tick()
096                Data.CurrentNode = nil
097                Data.CurrentNodeIndex = 2 -- Starts chasing the target without evaluating its current position
098            else
099                -- Do pathfinding since you can't walk straight
100                Data.Recomputing = true -- Basically a debounce.
101                Data.AutoRecompute = false
102 
103 
104                local path = Info.PathfindingService:ComputeSmoothPathAsync(
105                    Monster:GetCFrame().p,
106                    Monster:GetTargetCFrame().p,
107                    500
108                )
109                Data.PathCoords = path:GetPointCoordinates()
110 
111 
112                Data.Recomputing = false
113                Data.LastRecomputePath = tick()
114                Data.CurrentNode = nil
115                Data.CurrentNodeIndex = 1
116            end
117        end
118    end
119end
120 
121function Monster:Update()
122    Monster:ReevaluateTarget()
123    Monster:SearchForTarget()
124    Monster:TryRecomputePath()
125    Monster:TravelPath()
126end
127 
128function Monster:TravelPath()
129    local closest, closestDistance, closestIndex
130    local myPosition = Monster:GetCFrame().p
131    local skipCurrentNode = Data.CurrentNode ~= nil and (Data.CurrentNode - myPosition).magnitude < 3
132 
133    for i=Data.CurrentNodeIndex, #Data.PathCoords do
134        local coord = Data.PathCoords[i]
135        if not (skipCurrentNode and coord == Data.CurrentNode) then
136            local distance = (coord - myPosition).magnitude
137 
138            if closest == nil then
139                closest, closestDistance, closestIndex = coord, distance, i
140            else
141                if distance < closestDistance then
142                    closest, closestDistance, closestIndex = coord, distance, i
143                else
144                    break
145                end
146            end
147        end
148    end
149 
150 
151    --
152    if closest ~= nil then
153        Data.CurrentNode = closest
154        Data.CurrentNodeIndex = closestIndex
155 
156        local humanoid = Self:FindFirstChild 'Humanoid'
157 
158        if humanoid ~= nil and humanoid:IsA'Humanoid' then
159            humanoid:MoveTo(closest)
160        end
161 
162        if Monster:IsAlive() and Monster:TargetIsValid() then
163            Monster:TryJumpCheck()
164            Monster:TryAttack()
165        end
166 
167        if closestIndex == #Data.PathCoords then
168            -- Reached the end of the path, force a new check
169            Data.AutoRecompute = true
170        end
171    end
172end
 View all 172 lines...

Hope there is something that can be done about this. Also, sorry for the long script again.

Same i figured out it takes some time for it to recalculate a path to a player for my npc it stops more the closer it gets to the player ...stops as in kinda bumpy stopping 129Steve129 7 — 6y

Exactly, but my NPCs stop when trying to walk around solid parts, if the player were to be in a straight line from the NPC without any obstacles, then it will not lag mrfrank79 30 — 6y

Pathfinding NPCs Lag in Game, how do i fix?

1 answer

Answer this question