Scripting Helpers is winding down operations and is now read-only. More info→

HELP WITH DATA STORES? [WONT WORK, PLEASE HELP!]?

Asked by

Oficcer_F 207

6 years ago

Edited 6 years ago

ERROR: Attempt to index local 'savedValues' (a number value)?

01DataStore = game:GetService("DataStoreService"):GetDataStore("PeasStore")
02 
03 
04game.Players.PlayerAdded:connect(function(player)
05 
06local stats = Instance.new("IntValue", player)
07stats.Name = "leaderstats"
08 
09local points = Instance.new("IntValue", stats)
10points.Name = "Points"
11 
12local coins = Instance.new("IntValue", stats)
13coins.Name = "Coins"
14 
15local key = ("player-" .. player.UserId)
16local savedValues = DataStore:GetAsync(key)
17 
18if savedValues then
19    points.Value = savedValues[1]
20    coins.Value = savedValues[2]
21else
22    local valuesToSave = {points.Value}
23    DataStore:SetAsync(key, valuesToSave)
24 
25 
26 
27 
28 
29end
30 
31end)
 View all 31 lines...

Error at line 19

``PLEASE HELP ME!

Line 22. You make a table with curly braces {} not brackets () User#19524 175 — 6y

Still doesnt work. Oficcer_F 207 — 6y

try dis: points.Value = savedValues[1] , coins.Value = savedValues[2] mixgingengerina10 223 — 6y

That is what I wrote.. Oficcer_F 207 — 6y

View all comments (5 more)

No commas... See before you judge mixgingengerina10 223 — 6y

So? Did it work or what? mixgingengerina10 223 — 6y

Hello?? mixgingengerina10 223 — 6y

I will try. But how will I write it? Oficcer_F 207 — 6y

I wrote it with commas, and on the same line. But I just got an error. Thanks for the help anyways! :) Oficcer_F 207 — 6y

1 answer

Answered by

zblox164 531

6 years ago

Edited 6 years ago

You need to save when the player leaves the game too. I also added some things to the script that will help.

Try this:

01-- Define variables
02local DataStoreService = game:GetService("DataStoreService")
03local Players = game:GetService("Players")
04 
05-- You should put your data store as a separate variable then the service one 
06local DataStore = DataStoreService:GetDataStore("NameHere")
07 
08-- Loads the data back to the player
09local function Load(plr)
10    -- Creates the stats
11    local leaderstats = Instance.new("Folder")
12    leaderstats.Name = "leaderstats"
13    leaderstats.Parent = plr
14 
15    local points = Instance.new("IntValue")
16    points.Name = "Points"
17    points.Parent = leaderstats
18 
19    local coins = Instance.new("IntValue")
20    coins.Name = "Coins"
21    coins.Parent = leaderstats
22 
23    -- Don't give a value yet
24    local SavedStats
25    local Key = "plr-"..plr.UserId -- key
26 
27    pcall(function() -- Stops errors
28        -- Data Stores can error so thats why I did this
29        SavedStats = DataStore:GetAsync(Key)
30    end)
31 
32    -- Gives the player the data if they have data else create a datastore for them
33    if SavedStats then
34        points.Value = SavedStats[1]
35        coins.Values = SavedStats[2]
36    else
37        local Values = {
38            points.Value;
39            coins.Value
40        }
41 
42        pcall(function() -- Stops errors
43            DataStore:SetAsync(Key, Values)
44        end)
45    end
46end
47 
48-- Saves on leaving
49local function Save(plr)
50    local Key = "plr-"..plr.UserId
51 
52    local Values = {
53        plr.leaderstats.Points.Value;
54        plr.leaderstats.Coins.Value
55    }
56 
57    pcall(function() -- Stops errors
58        DataStore:SetAsync(Key, Values)
59    end)
60end
61 
62Players.PlayerAdded:Connect(Load)
63Players.PlayerRemoving:Connect(Save)
 View all 63 lines...

I know it may look intimidating since it has 63 lines but it's just an upgraded version to what you had. Also make sure you have datastore enabled for your place. If you don't you can enable it by going to your place and clicking on the tree dots. Next press configure this place. Click on Games. Then press the Allow this place to be updated using the Save Place API in your game. checkbox.

Hope this helps!`

Could you explain what the ';' does at line 53? Thanks! Oficcer_F 207 — 6y

Semi-colon Oficcer_F 207 — 6y

The semi colon does the same thing as a comma in this case. You can use commas instead of the semi colon (in this case). zblox164 531 — 6y

Ok thanks! Oficcer_F 207 — 6y

View all comments (2 more)

I edited the script, now it wont work. https://scriptinghelpers.org/questions/66624/data-store-wont-work-no-errors-please-help Oficcer_F 207 — 6y

Could you please edit out the pcalls, they seem to not work for me. Then I will accept the answer, thanks! Oficcer_F 207 — 6y

HELP WITH DATA STORES? [WONT WORK, PLEASE HELP!]?

1 answer

Answer this question