Scripting Helpers is winding down operations and is now read-only. More info→

CharacterAdded only firing when the character 'respawns' instead of 'spawning'?

Asked by

6 years ago

The issue is, when the player's character spawns (when the player first joins the game), the code I wrapped inside of CharacterAdded won't run at all. But when my player's character respawns, everything runs just fine.

I don't think it's because the player joined before the server initializes, because I used one of my alt accounts on a different device to join an already opened server, and the results are the same.

I also don't think it's because of the code inside of CharacterAdded, I even tried

1game:GetService("Players").PlayerAdded:Connect(function(plr)
2    plr.CharacterAdded:Connect(function(char)
3        print("works")
4    end)
5end)

and it still doesn't print 'works'.

If anyone thinks of what the issue is, please help me out.

01game:GetService("Players").PlayerAdded:Connect(function(plr)
02    plr.CharacterAdded:Connect(function(char)
03        local head = char:WaitForChild("Head")
04        local hum = char:WaitForChild("Humanoid")
05        local BW = hum:WaitForChild("BodyWidthScale")
06        local BH = hum:WaitForChild("BodyHeightScale")
07        local BD = hum:WaitForChild("BodyDepthScale")
08        local tor = char:WaitForChild("UpperTorso")
09        local lhand = char:WaitForChild("LeftHand")
10        local rhand = char:WaitForChild("RightHand")
11        local lhandswing = Instance.new("Sound", lhand)
12        lhandswing.SoundId = "rbxassetid://138097048"
13        lhandswing.Name = "LeftHandSwing"
14        lhandswing.Volume = 2
15        local rhandswing = Instance.new("Sound", rhand)
16        rhandswing.SoundId = "rbxassetid://138097048"
17        rhandswing.Name = "RightHandSwing"
18        rhandswing.Volume = 2
19 
20        hum.DisplayDistanceType = Enum.HumanoidDisplayDistanceType.None
21        hum.HealthDisplayType = Enum.HumanoidHealthDisplayType.AlwaysOff
22 
23        hum.MaxHealth = hp.Value
24        hum.Health = hp.Value
25 
26        hp.Changed:Connect(function()
27            hum.MaxHealth = hp.Value
28            hum.Health = hp.Value
29        end)
30 
31        local randomBW = math.random(5, 30)
32        randomBW = randomBW / 10
33        BW.Value = BWSave:GetAsync(k) or randomBW
34        BWSave:SetAsync(k, BW.Value)
35 
36        local randomBH = math.random(5, 30)
37        randomBH = randomBH / 10
38        BH.Value = BHSave:GetAsync(k) or randomBH
39        BHSave:SetAsync(k, BH.Value)
40 
41        BD.Value = BWSave:GetAsync(k) or randomBW
42 
43        BW.Changed:Connect(function()
44            BD.Value = BW.Value
45            BWSave:SetAsync(k, BW.Value)
46        end)
47 
48        BH.Changed:Connect(function()
49            BHSave:SetAsync(k, BH.Value)
50        end)
51 
52    end)
53end)
 View all 53 lines...

The parent argument to Instance.new() is deprecated. The parent should always be assigned last than first for better performance. User#19524 175 — 6y

1 answer

Answered by

xPolarium 1388

6 years ago

Edited 6 years ago

Made this comment but decided to make an answer;

'Try waiting for the character's humanoid using an if statement. In solo mode, scripts can load before or after the player loads.'

I've not had any issue with PlayerAdded since before FilteringEnabled became standard but some of the things I usually do is define Services into a variable with GetService. This may be just a micro-optimization but it's something I pretty much do all the time now.

1--I read a while back its a good idea doing this but I'm pretty sure it was only a micro optimization
2--Its now a habit I do to every service
3local Players = game:GetService("Players")
4 
5Players.PlayerAdded:Connect(function(plr)
6    plr.CharacterAdded:Connect(function(char)
7        print("works")
8    end)
9end)

If it still doesn't work, are you sure this inside a 'Normal' Script.

edit: geez, 4:3 laptops can sure mess with your wording

Your repeat loop is wrong. It is "repeat wait() until" not repeat then. Also that loop is completely redundant. User#19524 175 — 6y

CharacterAdded only firing when the character 'respawns' instead of 'spawning'?

1 answer

Answer this question