Animation doesn't load when client fires sever?

Asked by

6 years ago

When my client fires a Remote Event, the server doesn't return any error. When I do fire the event, the first animation never seems to load. There's no indacation in my script that says straight out of the bloom, "Hey, this is an error." Take a look at the server script.

001local PunchEvent = game.ReplicatedStorage:WaitForChild('punch')
002local Cooldown = 0.8
003 
004local PunchData = {}
005local Cooldowns = {}
006 
007local function PlaySound(ID,Parent)
008    local Sound = Instance.new("Sound")
009    Sound.SoundId = "rbxassetid://"..ID
010    Sound.PlayOnRemove = true
011    Sound.Parent = Parent
012    Sound:Destroy()
013end
014 
015function Make(Character)
016        local CantRegen = Instance.new("IntValue")
017        CantRegen.Name = "CantRegen"
018        CantRegen.Parent = Character
019        game.Debris:AddItem(CantRegen, 1)
020end
021 
022PunchEvent.OnServerEvent:Connect(function(Player)
023 
024    if Cooldowns[Player] then -- player has used cooldowns before
025        if Cooldowns[Player] >= tick() - Cooldown then -- player has not completed cooldown
026            return -- return code so code below doesn't execute
027        end
028    end
029 
030    Cooldowns[Player] = tick() -- set so player can not use punch event for cooldown seconds
031 
032    local Data = Player:WaitForChild('Data')
033    local Stamina = Data:WaitForChild('Stamina')
034 
035    if Stamina.Value < 11 then
036        return
037    else
038        Stamina.Value = Stamina.Value - 10  -- take 10 stamina away
039    end
040 
041    local Character = Player.Character or Player.CharacterAdded:Wait() -- get player character, if it doesn't exist wait for it
042 
043    Make(Character)
044 
045    local Humanoid = Character:WaitForChild("Humanoid")
046    local Animator = Humanoid:WaitForChild("Animator")
047 
048    if PunchData[Character] == nil then -- if there is no data for this character
049        PunchData[Character] = { -- set it for the first time
050            ["LeftPunch"] = Animator:LoadAnimation(game:GetService("ReplicatedStorage"):WaitForChild("Left")),
051            ["RightPunch"] = Animator:LoadAnimation(game:GetService("ReplicatedStorage"):WaitForChild("Right")), -- doesnt load
052            ["LastPunch"] = "LeftPunch",
053            ["CanPunch"] = true
054        }
055    end
056 
057    local SecondaryDataTable = PunchData[Character]
058 
059    local RightHand = Character.RightHand
060    local LeftHand = Character.LeftHand
061 
062    local CurrentConnection = nil
063    local CurrentAnimationTrack = nil
064 
065    if SecondaryDataTable.LastPunch == "LeftPunch" then
066        SecondaryDataTable.CanPunch = false
067        SecondaryDataTable.LastPunch = "RightPunch"
068 
069        PlaySound(711753382, Character.RightHand)
070        CurrentAnimationTrack = SecondaryDataTable.RightPunch
071 
072        CurrentConnection = Character.RightHand.Touched:Connect(function(Hit)
073            local Humanoid = Hit.Parent:FindFirstChildOfClass("Humanoid")
074            if Humanoid then
075                Humanoid:TakeDamage(12)
076                PlaySound(367499850, RightHand)
077                CurrentConnection:Disconnect()
078            end
079        end)
080 
081 
082    elseif SecondaryDataTable.LastPunch == "RightPunch" then
083        SecondaryDataTable.CanPunch = false
084        SecondaryDataTable.LastPunch = "LeftPunch"
085 
086        PlaySound(711753382, LeftHand)
087        CurrentAnimationTrack = SecondaryDataTable.LeftPunch
088 
089        CurrentConnection = Character.LeftHand.Touched:Connect(function(Hit)
090            local Humanoid = Hit.Parent:FindFirstChildOfClass("Humanoid")
091            if Humanoid then
092                Humanoid:TakeDamage(12)
093                PlaySound(367499850, LeftHand)
094                CurrentConnection:Disconnect()
095            end
096        end)
097 
098        CurrentAnimationTrack:Play()
099        CurrentAnimationTrack.Stopped:Wait()
100        if CurrentConnection then CurrentConnection:Disconnect() end
101        SecondaryDataTable.CanPunch = true
102    end
103end)
 View all 103 lines...

And here's the client script.

01local Players = game:GetService('Players')
02local ReplicatedStorage = game:GetService('ReplicatedStorage')
03local UserInputService = game:GetService('UserInputService')
04 
05local Player = Players.LocalPlayer
06local PunchEvent = game.ReplicatedStorage.punch
07 
08UserInputService.InputBegan:Connect(function(Key, GameProcessedEvent)
09    if not GameProcessedEvent then
10        if Key.UserInputType == Enum.UserInputType.MouseButton1 then
11            PunchEvent:FireServer()
12        end
13    end
14end)

You actually don't need a RemoteEvent to play animations, animations are part of player physics, so they replicate. I'd only use the RemoteEvent for dealing damage. User#19524 175 — 6y

So how do I solve my problem? FireyMcBlox 134 — 6y

Well I don't think you should be nesting events inside of others, like the Touched events you have. You could make a script, parent under the script, and clone it when the key is pressed from the remote. User#19524 175 — 6y

Seems benefical. But, how does this tie in with the animation problem? FireyMcBlox 134 — 6y

Animation doesn't load when client fires sever?

1 answer

Answer this question