Script to make a gui invisible or visible not working. Why is this happening?
I have made a certain key that makes a frame visible or invisible. This isn't working. Can someone tell me why and how to fix it?
01 | local Player = game.Players.LocalPlayer |
02 | local Mouse = Player:GetMouse() |
03 | local CoolFrame = game.StarterGui.ScreenGui.Frame |
04 |
05 | Mouse.KeyDown:Connect(function(Key) |
06 | Key = Key:lower() |
07 | if Key == 'e' then |
08 | if CoolFrame.Visible == false then |
09 | CoolFrame.Visible = true |
10 | else |
11 | CoolFrame.Visible = false |
12 | end |
13 | end |
14 | end) |
0
5 answers
1st. Deprecated Code 2nd. You can't access GUIs from starter gui once you're playing. It's cloned to playergui.
01 | uis = game:GetService("UserInputService") |
02 | p = game.Players.LocalPlayer |
03 | Frame = p.PlayerGui.ScreenGui.Frame |
04 | uis.InputBegan:Connect(function(k, gpe) |
05 | if not gpe and k.KeyCode == Enum.KeyCode.E then |
06 | if Frame.Visible == false then |
07 | Frame.Visible = true |
08 | else |
09 | Frame.Visible = false |
10 | end |
11 | end) |
You can't acces starter gui like that.
What you can do is put the local script inside of a screen gui and then define the frame like script.Parent:WaitForChild("FrameName")
Other possibility is to have your local script whereever you have it now and access it through PlayerGui like this: player.PlayerGui:WaitForChild("ScreenGui"):WaitForChild("FrameName")
Now I won't rewrite your code for you but that's what you should consider
0
0
01 | local Player = game.Players.LocalPlayer |
02 | local Mouse = Player:GetMouse() |
03 | local CoolFrame = Player.PlayerGui.ScreenGui.Frame |
04 |
05 | Mouse.KeyDown:Connect(function(Key) |
06 | Key = Key:lower() |
07 | if Key == 'e' then |
08 | if CoolFrame.Visible == false then |
09 | CoolFrame.Visible = true |
10 | else |
11 | CoolFrame.Visible = false |
12 | end |
13 | end |
14 | end) |
It's player.playergui NOT startergui, startergui contents just get copied to the playergui.
BTW~~~~do not use Mouse.KeyDown as it is deprecated, use the Context Action Service!
Three things, Mouse.KeyDown is deprecated, use the UserInputService. Also, this needs to be on the Client side in a Local Script. And finally, you are changing the StarterGui which will only take into affect after you reset and it gives you a new gui. You need to use the PlayerGui.
01 | local UserInputService = game:GetService("UserInputService") |
02 |
03 | local Player = game.Players.LocalPlayer |
04 |
05 | local CoolFrame = Player:WaitForChild("PlayerGui").ScreenGui.Frame |
06 |
07 | local function onInputBegan(input,gameProcessed) |
08 | if not gameProcessed then |
09 | if input.UserInputType == Enum.UserInputType.Keyboard then |
10 | local keyPressed = input.KeyCode |
11 | if keyPressed == Enum.KeyCode.E then |
12 | if CoolFrame.Visible == false then |
13 | CoolFrame.Visible = true |
14 | else |
15 | CoolFrame.Visible = false |
0
0
0
:lower() does not exist use string.lower() instead or even better use Enum
0
0
0