Scripting Helpers is winding down operations and is now read-only. More info→
Ad
Log in to vote
1

What is wrong with my extremely basic code for my bomb's sounds?

Asked by
Juolite395 11
6 years ago

Hey, I'm completely new to Roblox Studio scripting,(And this site, this is my first post so excuse bad format please) and of course I'm no good. I've made some very basic scripts and my first test-project is to make a kind of timed bomb. One part of the code involves changing from one bleep sound per second to two bleeps per second, to three bleeps per seconds, etc... as the timer gets closer and closer to 0. However, it only seems capable of setting it to one and two bleeps per second. It does not change from two to three. My code is likely badly written and probably would create lag but that's not what I'm asking the solution to, so please don't comment about badly written code unless it is relevant. Please note how new I am to Roblox Studio. I won't know what many things are.

General Information:

I am testing in Roblox Studio's solo play - test system. I don't really mind if it does not work in an online game, this is just practise. These are regular scripts, and they are just inside a model inside a part in the workspace. No Lua errors appear however it does not work so it is technically still an error, no? The expected outcome is that the bomb beeps once per second above 25 seconds left, twice per second from 24 to 15, thrice per second from 14 to 10, etc... The outcome is that it beeps once per second above 25 seconds, and twice per second 24 to 0. (0 would be where it either explodes or hits a Critical Error, which is irrelevant to this question.) . I hope this information proves beneficial.

Things inside my bomb's model:

I have the main visual model which I assume is irrelevant as it has no scripts. I have two buttons with click detectors. I have a screen which contains the two main scripts, the Timer Script which manages the visual timer and the pause-go buttons, and the Bleep Script which manages the sounds. The Timer Script works perfectly well alone, just has no sound. If you would like me to show you what the Timer Script is, just ask. For now I will assume the problem is purely in the Bleep Script. I will show the code used to detect how many beeps should be played per second as this is where I think the problem is:

view source
01z = script.Parent.TimeLeft.Value --This is finding the time left in the bomb's timer.
02 
03function BleepSpeed()
04 
05    if z >= 25 then
06 
07        bleepTimes = 1
08 
09    elseif z == 24 or 23 or 22 or 21 or 20 or 19 or 18 or 17 or 16 or 15 then
10 
11        bleepTimes = 2     
12 
13    elseif z == 14 or 13 or 12 or 10 then
14 
15        bleepTimes = 3
View all 29 lines...

the bleepTimes variable is used in extremely primitive code to play the sound a certain amoount of times. If bleepTimes = 1 then it would do one bleep per second.

This next bit of code is the loop that I use to keep ticking to the next second. Both scripts have a similar bit of code, just that one changes the visual timer while this one plays the sound.

view source
01z = script.Parent.Time.Value    -This is setting the Time Left in the timer to full at the start.
02keepItGoing = true --This keeps the loop checking forever.
03 
04while keepItGoing == true do
05    wait(0.025)    --Meant to reduce lag
06    if Triggered == true then   --If the bomb is on, not paused
07        if script.Parent.CriticalError.Value == false then    --[[If the bomb is not experiencing an Error, which is a non-relevant part of my bomb's code]]--
08            CheckBleeps()  --Calls the function for checking, and then playing the sounds.
09            wait(1 - y)  --Waits one second minus the time taken to play the sounds.
10        end
11    end
12end

And finally, the CheckBleeps function, which is played every second the bomb is activated.

view source
01y = 0   --This is at the start of the game, not the function, but it is relevant to this code.
02function CheckBleeps()
03 
04        z = z - 1
05        BleepSpeed()   
06        print(z)
07        if bleepTimes == 1 then
08 
09        script.Parent.Parent.Parent.Parent.Bleep:Play()
10        y = 0
11 
12        elseif bleepTimes == 2 then
13 
14        script.Parent.Parent.Parent.Parent.Bleep:Play()
15        wait(0.2)
View all 52 lines...

If there is anything more that I need to add or any information you lack, or even improper fomatting for this site, please tell me. I will be checking this often.

Thank you so much for your time, even if you're just reading this :D

1 answer

Log in to vote
1
Answered by
chomboghai 2044 Moderation Voter Community Moderator
6 years ago
Edited 6 years ago

When finding your bleepTimes, you are using or incorrectly.

I am referencing the lines where you make checks like these:

view source
1elseif z == 4 or 3 or 2 or 1 or 0 then

You are first checking if z is 4, which is valid. Then, when you say or 3, you are checking if 3 exists, not if z is 3. To do this, you should say or z == 3.

However, this is also very inefficient and can be tedious. Instead, to check if z is in a specified range, use the operations >=, >, <=, <. The statement above can be rewritten as:

view source
1else if z <= 4 and z >= 0 then -- checks if z is between 4 and 0 (inclusive)

Hope this helps.

EDIT:

In addition to the above, I highly recommend making sure your code is clean and you are using optimal keywords.

One example I notice right off the bat is where you've written this:

view source
1while keepItGoing == true do

Instead of checking if something is true or false using == true, you can simply say:

view source
1while keepItGoing do -- checks if keepItGoing is true
2 
3if not script.Parent.CriticalError.Value then -- checks if CriticalError's value is false
4 
5-- i would reference it in a variable also so:
6local criticalError = script.Parent.CriticalError
7if not criticalError.Value then -- checks if CriticalError's value is false

Finally, be sure to use loops rather than rewriting the same lines over and over. With this, I am referencing where you say:

view source
01elseif bleepTimes == 5 then
02        script.Parent.Parent.Parent.Parent.Bleep:Play()
03        wait(0.2)
04        script.Parent.Parent.Parent.Parent.Bleep:Play()
05        wait(0.2)
06        script.Parent.Parent.Parent.Parent.Bleep:Play()
07        wait(0.2)
08        script.Parent.Parent.Parent.Parent.Bleep:Play()
09        wait(0.2)
10        script.Parent.Parent.Parent.Parent.Bleep:Play()
11        y = 0.8
12end

You can instead use a for loop to do the exact same thing, but much less work and much cleaner:

view source
1local bleepSound = script.Parent.Parent.Parent.Parent.Bleep
2for i=1, bleepTimes do
3    bleepSound:Play()
4    wait(0.2)
5end
6y = (bleepTimes - 1) * 0.2 -- if bleepTimes is 1, y = 0, bleepTimes is 2, y = 0.2, etc..

Good luck!

0
You should've also told OP to use more variables on the instances, because using a lot of parents is ugly style. Apart from that, good answer. +1 upvote. User#19524 175 — 6y
1
@incapaz is right, it's not necessarily "wrong" to use a lot of script.Parent.Parent.etc... but you should use variables to store them so it's easier than typing out Parent 100 times. And I'm glad it helped you out! :) chomboghai 2044 — 6y
1
This worked perfectly, and was allot faster to write! My model sounds so much better now, and my understanding of "or" has improved! Thank you so much! Juolite395 11 — 6y
1
incapaz also thanks for that info :D and for chomboghai thanks for the extra info in your edit! I will use loops now, and i will remember all these shortcuts. Thanks to everyone :D Juolite395 11 — 6y
Ad

Answer this question