Scripting Helpers is winding down operations and is now read-only. More info→

DataStore Error Attempt to index local 'VaribleName' (A nil value) Line 507?

Asked by

6 years ago

The Issue I'm getting is 00:34:31.785 - ServerScriptService.Clothing_DataStore:507: attempt to index local 'HotAirBalloon' (a nil value)

PasteBin For the Code

Gears["Hot Air Balloon"] ? , Is it good? . That was long code e.e User#17685 0 — 6y

1 answer

Answered by

User#5423 17

6 years ago

All of your code of just dealing with bool values? You should have seen how much code has been duplicated and changed the design.

There are far better ways of storing data than just putting value objects into the players model.

If you need to use these value objects create a function to make them. You hard code everything which is not how things should be done. Instead use loops and the correct table structures to setup, save and load data.

You error could be down to a lot of things in your code as it is not easy to add or remove itemst from a array without changing how other data is loaded.

In addition to this you have a lot of infinate loops which will cause errors and other issues if the player leaves the games.

An auto save should not be linked per player and should go through and save player data who are in the game.

There is a lot that needs to be looked at in your code and this is just one solution. There are better solutions which you should look into and this code does not account for any data store errors. I would also reccomend that you split this code up into modules.

As this code uses a differnt save / load format I have changed the key prefix to act as a new save.

Example:-

001local statsSetup = {
002    Shirts = {
003        "RedShirt"
004    },
005    Hats = {
006        "BlackValk Shades",
007        "The Classic ROBLOX Fedora"
008        -- add other hats here
009    },
010    Faces = {
011        "Bandage",
012        "Beast Mode"
013        -- add other faces here
014    },
015    Titles = {
016        "Athlete",
017        "Awesome"
018        -- add other titles here
019    },
020    Gears = {
021        "Hot Air Balloon",
022        "Hoverboard"
023        -- add other gears here
024    }
025}
026 
027-- build a new instace with the data passed
028local function mkInstance(insType, name, val)
029    local tmp = Instance.new(insType)
030    tmp.Name = name
031    if val then
032        tmp.Value = val
033    end
034    return tmp
035end
036 
037local tmpStats = Instance.new("Folder")
038 
039-- loop over the table and create instances
040for folderName, itemList in pairs(statsSetup) do
041    local folder = mkInstance("Folder", folderName)
042 
043    for _, itm in pairs(itemList) do
044        local tmpItem = mkInstance("BoolValue", itm, false)
045        tmpItem.Parent = folder
046    end
047 
048    folder.Parent = tmpStats
049end
050 
051 
052local ds = game:GetService("DataStoreService"):GetDataStore("Clothing")
053local prefix = "usr_"
054game:GetService('Players').PlayerAdded:Connect(function(plr)
055 
056    local data = ds:GetAsync(prefix .. tostring(plr.UserId))
057    local stats = tmpStats:Clone()  
058 
059    -- if there is data
060    if data then
061        -- loop through data 
062        for folderName, itemList in pairs(data) do
063 
064            -- find folder name
065            local folder = stats:FindFirstChild(folderName)
066            if folder then -- check if folder is found
067 
068                -- load stats for that file
069                for _, itm in pairs(itemList) do
070                    local plrStats = folder:FindFirstChild(itm) -- find stats
071                    if plrStats then -- if stats found
072                        plrStats.Value = true -- set stats to true 
073                    end
074                end
075 
076            end
077        end
078    end
079 
080    -- parent stats to the player
081    for _, child in pairs(stats:GetChildren()) do
082        child.Parent = plr -- parent folders to the player
083    end
084end)
085 
086local function saveData(plr)
087    local data = {}
088 
089    -- get children of the player and save them
090    -- make sure to only parent player stats to the player
091    for _, folder in pairs(plr:GetChildren()) do
092        if folder:IsA("Folder") then -- only save folders
093            local tmp = {}
094            for _, itm in pairs(folder:GetChildren()) do
095                if itm.Value then -- only save true data
096                    tmp[#tmp+1] = itm.Name -- save the name
097                end
098            end
099            data[folder.Name] = tmp
100        end
101    end
102 
103    ds:SetAsync(prefix .. tostring(plr.UserId), data)   
104end
105 
106-- call save data function
107game:GetService('Players').PlayerRemoving:Connect(function(plr)
108    saveData(plr)
109end)
110 
111-- data does not save on server shutdown as PlayerRemoving is not called
112game:BindToClose(function()
113    for _, plr in pairs(game:GetService("Players"):GetPlayers()) do
114        saveData(plr)
115    end
116end)
 View all 116 lines...

This is a lot of code to look at but please comment if you do not understand how it works.

I understand all of it. Sorry I was away for a few days. namerplz 42 — 6y

DataStore Error Attempt to index local 'VaribleName' (A nil value) Line 507?

1 answer

Answer this question