Avatar Scaling / data store not working?

Asked by

6 years ago

Today I was testing my project and I was adding saving player scale. I did a testing server with a few friends and I noticed when they reset, died or left and rejoined, their size would increase dramatically. I’m not sure what is causing this issue, I’ve looked into it and can’t find anything that would increase the size with-out a player activating the tool or the script changing the scale by force.

If you can help then I would appreciate it! Also include what I'm doing wrong.

DataStore script:

001local Data = game:GetService("DataStoreService"):GetDataStore("I")
002 
003game:GetService("Players").PlayerAdded:Connect(function(Plr)
004 
005    --  // Leaderstats
006 
007    local Stats = Instance.new("Folder", Plr)
008    Stats.Name = "leaderstats"
009 
010    local Strength = Instance.new("IntValue", Stats)
011    Strength.Name = "Strength" 
012 
013    local Rebirths = Instance.new("IntValue", Stats)
014    Rebirths.Name = "Rebirths"
015 
016    -- // Alt values
017 
018    local Scales = Instance.new("Folder", Plr)
019    Scales.Name = "Scales"
020 
021    local BWS = Instance.new("NumberValue", Scales)
022    BWS.Name = "BWS"   
023 
024    local BHS = Instance.new("NumberValue", Scales)
025    BHS.Name = "BHS"
026 
027    local BDS = Instance.new("NumberValue", Scales)
028    BDS.Name = "BDS"
029 
030    -- // Loading stuff
031 
032    local Data1 = Data:GetAsync(Plr.UserId)
033 
034    if Data1 then
035        for i, v in pairs(Stats:GetChildren()) do
036            v.Value = Data1[v.Name]
037        end
038        for i, v in pairs(Scales:GetChildren()) do
039            v.Value = Data1[v.Name]
040        end
041        print(Plr.Name .. "'s data loaded successfully!")
042    end
043 
044    -- // Saving stuff
045 
046    spawn(function()
047        while wait(60) do
048            if Stats then
049                local SaveData = {}
050                for i, v in pairs(Stats:GetChildren()) do
051                    SaveData[v.Name] = v.Value
052                end
053 
054                for i, v in pairs(Scales:GetChildren()) do
055                   SaveData[v.Name] = v.Value
056                end
057 
058                Data:SetAsync(Plr.UserId, SaveData)
059                print(Plr.Name .. "'s data autosaved successfully!")
060            end
061        end
062    end)
063 
064    Plr.CharacterAdded:Connect(function(Char)
065        wait(1)
066        repeat wait() until Char:FindFirstChild("Humanoid")
067        local Humanoid = Char:WaitForChild("Humanoid")
068        local BDS = Humanoid:WaitForChild("BodyDepthScale")
069        local BHS = Humanoid:WaitForChild("BodyHeightScale")
070        local BWS = Humanoid:WaitForChild("BodyWidthScale")
071        if Plr.leaderstats.Strength.Value == 0 then
072            BWS.Value = 0.2
073            BDS.Value = 0.2
074            BHS.Value = 1
075            Plr:FindFirstChild("Scales").BDS.Value = 0.2
076            Plr:FindFirstChild("Scales").BHS.Value = 1
077            Plr:FindFirstChild("Scales").BWS.Value = 0.2
078        else
079            BWS.Value = Plr:FindFirstChild("Scales").BWS.Value
080            BHS.Value = Plr:FindFirstChild("Scales").BHS.Value
081            BDS.Value = Plr:FindFirstChild("Scales").BDS.Value
082        end
083    end)
084end)
085 
086game:GetService("Players").PlayerRemoving:Connect(function(Plr)
087    local Stats = Plr:FindFirstChild("leaderstats")
088    local WeightStats = Plr:FindFirstChild("Scales")
089    if Stats then
090        local SaveData = {}
091        for i, v in pairs(Stats:GetChildren()) do
092            SaveData[v.Name] = v.Value
093        end
094        for i, v in pairs(WeightStats:GetChildren()) do
095            if v.ClassName == "NumberValue" then
096                SaveData[v.Name] = v.Value
097            end
098        end
099        Data:SetAsync(Plr.UserId, SaveData)
100        print(Plr.Name .. "'s data autosaved successfully!")
101    end
102end)
 View all 102 lines...

Tool local script:

01local Tool = script.Parent
02local Player = game:GetService("Players").LocalPlayer
03local Animation = Tool:WaitForChild("Handle").Animation
04local Liftable = false
05local UIS = game:GetService("UserInputService")
06local LastActivated = tick()
07 
08function Check()
09    if Liftable == true then
10        UIS.InputBegan:Connect(function(Input, GPE)
11            if GPE then
12                return
13            end
14 
15            if Input.KeyCode == Enum.KeyCode.E and Liftable == true then
16                if tick() - LastActivated >= 2.5 then
17                    print("Input Success")
18                    local AnimPlay = Player.Character:FindFirstChild("Humanoid"):LoadAnimation(Animation)
19                    AnimPlay:Play()
20                    Tool.Fire:FireServer(Player, "IsUpdatedByGame")
21                    LastActivated = tick()
22                end
23            end
24        end)
25    end
26 
27    if Liftable == false then
28        UIS.InputEnded:Connect(function(Input, GPE)
29            if GPE then
30                return
31            end
32 
33            if Input.KeyCode == Enum.KeyCode.E and Liftable == false then
34                return
35            end
36        end)
37    end
38end
39 
40 
41Tool.Equipped:Connect(function()
42    if Liftable == false then
43        Liftable = true
44        wait(0.1)
45        Check()
46        wait()
47        print("Liftable set to true!")
48    end
49end)
50 
51Tool.Unequipped:Connect(function()
52    if Liftable == true then
53        Liftable = false
54        wait(0.1)
55        Check()
56        wait()
57        print("Liftable set to false!")
58    end
59end)
 View all 59 lines...

Tool Server script:

01local Tool = script.Parent
02 
03Tool.Fire.OnServerEvent:Connect(function(Player, Check)
04    wait(0.1)
05    Player.leaderstats.Strength.Value = Player.leaderstats.Strength.Value + 1
06    Player.Scales.BWS.Value = Player.Scales.BWS.Value + 0.2
07    Player.Scales.BHS.Value = Player.Scales.BHS.Value + 0.1
08    Player.Scales.BDS.Value = Player.Scales.BDS.Value + 0.2
09    Player.Character:FindFirstChild("Humanoid").BodyWidthScale.Value = Player.Character:FindFirstChild("Humanoid").BodyWidthScale.Value + 0.03
10    Player.Character:FindFirstChild("Humanoid").BodyHeightScale.Value = Player.Character:FindFirstChild("Humanoid").BodyHeightScale.Value + 0.02
11    Player.Character:FindFirstChild("Humanoid").BodyDepthScale.Value = Player.Character:FindFirstChild("Humanoid").BodyDepthScale.Value + 0.03
12end)

Your event UserInputService event is inside a function, which is not okay. User#19524 175 — 6y

Avatar Scaling / data store not working?

Answer this question