Scripting Helpers is winding down operations and is now read-only. More info→

This leaderboard saves data when I am testing it in studio but not when I play it on roblox? [closed]

Asked by

jakebball2014 84

6 years ago

This question already has an answer here:

my datastore is still not working with filtering enabled. can any of you guys help me out here?

01local DSService = game:GetService("DataStoreService"):GetDataStore("Currency")
02local Saving = 0
03 
04game:BindToClose(function()
05    repeat wait() until Saving <= 0
06end)
07 
08game:GetService("Players").PlayerAdded:connect(function(plr)
09    local leader = Instance.new("Folder",plr)
10    leader.Name = "leaderstats"
11 
12        local Credits = Instance.new("IntValue",leader)
13        Credits.Name = "Credits"
14 
15        local Diamonds = Instance.new("IntValue",leader)
16        Diamonds.Name = "Diamonds"
17 
18    local savedData = DSService:GetAsync(plr.UserId.."-Currency")
19 
20    if savedData then
21        Credits.Value = savedData[1]
22        Diamonds.Value = savedData[2]
23    else
24        local values = {Credits.Value, Diamonds.Value}
25        DSService:SetAsync(plr.UserId.."-Currency",values)
26    end
27end)
28 
29game:GetService("Players").PlayerRemoving:connect(function(plr)
30    Saving = Saving + 1
31    local ValuesToSave = {plr.leaderstats.Credits.Value, plr.leaderstats.Diamonds.Value}
32    DSService:SetAsync(plr.UserId.."-Currency", ValuesToSave)
33    Saving = Saving - 1
34end)
 View all 34 lines...

Good habit to put datastore in modulescripts, just saying. TiredMelon 405 — 6y

Try putting the :GetAsync() and :SetAsync() methods in a pcall Trainsparency 39 — 6y

how to I put them in a pcall jakebball2014 84 — 6y

Marked as Duplicate by arshad145, User#21908, and User#19524

This question has been asked before, and already has an answer. If those answers do not fully address your question, then please ask a new question here.

Why was this question closed?

2 answers

Answered by

Echtic 128

6 years ago

Try putting wait() on top of the script, that should fix it.

Answered by

User#22219 20

6 years ago

Try using pcall. Also please do not use Instance.new with parent parameter, it's deprecated. Same with connect, use Connectinstead.

deprecated for connect and the parent paramerter mean nothing. These will probley never being going away as so meny users use those functions. outlook1234567890 115 — 6y