Scripting Helpers is winding down operations and is now read-only. More info→

Function only fires when the first string in the table is fired, but not the second or third?

Asked by

6 years ago

Im trying to make a door that locks during a lockdown and only certain cards can open the door. But for some reason it only opens during a lockdown for a Tier 3 Administrator but none of the others.

001local Clearances = {
002    ["Tier 3 Administrator"] = true,
003    ["Tier 2 Administrator"] = true,
004    ["Tier 1 Administrator"] = true,
005    ["Tier 3 Security"] = true,
006    ["Tier 2 Security"] = true,
007    ["Tier 1 Security"] = true,
008    ["Armoury Access"] = true,
009    ["Level 5"] = true,
010    ["Level 4"] = true,
011    ["Level 3"] = true,
012    ["Level 2"] = true,
013    ["Level 1"] = true,
014}
015local LockDownCards = {"Tier 3 Administrator","Tier 2 Administrator","Tier 1 Administrator"}
016local DoorPart1 = script.Parent.Door
017local DoorPart2 = script.Parent.Window
018local StatusPart = script.Parent.StatusPart
019local DoorIsBusy = false
020local DoorIsOpen = false
021local LockDown_Enabled = false
022for i, value in pairs(LockDownCards) do
023    print(LockDownCards[i])
024end
025function Activated(Part)
026    if DoorIsOpen == false and DoorIsBusy == false and LockDown_Enabled == false and Clearances[Part.Parent.Name] then
027        Open()
028    elseif DoorIsBusy == false and DoorIsOpen == true and LockDown_Enabled == false and Clearances[Part.Parent.Name] then
029        Close()
030    elseif DoorIsBusy == false and LockDown_Enabled == true and Part.Parent.Name ~= LockDownCards[1 or 2 or 3] and Clearances[Part.Parent.Name] then
031        LockDown()
032    elseif DoorIsBusy == false and LockDown_Enabled == true and DoorIsOpen == false and Part.Parent.Name == LockDownCards[1 or 2 or 3] and Clearances[Part.Parent.Name] then
033        Open()
034    elseif DoorIsBusy == false and LockDown_Enabled == true and DoorIsOpen == true and Part.Parent.Name == LockDownCards[1 or 2 or 3] and Clearances[Part.Parent.Name] then
035        Close()
036    end
037end
038 
039function Open()
040    DoorIsBusy = true
041    DoorPart1.DoorMove_Sound:Play()
042    for i = 10, 50 do
043        wait(0.01)
044        DoorPart1.CFrame = DoorPart1.CFrame * CFrame.new(-0.1,0,0)
045        DoorPart2.CFrame = DoorPart2.CFrame * CFrame.new(-0.1,0,0)
046        StatusPart.CFrame = StatusPart.CFrame * CFrame.new(-0.1,0,0)
047    end
048    wait(1)
049    StatusPart.SurfaceGui1.Open.Text = "[ OPEN ]"
050    StatusPart.SurfaceGui1.Open.TextColor3 = Color3.new(0, 255, 0)
051    StatusPart.SurfaceGui2.Open.Text = "[ OPEN ]"
052    StatusPart.SurfaceGui2.Open.TextColor3 = Color3.new(0, 255, 0)
053    DoorIsBusy = false
054    DoorIsOpen = true
055end
056 
057function Close()
058    DoorIsBusy = true
059    DoorPart1.DoorMove_Sound:Play()
060    for i = 10, 50 do
061        wait(0.01)
062        DoorPart1.CFrame = DoorPart1.CFrame * CFrame.new(0.1,0,0)
063        DoorPart2.CFrame = DoorPart2.CFrame * CFrame.new(0.1,0,0)
064        StatusPart.CFrame = StatusPart.CFrame * CFrame.new(0.1,0,0)
065    end
066    wait(1)
067    StatusPart.SurfaceGui1.Open.Text = "[ CLOSED ]"
068    StatusPart.SurfaceGui1.Open.TextColor3 = Color3.new(255, 0, 0)
069    StatusPart.SurfaceGui2.Open.Text = "[ CLOSED ]"
070    StatusPart.SurfaceGui2.Open.TextColor3 = Color3.new(255, 0, 0)
071    DoorIsBusy = false
072    DoorIsOpen = false
073end
074 
075function LockDown()
076    if DoorIsOpen == false then
077        DoorPart1.LockDown_Sound:Play()
078        DoorIsBusy = true
079        DoorPart1.DoorMove_Sound:Play()
080        for i = 10, 25 do
081            wait(0.01)
082            DoorPart1.CFrame = DoorPart1.CFrame * CFrame.new(-0.1,0,0)
083            DoorPart2.CFrame = DoorPart2.CFrame * CFrame.new(-0.1,0,0)
084            StatusPart.CFrame = StatusPart.CFrame * CFrame.new(-0.1,0,0)
085        end
086        for i = 10, 25 do
087            wait(0.01)
088            DoorPart1.CFrame = DoorPart1.CFrame * CFrame.new(0.1,0,0)
089            DoorPart2.CFrame = DoorPart2.CFrame * CFrame.new(0.1,0,0)
090            StatusPart.CFrame = StatusPart.CFrame * CFrame.new(0.1,0,0)
091        end
092        wait(1)
093        StatusPart.SurfaceGui1.Open.Text = "[ CLOSED ]"
094        StatusPart.SurfaceGui1.Open.TextColor3 = Color3.new(255, 0, 0)
095        StatusPart.SurfaceGui2.Open.Text = "[ CLOSED ]"
096        StatusPart.SurfaceGui2.Open.TextColor3 = Color3.new(255, 0, 0)
097        DoorIsBusy = false
098    end
099end
100 
101function LockDownActive()
102    if workspace.SiteStats.LockDown.Value == true then
103        LockDown_Enabled = true
104        StatusPart.SurfaceGui1.Locked.Text = "[ LOCKED ]"
105        StatusPart.SurfaceGui1.Locked.TextColor3 = Color3.new(255, 85, 0)
106        StatusPart.SurfaceGui2.Locked.Text = "[ LOCKED ]"
107        StatusPart.SurfaceGui2.Locked.TextColor3 = Color3.new(255, 85, 0)
108        if DoorIsOpen == true and DoorIsBusy == false then
109            print("Closing Door")
110            Close()
111        end
112    elseif workspace.SiteStats.LockDown.Value == false then
113        LockDown_Enabled = false
114        StatusPart.SurfaceGui1.Locked.Text = "[ UNLOCKED ]"
115        StatusPart.SurfaceGui1.Locked.TextColor3 = Color3.new(255, 255, 0)
116        StatusPart.SurfaceGui2.Locked.Text = "[ UNLOCKED ]"
117        StatusPart.SurfaceGui2.Locked.TextColor3 = Color3.new(255, 255, 0)
118    end
119end
120 
121script.Parent.CardReader1.Touched:Connect(Activated)
122script.Parent.CardReader2.Touched:Connect(Activated)
123workspace.SiteStats.LockDown.Changed:Connect(LockDownActive)
 View all 123 lines...

1 answer

Answered by

starlebVerse 685

6 years ago

Edited 6 years ago

For lines 30, 32 and 34, you cannot do LockDownCards[1 or 2 or 3] because the game will then have to choose the first option in the 1 or 2 or 3 part, which is 1. It would be the same as saying LockDownCards[1]. To read more about the or operator, click here. There is another way to check this, of course.

01-- Added before the Activated function.
02function checkForLockDownParent(Part) -- Check for whether the part belongs to one of these parents in LockDownCards.
03    for i, cardName in pairs(LockDownCards) do
04        if Part.Parent.Name == cardName then
05            return true -- Stop the function and this will become the value true when called.
06        end
07    end
08    return false -- Belongs to none, the value becomes false.
09end
10 
11-- Below is Line 25 in your original code (in your question).
12function Activated(Part)
13    if DoorIsOpen == false and DoorIsBusy == false and LockDown_Enabled == false and Clearances[Part.Parent.Name] then
14        Open()
15    elseif DoorIsBusy == false and DoorIsOpen == true and LockDown_Enabled == false and Clearances[Part.Parent.Name] then
16        Close()
17    elseif DoorIsBusy == false and LockDown_Enabled == true and checkForLockDownParent(Part) == false and Clearances[Part.Parent.Name] then -- Notice that the "== false" is added behind checkForLockDownParent(Part) so the game checks whether the value returned is false.
18        LockDown()
19    elseif DoorIsBusy == false and LockDown_Enabled == true and DoorIsOpen == false and checkForLockDownParent(Part) and Clearances[Part.Parent.Name] then
20        Open()
21    elseif DoorIsBusy == false and LockDown_Enabled == true and DoorIsOpen == true and checkForLockDownParent(Part) and Clearances[Part.Parent.Name] then
22        Close()
23    end
24end
25 
26-- Continues on...
 View all 26 lines...

I hope this will solve your problem. Comment if you have any questions. Thanks.

Thanks man, it worked perfectly. Galicate 106 — 6y

You are welcome. ;3 starlebVerse 685 — 6y

Function only fires when the first string in the table is fired, but not the second or third?

1 answer

Answer this question