displaying a piano, how would i calculate where to place the black keys?

Asked by

6 years ago

i made a piano that expands across the screen, the white keys and sizing of the black keys is working as expected, there is a folder in the same parent of the script called Piano, this is where the frames of the keys are stored, but as any piano looks, black keys are placed weirdly, how would i calculate the position of the black keys on the screen (Scale or Offset or both propertys of a udim2 can be used):

01script.Parent.DrawPiano.Event:connect(function(octaves)
02    local whitekeys = 7*octaves --calculate white keys amount
03    local blackkeys = 5*octaves --calculate black keys amount
04    for i=1,whitekeys,1 do
05        local key = Instance.new("Frame", script.Parent.Piano)
06        key.Size = UDim2.new(
07            0,
08            script.Parent.AbsoluteSize.X/whitekeys,
09            0,
10            150
11        )
12        key.Position = UDim2.new(
13            (i-1)/whitekeys,
14            0,
15            1,
16            -150
17        )
18        key.BackgroundColor3 = Color3.new(1,1,1)
19        key.BorderColor3 = Color3.new(0.67, 0.67, 0.67)
20        key.BorderSizePixel = 2
21        key.ZIndex = 2
22        key.Name = "WhiteKey"
23    end
24    for i=1,blackkeys,1 do
25        local key = Instance.new("Frame", script.Parent.Piano)
26        key.Size = UDim2.new(
27            1/whitekeys,
28            -15,
29            0,
30            75
31        )
32        key.Position = UDim2.new(
33            (i-1)/blackkeys,
34            0,
35            1,
36            -150
37        )
38        key.BackgroundColor3 = Color3.new(0.2,0.2,0.2)
39        key.BorderColor3 = Color3.new(0,0,0)
40        key.BorderSizePixel = 2
41        key.ZIndex = 3
42        key.Name = "BlackKey"
43    end
44end)
 View all 44 lines...

displaying a piano, how would i calculate where to place the black keys?

Answer this question