Scripting Helpers is winding down operations and is now read-only. More info→

How do I make a single script that manages multiple parts in my game?

Asked by

6 years ago

I have a script that shrinks a part that the player touches. Instead of having to insert the same script in hundreds of different parts (Which creates lag) my goal is to have one single script control all the parts with a certain name (i.e ShrinkingPart) to shrink. This is the script for each part.

01local debounce = true
02local d = script.Parent.Decal
03t = 0.06
04 
05function onTouched(hit)
06if (debounce == true) then
07    debounce = false
08    wait(t)
09    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
10    wait(t)
11    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
12    wait(t)
13    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
14    wait(t)
15    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
16    wait(t)
17    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
18    wait(t)
19    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
20    wait(t)
21    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
22    wait(t)
23    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
24    wait(t)
25    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
26    wait(t)
27    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
28    wait(t)
29    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
30    wait(t)
31    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
32    wait(t)
33    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
34    wait(t)
35    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
36    wait(t)
37    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
38    wait(t)
39    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
40    wait(t)
41    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
42    wait(t)
43    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
44    wait(t)
45    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
46    wait(t)
47    script.Parent.Mesh.Scale = Vector3.new(script.Parent.Mesh.Scale.x-0.05,script.Parent.Mesh.Scale.y,script.Parent.Mesh.Scale.z-0.05)
48 
49    script.Parent.CanCollide = false
50    script.Parent.Transparency = 1
51    d.Parent = nil
52    wait(3)
53    d.Parent = script.Parent
54    script.Parent.CanCollide = true
55    script.Parent.Mesh.Scale = Vector3.new(1,1,1)
56    script.Parent.Transparency = 0
57    debounce = true
58end
59end
60 
61connection = script.Parent.Touched:connect(onTouched)
 View all 61 lines...

1 answer

Answered by

User#19524 175

6 years ago

You’re wrapping your if statement in brackets, and using deprecated code.

And Dude! You don’t need so many lines!! Use a for loop!

01function onTouched(part)
02    mesh = script.Parent.Mesh --use more variables !! 
03 
04    if debounce == true then -- don’t wrap this in brackets!
05        debounce = false
06        for i = 1, .05, -.01 do
07            mesh.Scale = Vector3.new(
08                mesh.Scale.x - .05,
09                mesh.Scale.y,
10                mesh.Scale.y -.05
11                wait(t)
12)
13        end
14 
15        script.Parent.CanCollide = false
16        script.Parent.Transparency = 1
17        d.Parent = nil
18        wait(3)
19        script.Parent.CanCollide = true
20        script.Parent.Mesh.Scale = Vector3.new(1,1,1)
21        script.Parent.Transparency = 0
22        debounce = true
23 
24    end
25end
26 
27script.Parent.Touched:Connect(onTouched)
 View all 27 lines...

Where is there use of deprecated elements? Is there anything inherently wrong with wrapping conditionals in brackets? Also I don't think this actually answers the question being asked..? fredfishy 833 — 6y

In his line 61 code, and wrapping conditionals in brackets errors due to brackets being math exclusive. User#19524 175 — 6y

You should probably point out specifically what's deprecated, rather than just assuming people will notice one character out of 61 lines changing. Also, wrapping conditionals in brackets is valid syntax in Lua: https://i.imgur.com/L68ZHRB.png fredfishy 833 — 6y

How do I make a single script that manages multiple parts in my game?

1 answer

Answer this question