DataStore works fine when only one person is ingame, but changes everyone's values with multiple?

Asked by

Vid_eo 126

6 years ago

This datastore always works with the money, by the way. My issue is that the values in ReplicatedStorage change whenever someone else joins the server, and that replicates to all the clients.

LocalScript inside of Dances folder:

01local loadAnimEvent = game:GetService("ReplicatedStorage"):WaitForChild("Remotes"):WaitForChild("loadAnimEvent")
02 
03loadAnimEvent.OnClientEvent:connect(function(plr)
04    print("dances loadin'")
05    local plr = game.Players.LocalPlayer
06    for i,e in pairs (game.ReplicatedStorage.danceValues:GetChildren()) do
07        if e:IsA("BoolValue") and e.Value == true then
08            print(e)
09            for i,v in pairs (plr.PlayerGui.Dances:GetChildren()) do
10                if v:IsA("TextButton") and v.Name == e.Name then
11                    v:Clone().Parent = plr.PlayerGui.dancesGui.dancesFrame.danceFrame.danceScrolling
12                end
13            end
14        end
15    end
16end)

DataStore script:

01local DataStoreService = game:GetService("DataStoreService")
02local ds = DataStoreService:GetDataStore("danceSave")
03local ds2 = DataStoreService:GetDataStore("MoneySave")
04 
05game:GetService("Players").PlayerAdded:Connect(function(Player) --When the player joins the game, load value.
06 
07    local Stats = Instance.new('Folder')
08    Stats.Name = "leaderstats"
09 
10    local Money = Instance.new('NumberValue', Stats)
11    Money.Name = "Money"
12 
13    Stats.Parent = Player
14 
15 
16    --load data
17    local moneyData;
18    local dancesData;
19 
20    local CanSave = Instance.new('BoolValue', Player)
21 
22    CanSave.Name = "CanSaveData"
23    CanSave.Value = true
24 
25    local DataFetchSuccess, ErrorMessage = pcall(function()
26        moneyData = ds2:GetAsync(tostring(Player.UserId))
27        dancesData = ds:GetAsync(tostring(Player.UserId))
28    end)
29    if DataFetchSuccess then
30        if moneyData ~= nil then --This could be where the problem is
31            print("Money save found")
32            Money.Value = moneyData
33        else
34        print("No money save found.")
35            Money.Value = 0 -- Where money value is changed to 0
36        end
37        --print(Money.Value)
38        print("k")
39        if dancesData ~= nil then
40            print("k")
41            print(dancesData)
42            for i,v in pairs(dancesData) do
43                local Dance = game.ReplicatedStorage.danceValues:FindFirstChild(v)
44                if dancesData then
45                    Dance.Value = true
46                    game.ReplicatedStorage:WaitForChild("Remotes").loadAnimEvent:FireClient(Player)
47                end        
48            end
49        end
50    else
51        Player.CanSaveData.Value = false
52        Player:Kick("Your data failed to load! Please rejoin.")
53    end
54end)
55 
56game:GetService("Players").PlayerRemoving:Connect(function(Player) -- When the player leaves the game, data must save.
57    if Player.CanSaveData.Value == false then return end --There could also be a problem with saving the money
58 
59    local moneyData = Player.leaderstats.Money.Value
60    local dancesToSave = {}
61 
62    print(moneyData)
63    print(dancesToSave)
64 
65    for i,v in pairs (game:GetService("ReplicatedStorage").danceValues:GetChildren()) do
66        if v:IsA("BoolValue") and v.Value == true then
67            table.insert(dancesToSave, v.Name)
68            print(v.Name)
69        end
70    end
71 
72    local DataWriteSuccess, ErrorMessage = pcall(function()
73        print("Saving "..Player.Name.."s stats")
74        ds:SetAsync(tostring(Player.UserId), dancesToSave)
75        print("ok0")
76        ds2:SetAsync(tostring(Player.UserId), moneyData)
77        print("ok")
78    end)
79 
80    if not DataWriteSuccess then
81        local Retry_Count = 0
82 
83        while Retry_Count < 6 do
84            wait(60)
85            local Succeed, Error = pcall(function()
86        print("Attempting to save "..Player.Name.."'s stats.")
87                ds:SetAsync(tostring(Player.UserId), dancesToSave)
88                ds2:SetAsync(tostring(Player.UserId), moneyData)
89            end)
90            if Succeed then print("Saved "..Player.Name.."'s stats") break end
91            Retry_Count = Retry_Count + 1
92        end
93    end
94end)
 View all 94 lines...

Could this be fixed if I replicated the Folder with the dances in ReplicatedStorage to the player whenever the player joins? And then refer to the player instead of ReplicatedStorage?

Thanks.

ReplicatedStorage is "a container whose contents are replicated **to the server and all clients**. If you mean to store and change data to your client (locally), you should try something else. SulaymanArafat 230 — 6y

I suggest you use the same datastore but different keys to store different values. Operation_Meme 890 — 6y

DataStore works fine when only one person is ingame, but changes everyone's values with multiple?

1 answer

Answer this question