Scripting Helpers is winding down operations and is now read-only. More info→

DataStore script won't save GUI Buttons [STILL UNANSWERED]?

Asked by

Vid_eo 126

6 years ago

Edited 6 years ago

I'm trying to make a DataStore script that saves and loads GUI buttons and money; it saves/loads money just fine, but it doesn't save/load the GUI buttons; I think there's a problem with the loading.

SCRIPT:

01local DataStoreService = game:GetService("DataStoreService")
02local ds = DataStoreService:GetDataStore("danceSave")
03local ds2 = DataStoreService:GetDataStore("MoneySave")
04 
05game:GetService("Players").PlayerAdded:Connect(function(Player) --When the player joins the game, load value.
06 
07    local Stats = Instance.new('Folder')
08    Stats.Name = "leaderstats"
09 
10    local Money = Instance.new('NumberValue', Stats)
11    Money.Name = "Money"
12 
13    Stats.Parent = Player
14 
15 
16    --load data
17    local moneyData;
18    local dancesData;
19 
20    local CanSave = Instance.new('BoolValue', Player)
21 
22    CanSave.Name = "CanSaveData"
23    CanSave.Value = true
24 
25    local DataFetchSuccess, ErrorMessage = pcall(function()
26        moneyData = ds2:GetAsync(tostring(Player.UserId))
27        dancesData = ds:GetAsync(tostring(Player.UserId))
28    end)
29    if DataFetchSuccess then
30        if moneyData ~= nil then --This could be where the problem is
31            print("Money save found")
32            Money.Value = moneyData
33        else
34        print("No money save found.")
35            Money.Value = 0 -- Where money value is changed to 0
36        end
37        --print(Money.Value)
38        print("k")
39        if dancesData ~= nil then
40            print("k")
41            for i,v in pairs(dancesData) do
42                print(v)
43                local Dance = Player.PlayerGui.Dances:FindFirstChild(v)
44                if dancesData then
45                    Dance:Clone().Parent = Player.PlayerGui.dancesGui.dancesFrame.danceFrame.danceScrolling
46                end        
47            end
48         print("k")
49        end
50    else
51        Player.CanSaveData.Value = false
52        Player:Kick("Your data failed to load! Please rejoin.")
53    end
54end)
55 
56game:GetService("Players").PlayerRemoving:Connect(function(Player) -- When the player leaves the game, data must save.
57    if Player.CanSaveData.Value == false then return end --There could also be a problem with saving the money
58 
59    local moneyData = Player.leaderstats.Money.Value
60    local dancesToSave = {}
61 
62    print(moneyData)
63    print(dancesToSave)
64 
65    for i,v in pairs (Player.PlayerGui.dancesGui.dancesFrame.danceFrame.danceScrolling:GetChildren()) do
66    print("loop de loop")
67        if v:IsA("TextButton") then
68            table.insert(dancesToSave, v.Name)
69            print(v.Name)
70        end
71    end
72 
73    local DataWriteSuccess, ErrorMessage = pcall(function()
74        print("Saving "..Player.Name.."s stats")
75        ds:SetAsync(tostring(Player.UserId), dancesToSave)
76        print("ok0")
77        ds2:SetAsync(tostring(Player.UserId), moneyData)
78        print("ok")
79    end)
80 
81    if not DataWriteSuccess then
82        local Retry_Count = 0
83 
84        while Retry_Count < 6 do
85            wait(60)
86            local Succeed, Error = pcall(function()
87        print("Attempting to save "..Player.Name.."'s stats.")
88                ds:SetAsync(tostring(Player.UserId), dancesToSave)
89                ds2:SetAsync(tostring(Player.UserId), moneyData)
90            end)
91            if Succeed then print("Saved "..Player.Name.."'s stats") break end
92            Retry_Count = Retry_Count + 1
93        end
94    end
95end)
 View all 95 lines...

There are no errors.

Fun fact: Servers can't/don't see whats in the PlayerGui, Backpack, etc. They really only acknowledge their existence. Async_io 908 — 6y

So how would I use RemoteEvents to get around that? Vid_eo 126 — 6y

Could I use Global Variables to save the table and then add contents to the table in the LocalScript and then save the table in the serverscript? Vid_eo 126 — 6y

nvm, can't use _G. to share between local and server scripts Vid_eo 126 — 6y

If _G replicated and you actually used it on the server, this is a whole separate problem. hiimgoodpack 2009 — 6y

1 answer

Answered by

vanilla_wizard 336

6 years ago

It doesn't save objects. Just save the amount of points that each player has, and then have the GUI display that from the localscript; don't store and clone the objects themselves.

I’m trying to index the names of objects into a table and then displaying those objects as TextButtons. The buttons are not related to the money; they’re like animations. Vid_eo 126 — 6y

You really shouldn't have the server handle GUI. Fire remote events connected to functions in the player's local scripts that tell the player's GUI what to do. vanilla_wizard 336 — 6y

nice LegitimatlyMe 519 — 6y

What if I want the LocalScript to refer to a variable located in the DataStore script? Vid_eo 126 — 6y

View all comments (9 more)

Have the LocalScript send a get request by firing a remote event connected to the server so it can access the DataStore and return the amount of points to the player vanilla_wizard 336 — 6y

I want these GUIs: https://gyazo.com/47f1ee22660f94c4f3005ff407a578ec to move here: https://gyazo.com/fcfe1a78dd8c40233bf979122dcea331. All the variables etc. are correct. The money script works fine. I did this with tools and it also worked well. Vid_eo 126 — 6y

I don't think you're approaching this in a very efficient way. Why not have the GUI elements inside of the GUI and have the code that handles the GUI be inside of the GUI? If it's really necessary for the server to handle that, use remote events. Having DataStore save and load the buttons themselves is unnecessary. Save yourself time by handling the UI on the client. vanilla_wizard 336 — 6y

How would I check to see if players unlocked the GUIs w.out using a datastore?? Vid_eo 126 — 6y

Just use DataStore to save very basic data about the player's achievements (whether a true/false "unlocked" value, an integer "level" or "points", etc). Send that basic data to the client in the GUI over a remote event, and have the GUI handle the GUI from a local script. The local script can have the GUI appear or disappear, but having the server clone it into the player isn't a good idea. vanilla_wizard 336 — 6y

Thanks for your help! I thought about it a bit and decided to use values and then use a RemoteEvent to transfer the GUIs if the values were true, and it worked! Vid_eo 126 — 6y

I actually still have one more issue. I save the Values in ReplicatedStorage and then replicate those values into the player, but I think that that's breaking the DataStore with multiple people. Should I just put the values inside of the Player? Vid_eo 126 — 6y

Never mind, I fixed it! Sorry to bother you Vid_eo 126 — 6y

Never mind, it's still broken, but I'll find a way to fix it Vid_eo 126 — 6y

DataStore script won't save GUI Buttons [STILL UNANSWERED]?

1 answer

Answer this question