Scripting Helpers is winding down operations and is now read-only. More info→

Why does my Random Gift shop script sometimes charge multiple times?

Asked by

Never2Humble 90

7 years ago

Edited 7 years ago

Hello!

I have a random gift shop script. When the Player presses the button, a pop-up purchase menu appears with the Buy button. Once the Buy button is selected, script checks if the player has enough money, if so, it will then begin the random number process, "if between 1 and 10 then" it gives the item. If a player already has the item, it moves on to the next item, this way, no item is awarded twice.

Only problem here is occasionally, it will award, and charge, more than once, per button press. This happens seemingly randomly. I'd rather this not happen. Here is an abbreviated version of the script, which is a Local Script inside a GUI:

01--//Get Services
02local   ReplicatedStorage = game:GetService("ReplicatedStorage")
03local   Players = game:GetService("Players")
04local   Player = Players.localPlayer
05--//EventFolder
06local   Events = ReplicatedStorage:WaitForChild("Events")
07--//Events
08local   UpgradesCoinsPurchase = Events:WaitForChild("UpgradesCoinsPurchase") -- This is the Remote Event which handles the purchases.
09 
10local   currencyCOINS = Player.leaderstats.Coins
11local   CoinsLeaderstats = Player.leaderstats.Coins
12 
13item1_event = nil
14 
15math.randomseed(tick())
16CRATESButton.MouseButton1Click:Connect(function()
17 
18if item1_event then item1_event:disconnect() end
19item1_event = Item1.MouseButton1Click:Connect(function()
20 
21local    Item1Coinsbutton  =  script.Parent.Frame.CRATESFrame.Item1Frame.BuyCoins
22script.Parent.Frame.CRATESFrame.Item1Frame.CoinsPrice.Text  = 100
23Item1Coinsbutton.MouseButton1Click:Connect(function()
24local    amount  = 100
25local    descText  =  script.Parent.Frame.CRATESFrame.Item1Frame.DescriptionFrame.ItemDescription
26local    random  =  math.random(1,200)
27local   debounce = false
28 
29if debounce == false and  Player.leaderstats.Coins.Value >=  amount then
30    debounce = true
31if  random >=  1 and random <=  10 then
32local   Item01 =  Player.Inventory.HasItem01Blue
33if Item01.Value  ==  false then
34UpgradesCoinsPurchase:FireServer(Item01, amount)
35 descText.Text  =  'You received  Item01Blue! Check your Blue Inventory!'
36elseif Item01.Value  ==  true then
37 descText.Text  =  'You received  Item01Blue! You already own this item. Try again!'
38end
39wait(3)
40 
41elseif  random >=  11 and random <=  20 then
42local   Item01 =  Player.Inventory.HasItem01Green
43if Item01.Value  ==  false then
44UpgradesCoinsPurchase:FireServer(Item01, amount)
45 descText.Text  =  'You received  Item01Green! Check your Blue Inventory!'
46elseif Item01.Value  ==  true then
47 descText.Text  =  'You received  Item01Green! You already own this item. Try again!'
48end
49wait(3)
50 
51--etc. etc.
 View all 51 lines...

This is the script for the Remote Event which handles purchases.

01--//Get Services
02local ReplicatedStorage = game:GetService("ReplicatedStorage")
03--//Event
04local Events = ReplicatedStorage:WaitForChild("Events")
05local UpgradesCoinsPurchase = Events:WaitForChild("UpgradesCoinsPurchase")
06 
07UpgradesCoinsPurchase.OnServerEvent:Connect(function(Player, Value, Amount)
08Player.leaderstats.Coins.Value = Player.leaderstats.Coins.Value - Amount --Subtract money from the player
09        print(Value)
10        Value.Value = true
11end)

From the Print of the Value being purchased in the Remote Event script, I can verify multiple items are being purchased/charged. But its random how often it happens. Most of the time it acts as intended and only awards/charges for a single purchase, but I can't have the random chance of it charging multiple times and sending a Player's currency into the negative numbers.

Anyone have any suggestions for how to eliminate the random purchase factor from my random gift script, or if there's a better way to script my random gift giver that also prevents duplicate gifts? ...The irony of a random problem with a random script is not lost on me. :D

2 answers

Answered by

MooMooThalahlah 421

7 years ago

You're missing quite a few ends.

The problem is that you have nested click events. Sometimes they'll trigger once and other times they'll trigger multiple times. To solve your problem reduce the number of click events to one if possible. Or, have them outside of each other.

Please indent next time.

01--//Get Services
02local   ReplicatedStorage = game:GetService("ReplicatedStorage")
03local   Players = game:GetService("Players")
04local   Player = Players.localPlayer
05--//EventFolder
06local   Events = ReplicatedStorage:WaitForChild("Events")
07--//Events
08local   UpgradesCoinsPurchase = Events:WaitForChild("UpgradesCoinsPurchase") -- This is the Remote Event which handles the purchases.
09 
10local   currencyCOINS = Player.leaderstats.Coins
11local   CoinsLeaderstats = Player.leaderstats.Coins
12 
13item1_event = nil
14 
15math.randomseed(tick())
16CRATESButton.MouseButton1Click:Connect(function() -- 1st click event
17    if item1_event then item1_event:disconnect() end
18    item1_event = Item1.MouseButton1Click:Connect(function() -- 2nd click event     
19        local Item1Coinsbutton  =  script.Parent.Frame.CRATESFrame.Item1Frame.BuyCoins
20        script.Parent.Frame.CRATESFrame.Item1Frame.CoinsPrice.Text = 100
21 
22        Item1Coinsbutton.MouseButton1Click:Connect(function() -- 3rd click event
23            local   amount  = 100
24            local   descText  =  script.Parent.Frame.CRATESFrame.Item1Frame.DescriptionFrame.ItemDescription
25            local   random  =  math.random(1,200)
26            local   debounce = false
27 
28            if debounce == false and  Player.leaderstats.Coins.Value >=  amount then
29                debounce = true
30            end -- Missing this end
31 
32            if  random >=  1 and random <=  10 then
33                local   Item01 =  Player.Inventory.HasItem01Blue
34                if not Item01.Value then
35                    UpgradesCoinsPurchase:FireServer(Item01, amount)
36                    descText.Text  =  'You received  Item01Blue! Check your Blue Inventory!'
37                else
38                    descText.Text  =  'You received  Item01Blue! You already own this item. Try again!'
39                end
40                wait(3)
41 
42            elseif  random >=  11 and random <=  20 then
43                local   Item01 =  Player.Inventory.HasItem01Green
44                if not Item01.Value then
45                    UpgradesCoinsPurchase:FireServer(Item01, amount)
46                    descText.Text  =  'You received  Item01Green! Check your Blue Inventory!'
47                else
48                    descText.Text  =  'You received  Item01Green! You already own this item. Try again!'
49                end
50                wait(3)
51            end -- Missing this end
52        end) -- Missing this end
53    end) -- Missing this end
54end) -- Missing this end
55 
56--etc. etc.
 View all 56 lines...

Without looking at how you laid out the GUI I can't help any further.

Thank you for the response! :) I have all the ends in my script proper, I wanted to abbreviate how long the script is for this segment I posted. I'll see what I can do to remove the number of click events. But the way the GUI is laid out the first click button is to open the random Crate menu. The second one is to select which mystery gift (out of thirty) you want which opens the purchase menu, Never2Humble 90 — 7y

- and the third click event is the purchase button itself which triggers all the random code and the purchase. :/ I'll have to sit down and think on the best way to condense it. Never2Humble 90 — 7y

Answered by

Filipalla 504

7 years ago

Changing CRATESButton.MouseButton1Click:Connect(function() to CRATESButton.MouseButton1Down:Connect(function() should do the job since mouse click often fire multiple times a click depending on the length of the click

That's wrong, I tested it (because I was curieus lol) and the event fires the moment you don't click the button anymore, it has nothing to do with the lenght of the click and fires only once User#20388 0 — 7y

if thats not the problem i have no idea Filipalla 504 — 7y

Why does my Random Gift shop script sometimes charge multiple times?

2 answers

Answer this question