Scripting Helpers is winding down operations and is now read-only. More info→

For some reason when ever I chat I die, any ideas?

Asked by

7 years ago

I'm currently making a custom admin script and it was all going well until I realised that everything I said killed me. This is my script:

01local Admins = {"robloxianmirror", "Player", "Player1"}
02local Prefix = "#"
03local Banned = {"Bad_Guy123"}
04 
05--[[
06    "Me" isn't implemented yet however "[Prefix]kill all" will work
07 
08    Current commands:
09        Manual Ban Via script
10        shutdown - Shutsdown the server
11        kill - Kills a player
12        damage - Takes of 10% of a player's health
13--]]
14 
15game.Players.PlayerAdded:connect(function(Player) -- Bans
16    for l, a in pairs(Banned) do
17        if Player.Name == Banned[l] then
18            Player:Kick("You are banned from this game.")
19        end
20    end
21end)
22 
23game.Players.PlayerAdded:connect(function(Player) -- Check for Admin
24    for i, v in pairs (Admins) do
25        if Player.name == Admins[i] then
26            local Location = Player.PlayerGui
27            local Gui = script.ScreenGui:Clone()
28            Gui.Parent = Location
29            Gui.Frame.Text.Text = "Welcome " .. Player.Name .. ", you are an admin!"
30            Gui.Frame:TweenPosition(UDim2.new(0.333, 0 ,0 ,0), "In", "Quad", 0.75)
31            wait(3)
32            Gui.Frame:TweenPosition(UDim2.new(1.2, 0, 0, 0), "Out", "Quad", 0.75)
33            wait(0.75)
34            Gui:Remove()
35            Player.Chatted:connect(function(msg)
36                if msg == Prefix .. "kill all" or Prefix .. "reset all" then
37                    local Players = game.Players:GetPlayers()
38                    for i, v in pairs (Players) do
39                        Players[i].Character.Head:Remove()
40                    end
41                end
42                if string.sub(msg, 1, string.len(Prefix .. "kill ")) == Prefix .. "kill " then
43                    local info = string.sub(msg, string.len(Prefix .. "kill "))
44                    if game.Workspace:FindFirstChild(info) ~= nil then
45                        local Victim = game.Workspace:FindFirstChild(info)
46                        Victim.Head:Remove()
47                    end
48                end
49                if string.sub(msg, 1, string.len(Prefix .. "reset ")) == Prefix .. "reset " then
50                    local info = string.sub(msg, string.len(Prefix .. "reset "))
51                    if game.Workspace:FindFirstChild(info) ~= nil then
52                        local Victim1 = game.Workspace:FindFirstChild(info)
53                        Victim1.Head:Remove()
54                    end
55                end
56                if msg == Prefix .. "shutdown" then
57                    game.Players:ClearAllChildren()
58                    game.Workspace:ClearAllChildren()
59                end
60                if string.sub(msg, 1, string.len(Prefix .. "damage ")) == Prefix .. "damage " then
61                    local info = string.sub(msg, string.len(Prefix .. "damage "))
62                    if game.Workspace:FindFirstChild(info) ~= nil then
63                        local Victim2 = game.Workspace:FindFirstChild(info)
64                        Victim2.Humanoid.Health = Victim2.Humanoid.Health + 10
65                    end
66                end
67            end)
68        end
69    end
70end)
 View all 70 lines...

2 answers

Answered by

UgOsMiLy 1074

7 years ago

This is because you are using the or operator incorrectly.

On line 36, you put: if msg == Prefix .. "kill all" or Prefix .. "reset all" then. That would always be true, no matter what.

The if statement works like this:

If the value between if and then is truthy then it will run the code, otherwise, it won't. The only non-truthy values are false and nil All other values, like strings, tables functions, (even if they are empty, or the number is 0) are truthy

msg == Prefix.. "kill all" - that is fine, due to the fact that if msg wasn't the prefix followed by "kill all", the value will be false, which is a non-truthy value, so it will work as expected. "#reset all" is always a truthy value because it's a string, and since you didn't put msg == in front of it, it doesn't evaluate whether msg is #reset all, which would return true or false, it would just read the truthy string value and decide that since it's neither false nor nil, it executes the code.

The short answer is that you have to put "msg ==" every time.

1if msg == Prefix .. "kill all" or msg == Prefix .. "reset all" then
2    -- code
3end

Also, my 100th answer! Hooray!

Thanks, I kind of rushed it. That's probably why. robloxianmirror 57 — 7y

Answered by

JamiethegreatQ777 16

7 years ago

Friend Me On Roblox And We Can Work Out Together About This Lua Problem

I'd rather not, sorry. robloxianmirror 57 — 7y

For some reason when ever I chat I die, any ideas?

2 answers

Answer this question