Scripting Helpers is winding down operations and is now read-only. More info→

Why does custom Player List display not display everyone's stats, just the player's?

Asked by

Never2Humble 90

7 years ago

Hello!

I have a custom PlayerList. It adds players as they enter, removes them as they leave. It displays the player's avatar image, their name, their kills, and their kill streak. Unfortunately, it shows your kills/killstreaks for everyone, instead of displaying their unique kills/killstreaks.

How do I correct this to show each player's unique stats? The Name/Avatar Image shows the correct thing for each unique player, its just the stats from the Leaderstats that only show your info instead of each player's. I'm betting I've overlooked something simple here. ><

Not receiving any errors. Do I need to use WaitForChild() somewhere? If so, where?

Screen Gui - LocalScript:

01game.StarterGui:SetCoreGuiEnabled("PlayerList", false)
02local plr = game.Players.LocalPlayer
03local kills = plr.leaderstats.Kills.Value
04local killstreak = plr.leaderstats.Killstreak.Value
05local Avatarurl = "http://www.roblox.com/Thumbs/Avatar.ashx?x=500&y=500&Format=Png&username="
06 
07while wait(1) do
08    for _,plr in pairs (game.Players:GetChildren()) do
09        if script.Parent.Holder:FindFirstChild(plr.Name) then
10 
11        else
12            I = Instance.new("Frame")
13            I.Name = plr.Name
14            I.Parent = script.Parent.Holder
15            I.Style = "DropShadow"
16 
17-- NAME         
18            T = Instance.new("TextLabel")
19            T.BackgroundTransparency = 1
20            T.Text = plr.Name
21            T.Parent = I
22            T.Size = UDim2.new(0, 165, 0, 35)
23            T.Position = UDim2.new(0, 10, 0, 0)
24            if plr.Name == game.Players.LocalPlayer.Name then
25                T.TextColor3 = Color3.fromRGB(0, 200, 255)
26                else
27            T.TextColor3 = Color3.new(1, 1, 1)
28            end
29            T.TextStrokeColor3 = Color3.new(0, 0, 0)
30            T.TextStrokeTransparency = 0.5
31            T.TextXAlignment = "Left"
32            T.Font = "SourceSansBold"
33            T.TextSize = 20
34 
35-- KILLS            
36            K = Instance.new("TextLabel")
37            K.BackgroundTransparency = 1
38            K.Text = kills
39            K.Parent = I
40            K.Size = UDim2.new(0, 165, 0, 35)
41            K.Position = UDim2.new(0, 12, 0, 0)
42            K.TextColor3 = Color3.new(1, 1, 1)
43                K.TextStrokeColor3 =  Color3.new(0, 0, 0)
44                K.TextStrokeTransparency = 0.5
45                K.TextXAlignment = "Right"
46                K.Font = "SourceSansBold"
47                K.TextSize = 20
48 
49-- KILL STREAK
50            KS = Instance.new("TextLabel")
51            KS.BackgroundTransparency = 1
52            KS.Text = killstreak
53            KS.Parent = T
54            KS.Size = UDim2.new(0, 165, 0, 35)
55            KS.Position = UDim2.new(0, 21, 0, 0)
56            KS.TextColor3 = Color3.new(255,0,0)
57                KS.TextStrokeColor3 =  Color3.new(0, 0, 0)
58                KS.TextStrokeTransparency = 0.5
59                KS.TextXAlignment = "Right"
60                KS.Font = "SourceSansBold"
61                KS.TextSize = 20
62 
63 
64-- AVATAR IMAGE 
65            P = Instance.new("ImageLabel")
66            P.BackgroundTransparency = 1
67            P.Image = Avatarurl..plr.Name
68            P.Parent = T
69            P.Size = UDim2.new(1.25,0,1.25,0)
70            P.Position = UDim2.new(-1, 0, 0, 0)
71 
72end
73end
74end
 View all 74 lines...

And then the Screen Gui - Script:

1function playerleft(player)
2    if script.Parent.Holder:FindFirstChild(player.Name) then
3        script.Parent.Holder:FindFirstChild(player.Name):remove()
4    end
5end
6game.Players.ChildRemoved:connect(playerleft)

Screenshots: This one shows how the custom player list appears in the game where the Avatar/Name is unique, but the Kills/Streak is cloned: https://ibb.co/h2QrtS

This one shows how the ScreenGui appears in PlayerGui during game play: https://ibb.co/b7dcYS

Not sure how you'd change it to use the other players ones, but from what I can see it looks like you're using the localplayer's stats for every kill/streak. TairaAkiko 26 — 7y

:/ you're right. I'm just unsure how to get the other player's stats too. Never2Humble 90 — 7y

1 answer

Answered by

CodinGlitch 36

7 years ago

the problem is your using the stats for the same player, how you would fix this is getting the stats for each player as you loop through them.

https://gyazo.com/011f344c332a36b8b0c47a9d8b82b996

heres the fixed script:

01game.StarterGui:SetCoreGuiEnabled("PlayerList", false)
02local plr = game.Players.LocalPlayer
03local kills = plr.leaderstats.Kills.Value
04local killstreak = plr.leaderstats.Killstreak.Value
05local Avatarurl = "http://www.roblox.com/Thumbs/Avatar.ashx?x=500&y=500&Format=Png&username="
06 
07while wait(1) do
08    for _,plr in pairs (game.Players:GetChildren()) do
09        if script.Parent.Holder:FindFirstChild(plr.Name) then
10 
11        else
12            local kills2 = plr.leaderstats.Kills.Value
13            local killstreak2 = plr.leaderstats.Killstreak.Value
14            I = Instance.new("Frame")
15            I.Name = plr.Name
16            I.Parent = script.Parent.Holder
17            I.Style = "DropShadow"
18 
19-- NAME         
20            T = Instance.new("TextLabel")
21            T.BackgroundTransparency = 1
22            T.Text = plr.Name
23            T.Parent = I
24            T.Size = UDim2.new(0, 165, 0, 35)
25            T.Position = UDim2.new(0, 10, 0, 0)
26            if plr.Name == game.Players.LocalPlayer.Name then
27                T.TextColor3 = Color3.fromRGB(0, 200, 255)
28                else
29            T.TextColor3 = Color3.new(1, 1, 1)
30            end
31            T.TextStrokeColor3 = Color3.new(0, 0, 0)
32            T.TextStrokeTransparency = 0.5
33            T.TextXAlignment = "Left"
34            T.Font = "SourceSansBold"
35            T.TextSize = 20
36 
37-- KILLS            
38            K = Instance.new("TextLabel")
39            K.BackgroundTransparency = 1
40            K.Text = kills2
41            K.Parent = I
42            K.Size = UDim2.new(0, 165, 0, 35)
43            K.Position = UDim2.new(0, 12, 0, 0)
44            K.TextColor3 = Color3.new(1, 1, 1)
45                K.TextStrokeColor3 =  Color3.new(0, 0, 0)
46                K.TextStrokeTransparency = 0.5
47                K.TextXAlignment = "Right"
48                K.Font = "SourceSansBold"
49                K.TextSize = 20
50 
51-- KILL STREAK
52            KS = Instance.new("TextLabel")
53            KS.BackgroundTransparency = 1
54            KS.Text = killstreak2
55            KS.Parent = T
56            KS.Size = UDim2.new(0, 165, 0, 35)
57            KS.Position = UDim2.new(0, 21, 0, 0)
58            KS.TextColor3 = Color3.new(255,0,0)
59                KS.TextStrokeColor3 =  Color3.new(0, 0, 0)
60                KS.TextStrokeTransparency = 0.5
61                KS.TextXAlignment = "Right"
62                KS.Font = "SourceSansBold"
63                KS.TextSize = 20
64 
65 
66-- AVATAR IMAGE 
67            P = Instance.new("ImageLabel")
68            P.BackgroundTransparency = 1
69            P.Image = Avatarurl..plr.Name
70            P.Parent = T
71            P.Size = UDim2.new(1.25,0,1.25,0)
72            P.Position = UDim2.new(-1, 0, 0, 0)
73 
74end
75end
76end
 View all 76 lines...

It worked perfectly!! Thank you!! :)! Never2Humble 90 — 7y

Why does custom Player List display not display everyone's stats, just the player's?

1 answer

Answer this question