Scripting Helpers is winding down operations and is now read-only. More info→

How to prevent my datastore script from giving an Error?

Asked by

Timmerman73 85

7 years ago

Edited 7 years ago

I have a script that saves Money from Players so they keep it the next time they join but it gives an error and I dont know how to fix it. Here is my script:

01local DSService = game:GetService('DataStoreService'):GetDataStore('Hamburger223232')
02game.Players.PlayerAdded:connect(function(plr)
03    -- Define variables
04    print('waiting until tycoonscript ready')
05    wait(6)
06    print('Starting')
07    local uniquekey = 'id-'..plr.userId
08    local leaderstats = Instance.new('IntValue', plr)
09    local Moneystorage = game.ServerStorage:FindFirstChild('PlayerMoney')
10    local PlayerMoney = Moneystorage:FindFirstChild(plr.Name)
11    local savevalue =  PlayerMoney
12    --leaderstats.Name = 'leaderstats'
13    --savevalue.Parent = leaderstats
14    --savevalue.Name = 'Cash'
15 
16    -- GetAsync
17    local GetSaved = DSService:GetAsync(uniquekey)
18    if GetSaved then
19        savevalue.Value = GetSaved[1]
20    else
21        local NumbersForSaving = {savevalue.Value}
22        DSService:SetAsync(uniquekey, NumbersForSaving)
23    end
24end)
25 
26game.Players.PlayerRemoving:connect(function(plr)
27    local Moneystorage = game.ServerStorage:FindFirstChild('PlayerMoney')
28    local PlayerMoney = Moneystorage:FindFirstChild(plr.Name)
29    local savevalue =  PlayerMoney
30local uniquekey = 'id-'..plr.userId
31local Savetable = {savevalue.Value}
32DSService:SetAsync(uniquekey, Savetable)        
33end)
 View all 33 lines...

When i test it with an alt in game this is what shows in the output. ServerScriptService.Save Service :19: attempt to index local 'savevalue' (a number value)

If anybody could help that would be amazing '

2 answers

Answered by

User#20279 0

7 years ago

Edited 7 years ago

I think you’re trying to get the object of the value but not the value itself, which people make mistakes on a lot.

On line 11, change PlayerMoney into PlayerMoney.Value. It’d be like this :

`1`	`local` `savevalue` `=` `PlayerMoney.Value`

It works now Thanks for your help. Timmerman73 85 — 7y

Answered by

1TheNoobestNoob 717

7 years ago

You should still wrap your data saving and loading in an error handler to make sure your script doesn’t error and stop working because it failed to save/load

You can use

Pcall for instance

1pcall(function()
2 
3end)

How to prevent my datastore script from giving an Error?

2 answers

Answer this question