Datastore won't work, and I have no idea why at all? [Solved] [closed]

Asked by

7 years ago

Edited by OldPalHappy 7 years ago

Here is the whole code which is in one script:

001local DataStoreService = game:GetService("DataStoreService")
002local Stats = DataStoreService:GetDataStore("Stats")
003 
004game.Players.PlayerAdded:connect(function(player)
005 
006    -- get parts for system
007    local info = Instance.new("StringValue", game.Workspace.Player_Information)
008    info.Name = player.Name
009 
010    -- set up other parts
011    Instance.new("StringValue",info).Name = "Inventory"
012    Instance.new("StringValue", info.Inventory).Name = "Gloves"
013    Instance.new("IntValue", info).Name = "Box_Bux"
014    Instance.new("StringValue", info).Name = "Wearing"
015    Instance.new("StringValue", info.Wearing).Name = "Gloves"
016 
017 
018    local can_save = Instance.new("BoolValue", info)
019    can_save.Name = "Can_Save"
020    can_save.Value = true
021 
022    local stats = game.Lighting.Stats:Clone()
023    stats.Parent = info
024 
025    -- load data table
026    local success, message = pcall(function()
027        stat_table = Stats:GetAsync(player.UserId)
028    end)
029 
030 
031    if success then
032        if stat_table ~= nil then
033 
034            print(stat_table["Gloves_Inventory"])
035            print(stat_table["Fitness"])
036 
037            stats.Strength.Value = stat_table.Strength
038 
039            stats.Fitness.Value = stat_table.Fitness
040 
041            stats.Endurance.Value = stat_table.Endurance
042 
043            stats.Speed.Value = stat_table.Speed
044 
045            if stat_table.Box_Bux ~= nil then
046                print("loaded properly")
047 
048                info.Box_Bux.Value = stat_table.Box_Bux
049 
050                -- load gloves in inventory
051                local gloves_in_inv = stat_table.Gloves_Inventory
052                local rounds = string.len(gloves_in_inv)/4
053                for i = 1, rounds do
054                    Instance.new("StringValue", info.Inventory.Gloves).Name = string.sub(gloves_in_inv, 1 + ((i - 1)*4), 4 + ((i - 1)*4))
055                end
056 
057                Instance.new("StringValue", info.Wearing.Gloves).Name = stat_table.Glove_Wearing
058 
059            else
060                print("dis route")
061                info.Box_Bux.Value = 0
062                Instance.new("StringValue", info.Wearing.Gloves).Name = "G001"
063                Instance.new("StringValue", info.Inventory.Gloves).Name = "G001"
064            end
065 
066        else
067            print("dis 1")
068            stats.Strength.Value = 0
069 
070            stats.Fitness.Value = 0
071 
072            stats.Endurance.Value = 0
073 
074            stats.Speed.Value = 0
075 
076            info.Box_Bux.Value = 0
077            Instance.new("StringValue", info.Wearing.Gloves).Name = "G001"
078            Instance.new("StringValue", info.Inventory.Gloves).Name = "G001"
079        end
080    else
081        can_save.Value = false
082        player:Kick("Your data hasn't loaded correctly, but you haven't lost any data! Please simply rejoin the game!")
083    end
084end)
085 
086game.Players.PlayerRemoving:connect(function(player)
087    local player_folder = game.Workspace.Player_Information:FindFirstChild(player.Name)
088 
089    if player_folder.Can_Save.Value == true then
090        print("saving")     
091 
092        -- strength 
093        local strength = player_folder.Stats.Strength.Value
094 
095        -- fitness
096        local fitness = player_folder.Stats.Fitness.Value
097 
098        -- endurance
099        local endurance = player_folder.Stats.Endurance.Value
100 
101        -- speed
102        local speed = player_folder.Stats.Speed.Value
103 
104        -- gloves in inventory
105        local gloves_inv = player_folder.Inventory.Gloves:GetChildren()
106        local gloves_owned = {}
107        for i = 1, #gloves_inv do
108            gloves_owned[i] = gloves_inv[i].Name
109        end
110 
111        -- gloves wearing
112        local gloves_wear = player_folder.Wearing.Gloves:GetChildren()
113        local gloves_wearing = {}
114        for i = 1, #gloves_inv do
115            gloves_wearing[i] = gloves_wear[i].Name
116        end
117 
118        local data_table = {
119            ["Strength"] = strength,
120            ["Fitness"] = fitness,
121            ["Endurance"] = endurance,
122            ["Speed"] = speed,
123            ["Gloves_Inventory"] = table.concat(gloves_owned, ""),
124            ["Glove_Wearing"] = table.concat(gloves_wearing, ""),
125            ["Box_Bux"] = player_folder.Box_Bux.Value
126        }
127 
128        print(data_table["Gloves_Inventory"])
129        print(data_table["Fitness"])
130 
131        Stats:SetAsync(player.UserId, data_table)
132    end
133 
134    game.Workspace.Player_Information:FindFirstChild(player.Name):Remove()
135end)
 View all 135 lines...

Essentially the code is saving player stats, and clothing etc which is all held in objects in the workspace in a player file. (a folder). I don't think there's anything wrong particularly with what I'm saving, It seems to be how it is saving. When I play the game it's so inconstant with saving, when I play on my own, and then leave, it just doesn't save at all. It saved in 2 player test mode however, so I'm not sure what the issue is. I also added in a script with the bind to close function and a wait of 10, however this appeared to change nothing. I'm not sure how to fix this as there are no errors, and people's data gets seemingly randomly reset.

I have read a few other posts, and I'll attempt moving the script from workspace to ServerScriptService, and I'll try using bind to close again. Iegoadz 5 — 7y

Do not use workspace / lighting for storage use server storage. 2nd Do not use Remove it is deprecated. 3rd do not kick the player if the data fails to load retry instead with a small delay. User#5423 17 — 7y

Line 107 and 114 use #gloves_inv User#5423 17 — 7y

ah! that was why it wasn't working at all! mustve been giving an error as the for loop was running too many or too few times. I will take your advice too, thank you very much, you have saved me hours of crying lol. Iegoadz 5 — 7y

Yeah listen to Kingdom he helped write my Data Store, lets just say he is the Data Store master. GottaHaveAFunTime 218 — 7y

Locked by cabbler, Vulkarin, and MessorAdmin

This question has been locked to preserve its current state and prevent spam and unwanted comments and answers.

Why was this question closed?

Datastore won't work, and I have no idea why at all? [Solved] [closed]

Locked by cabbler, Vulkarin, and MessorAdmin

1 answer