Scripting Helpers is winding down operations and is now read-only. More info→

How to make GUI which pops up on touch, filtering enabled?

Asked by

BADABOO2016 3

7 years ago

I am trying to make it so when the player touches this brick, a GUI is cloned and pops-up on the clients screen, and with that he can purchase a car and it will spawn in a designated area. When I try it in studio, it works fine, but in game it does not respond. The GUI (called SpawnGUI) will open, however none of the scrolling buttons nor the buy button works.

I have posted a copy of the script below. I am not used to filtering enabled, so I am not sure how to use remote events or remove functions. The player must click the buy button, which takes away 50 "Money" from the leaderstats and places the vehicle desired (all vehicles located in ServerStorage) in a specific place where all the cars will spawn.

Script for spawning GUI

01script.Parent.Touched:connect(function(p)
02    local player = game.Players:GetPlayerFromCharacter(p.Parent)
03    if (player) then
04        if (not player.PlayerGui:FindFirstChild("SpawnGUI")) then
05            local GUI = game:GetService("ServerStorage").SpawnGUI:Clone()
06            GUI.Regen.Value = script.Parent.Parent.Pos
07            GUI.Parent = player.PlayerGui
08        end
09    end
10end)
11 
12local s = 0
13while wait(0.1) do
14    s = (s + 2) % 360
15    script.Parent.UI.StudsOffset = Vector3.new(0,5 + math.sin(math.rad(s)),0)
16end

Script for giving car:

01local P = script.Parent
02local player = P.Parent.Parent
03local index = 1
04 
05local vehicles = {
06 
07    {"Toyota Corolla 2010"  , 0}, 
08    {"Smart Fortwo" , 0},
09    {"Sudiko Green Yoga"    , 0},
10    {"Sudiko Blue Yoga" , 0},
11    {"Toyota Prius 2010"    , 0},
12    {"BMW i3"   , 0},
13    {"TCI"  , 0},
14    {"Toyota Prius 2016"        , 0}
15}
16 
17wait(0.5)
18-- GUI vars
19local bg = P.BG
20 
21-- Helper function
22function SetInformation(index)
23    bg.I.Image = "http://www.roblox.com/thumbs/asset.ashx?assetId="..vehicles[index][2].."&x=420&y=420"
24    bg.T.Text = vehicles[index][1]
25end
26 
27local locked = false
28bg.S.MouseButton1Click:connect(function()
29    local Money = player.leaderstats:FindFirstChild("Money")
30    if Money.Value > 50 then
31        Money.Value = Money.Value - 50
32 
33    if (locked) then return end
34    locked = true
35    local vehicleName = player.Name.."Car"
36    local model = workspace:FindFirstChild(vehicleName)
37    if (model) then model:Destroy() end
38    model = game.ServerStorage.Vehicles:FindFirstChild(vehicles[index][1]):Clone()
39    model.Name = vehicleName
40    model.Parent = game.Workspace
41    model:MakeJoints()
42    model:MoveTo(P.Regen.Value.Position)
43    P:Destroy()
44    locked = false 
45 
46    else
47        script.Parent.BG.S.Text = "Not Enough Money, 50 Needed!"
48        wait(3)
49        script.Parent.BG.S.Text = "Spawn"
50    end
51end)
52 
53bg.B.MouseButton1Click:connect(function()
54    index = index - 1
55    if (index < 1) then index = #vehicles end
56    SetInformation(index)
57end)
58 
59bg.N.MouseButton1Click:connect(function()
60    index = index + 1
61    if (index > #vehicles) then index = 1 end
62    SetInformation(index)
63end)
64 
65bg.Q.MouseButton1Click:connect(function()
66    P:Destroy()
67end)
68 
69SetInformation(index)
 View all 69 lines...

Please help me find a solution that it will work with filtering enabled, and please describe in detail the steps needed. Thankyou!

well, does the Dev Console tell anything whilst playing the game? User#19492 0 — 7y

Nope. All it says is the meshes failed to load BADABOO2016 3 — 7y

Make the second script a LocalScript thesit123 509 — 7y

The second script being a localscript would be bad. That would make it so that the car only shows up on the player's system, so other players would not notice it. Kato12345 17 — 7y

View all comments (3 more)

Then what should I do? BADABOO2016 3 — 7y

Just dump the Touched function in the client. much easier. no server communication needed. RubenKan 3615 — 7y

And how would I do that? Remember im a beginner BADABOO2016 3 — 7y

1 answer

Answered by

chess123mate 5873

7 years ago

Edited 7 years ago

Make sure you read/understand this: https://scriptinghelpers.org/guides/server-client-relationship-in-roblox

The problem is that your car-giver script is trying to do both server-related activities (generating a car, which you want everyone to be able to see/interact with) and client-related activities (GUI, which you only want to show up for one player). The GUI events aren't even replicated from the client to the server, which is why those MouseButton events aren't firing. You need to move all that GUI code into a LocalScript and then let the server know when the player has requested the purchase of a vehicle using either a RemoteEvent or a RemoteFunction.

Most of your code will either be in one script or another, but when it comes to making sure the player has enough money, you ideally check it in both. The server should check it because you should never trust the client (an exploiter can activate RemoteEvents/Functions with any arguments they want), and you the client should check it to prevent unnecessary communication with the server and lag time (why ask the server to check if the player can afford it, which may take half second, when they could be notified immediately if the client checks first?)

[Edit - Response to comments]

Either Remote Function or event? Is one more preferable?

You can read up on the differences in the API for RemoteEvents and RemoteFunctions, but the essentially you use an Event when you want 1-way communication (ex server telling client that they've been given something) and a Function when you want 2-way (ex client asking server to purchase a vehicle - the server could then respond with whether the purchase was successful)

Like what script do I put in the Remote event/function and how do I fire it

You can put them anywhere you want (except in client-only and server-only areas, like ServerStorage, in a player's GUI, etc), just keep it organized. Putting them in ReplicatedStorage, possibly in a folder, or as a child of the script that handles them are perfectly reasonable. To fire it, you should look at the links above - the API tells you what functions are available. Also, for examples, they have this tutorial: http://wiki.roblox.com/index.php?title=Remote_Events_and_Functions

Either Remote Function or event? Is one more preferable? Also, I have transferred all the data to a local script. How do I "fire" the remote event/function? Insert a script or something? BADABOO2016 3 — 7y

Like what script do I put in the Remote event/function and how do I fire it BADABOO2016 3 — 7y

Ok so had read the guide you posted and understand that now the client cannot make changes to the server. I get it, but how do I fire the remove event/function? Please? BADABOO2016 3 — 7y

I have responded in the answer chess123mate 5873 — 7y

View all comments (7 more)

Ok so your line on remote events and functions doesnt work. I have looked at the wiki but Im not trying to create a part. So basicly, I should create a remote function in the workspace and add a script to it. But what do I put in the script? I dont get it. Also, what do I put in the GUI script so it knows to fire the remote function? BADABOO2016 3 — 7y

Also, if you want to try it out or something the model is "Car Spawner" by dshorter100 BADABOO2016 3 — 7y

"your line on remote events and functions doesnt work" - what? "I have looked at the wiki but Im not trying to create a part." - replace the part where it makes a part with whatever you want it to do. The wiki gives you an example to learn from so you can apply it to your situation. (And, sorry, not up to looking at that model at this time.) chess123mate 5873 — 7y

Thats the thing I do not know what to put. Im really new. Could you clarify what to put in the Remotefunction & the GUI script so the remote event can be fire for a GUI? BADABOO2016 3 — 7y

Please, this would be a HUGE help me to me :) This is the last major thing I am stumped on. Please help me :) BADABOO2016 3 — 7y

Please instruct me on what scripts to put. I know I am repeating myself but you dont not understand how helpful this would be to me bro. :)) Like the first question I posted BADABOO2016 3 — 7y

Please? BADABOO2016 3 — 7y

How to make GUI which pops up on touch, filtering enabled?

1 answer

Answer this question