This script has multiple errors not in output and I don't know why?
This code is supposed to make a brick spawn every 10 seconds on a brick spawner (which it is parented under), with a slight chance of being a golden brick, and the brick is given an IntValue. Past bricks are supposed to be deleted.
The two problems I faced:
Multiple bricks spawn at a time
Past bricks are not deleted
Code:
01 | while wait(10) do |
02 | for i,v in pairs(script.Parent:GetChildren())do |
03 | if v.Name == "Brick" then |
04 | v:Destroy() |
05 | else |
06 | bval = math.random(1,100) |
07 | if bval <= 99 then |
08 | brick = Instance.new("Part", script.Parent) |
09 | brick.Position = script.Parent.Position |
10 | brick.Size = Vector3.new(2,0.5,1) |
11 | brickval = Instance.new("IntValue") |
12 | brickval.Value = 1 |
13 | elseif bval == 100 then |
14 | brick = Instance.new("Part", script.Parent) |
15 | brick.Position = script.Parent.Position |
For the aftermath, the game can be visited here.
1
0
0
1 answer
(I see you already figured it out, but) the way I'd do it is:
01 | local brick, brickval, bval |
02 | while wait(10) do |
03 | if brick then brick:Destroy() end -- Destroy the old part (if any) |
04 | -- Make a new one |
05 | brick = Instance.new("Part") |
06 | brick.Size = Vector3.new(2,0.5,1) |
07 | brick.Position = script.Parent.Position |
08 | brickval = Instance.new("IntValue") |
09 | bval = math.random(1, 100) |
10 | if bval <= 99 then -- Normal |
11 | brickval.Value = 1 |
12 | else -- Golden |
13 | brick.BrickColor = BrickColor.new("New Yeller") |
14 | brickval.Value = 25 |
15 | local sparkles = Instance.new("Sparkles") |
16 | sparkles.Parent = brick |
17 | end |
18 | brickval.Parent = brick |
19 | brick.Parent = script.Parent |
20 | end |
Do note that Instance.new(part, parent) is deprecated - you're supposed to do .Parent after you've changed the other properties (especially Size and Position, which cause a bit of unnecessary lag if the part is already in the Workspace). This isn't a concern when you're only making 1 part every 10 seconds, but it's good practice nonetheless.
I changed the structure a bit so that the common code is outside the if block; you can see exactly what makes a brick normal/golden.