Scripting Helpers is winding down operations and is now read-only. More info→

This script checks for banned text but it always returns false?

Asked by

SebbyTheGODKid 198

7 years ago

Edited 7 years ago

EDIT: It turns out it only DOESN'T work if the text contains spaces

I am making a SB game, and for the script executor it has a function that checks for banned functions. It doesn't seem to work. Could anyone help me?

01-- List
02local banned = {
03    "TeleportService",
04    "Teleport Service",
05    "PlayerGui",
06    "Players",
07    "Lighting",
08    "loadstring",
09    "StarterGui",
10    "FireServer",
11    "InvokeServer",
12    "Invoke",
13    "Fire"
14}
15 
16-- Function
17checkIfBanned = function(text)
18    for i=1,#banned do
19        if string.find(string.lower(text),string.lower(banned[i])) ~= nil then
20            warn('__Error: Code contains banned text')
21            return true
22        else
23            warn('Code safe...')
24            return false
25        end
26    end
27end
28 
29-- Test call
30print(checkIfBanned("Teleport Service")) -- Always prints "false" and I don't know why.
 View all 30 lines...

It's probably something obvious and I'm just stupid. Any help would be appreciated.

You know your loop will only ever run once, right? If the condition is true, it returns true from the function, else it returns false from the function. You probably want to just return false after the loop. GoldenPhysics 474 — 7y

1 answer

Answered by

fuj 49

7 years ago

consider removing the "return false", the loop will only run once since when you return inside a function it ends any current loops in that thread.

I assume it would be fine to return true when there's an unauthorized functon or service being called / indexed because you don't want them to do it anyway. fuj 49 — 7y

This script checks for banned text but it always returns false?

1 answer

Answer this question