Scripting Helpers is winding down operations and is now read-only. More info→

if Players.Health 1+ then Wins.Value = +1 isn't working?

Asked by

7 years ago

I'm very stuck on this script, a little help would be nice! What I'm trying to do is so if the player "Survived" the waves, then they get +1 win on the leaderboard script and if they didn't nothing happens.

Round Script in SSS

01local replicatedstorage = game:GetService("ReplicatedStorage")
02local status = replicatedstorage:WaitForChild("StatusValue")
03local Players = game.Players
04local Health = game.Players.Humanoid.Health
05 
06while true do
07for i = 15,1,-1 do
08status.Value = "Intermission: "..i 
09wait(1)
10end
11status.Value = "Game in progress"
12local map = game.ServerStorage.BaseMap
13map:Clone().Parent = game.Workspace
14target = CFrame.new(67.98, -47.816, 1156.752)
15for i, player in ipairs(game.Players:GetChildren()) do
16  player.Character.Torso.CFrame = target + Vector3.new(0, i * 5, 0)
17wait(45)
18 
19if Players.Health 1+ then Wins.Value = +1
20target = CFrame.new(37.095, 103.76, 1214.745)
21for i, player in ipairs(game.Players:GetChildren()) do
22  player.Character.Torso.CFrame = target + Vector3.new(0, i * 5, 0)
23 
24game.Workspace.BaseMap:Destroy()
25 
26status.Value = "Game Over!"
27 
28            end
29        end
30    end
 View all 30 lines...

Leaderboard Script :

01function CreateStats(NewPlayer)
02    local MainStats = Instance.new("IntValue")
03    MainStats.Name = "leaderstats"
04    MainStats.Value = 0
05    local PointsValue = Instance.new("IntValue")
06    PointsValue.Name = "Wins"
07    PointsValue.Value = 0
08    PointsValue.Parent = MainStats
09    MainStats.Parent = NewPlayer
10    return MainStats
11end
12 
13game.Players.ChildAdded:connect(CreateStats)

Well, I think you've got your health stuff wrong, I believe you need to get the players character, then its humanoid, and then just check if humanoid.Health > 0 NodaDuck45 15 — 7y

Can you give me an example? I'm new to humanoid stuff. devconstruct 4 — 7y

CAN SOMEONE JUST EDIT THE SCRIPT AND REPOST IT PLEASE? devconstruct 4 — 7y

Even if you fixed the script as intended, players who respawn and still have health > 1 will get a point. I'd recommend first creating a flag to mark dead players and then make the system just reward anyone who isn't marked by the time the waves end zanyder 1 — 7y

3 answers

Answered by

SuperAndresZ_YT 202

7 years ago

Edited 7 years ago

This is my solution, I think it works! Hope you like it!

Okay, Here is the Round Script:

(NOTE: I think the Round Script can be a ServerScript (normal script) and be in workspace and work totally fine!)

01local replicatedstorage = game:GetService("ReplicatedStorage")
02local status = replicatedstorage:WaitForChild("StatusValue")
03local Players = nil
04local target = nil
05 
06while true do
07    for i = 15,1,-1 do
08        status.Value = "Intermission: "..i 
09        wait(1)
10    end
11    status.Value = "Game in progress"
12 
13    local map = game.ServerStorage.BaseMap:Clone()
14    map.Parent = workspace
15 
16    target = Vector3.new(67.98, -47.816, 1156.752)
17 
18    Players = game.Players:GetChildren()
19    for i, player in pairs(Players) do
20        player.Character:MoveTo(target + Vector3.new(0, i * 5, 0))
21    end
22 
23    wait(45)
24 
25    for i, player in pairs(Players) do
26        local Wins = player:FindFirstChild("leaderstats"):FindFirstChild("Wins")
27 
28        if player.Character.Humanoid.Health > 0 then
29            Wins.Value = Wins.Value + 1
30        end
31 
32        target = Vector3.new(37.095, 103.76, 1214.745)
33        player.Character:MoveTo(target + Vector3.new(0, i * 5, 0))
34 
35        workspace.BaseMap:Destroy()
36 
37        status.Value = "Game Over!"
38    end
39 
40end
 View all 40 lines...

And here is the LeaderStats script: (NOTE: This script MUST be a LocalScript in StarterPlayer > StarterPlayerScripts in order for it to WORK.)

1local LeaderStats = Instance.new("Model", game.Players.LocalPlayer)
2LeaderStats.Name = "leaderstats"
3 
4local Wins = Instance.new("IntValue", LeaderStats)
5Wins.Name = "Wins"
6Wins.Value = 0

Answered by

Impacthills 223

7 years ago

Edited 7 years ago

This line is your problem.

`1`	`if` `Players.Health` `1+` `then` `Wins.Value` `=` `+1`

Change to this.

`1`	`if` `Players.Health >` `0` `then` `Wins.Value` `=` `Wins.Value +` `1`

You should look at lua tutorials. It will help you way more than asking for the answer. Programming is repetitive problem solving

"Wins" is unknown, how can I connect the two scripts? devconstruct 4 — 7y

And also another problem, they shouldn't get a win if there in the lobby, they need to be in the base map to get a win, e.e devconstruct 4 — 7y

Wins isn't a script.. It's an object with a data type of Int. You meed to create a referencek to where you have your Wins object. Sorry I cannot spoon feed. This isn't a request forum. Impacthills 223 — 7y

Looks like your Wins object will be at 'player.leaderstats.Wins' you can figure the rest out. Impacthills 223 — 7y

Answered by

devconstruct 4

7 years ago

Edited 7 years ago

@imp here's my progress :

01-- Vairbles
02local replicatedstorage = game:GetService("ReplicatedStorage")
03local status = replicatedstorage:WaitForChild("StatusValue")
04local player = game.Players.LocalPlayer
05local Health = player.Health:FindFirstChild ?
06local Wins = player.leaderstats.Wins
07 
08-- Functions
09while true do
10for i = 15,1,-1 do
11status.Value = "Intermission: "..i 
12wait(1)
13end
14status.Value = "Game in progress"
15local map = game.ServerStorage.BaseMap
16map:Clone().Parent = game.Workspace
17target = CFrame.new(67.98, -47.816, 1156.752)
18for i, player in ipairs(game.Players:GetChildren()) do
19player.Character.Torso.CFrame = target + Vector3.new(0, i * 5, 0)
20wait(45)
21if player.Health > 0 then Wins.Value = Wins.Value + 1
22game.Workspace.BaseMap:Destroy()
23 
24status.Value = "Game Over!"
25 
26            end
27        end
28    end
 View all 28 lines...

Only problem, "local Health = player.Health:FindFirstChild ?" can anyone help? devconstruct 4 — 7y

if Players.Health 1+ then Wins.Value = +1 isn't working?

3 answers

Answer this question