LocalScript Issue: The local script works in studio, but not in-game?

Asked by
7 years ago
I know for a fact this is a 'LocalScript' issue, but I'm not quite sure how to adjust the script for it to function out of studio.
Here's the script:
001local RANGE = 240
002local TIMESTEP = 1 / 30
003local SECONDS_BETWEEN_RECONSTRUCTION = 3
004local MAX_DIST_RATIO = 0.84
005 
006 
007-- Waits for parent.child to exist, then returns it
008local function WaitForChild(parent, childName)
009    assert(parent, "ERROR: WaitForChild: parent is nil")
010    while not parent:FindFirstChild(childName) do parent.ChildAdded:wait() end
011    return parent[childName]
012end
013 
014-----------------
015--| Variables |--
016-----------------
017 
018local PlayersService = Game:GetService('Players')
019 
020local MyPlayer = PlayersService.LocalPlayer
021local Camera = Workspace.CurrentCamera
022 
023 
024local Radar = WaitForChild(Workspace, 'Radar')
025 
026local Radar_Gui = script.Parent
027local RadarFrame = WaitForChild(Radar_Gui, 'RadarFrame')
028 
029local Background = WaitForChild(RadarFrame, 'Background')
030local Border = WaitForChild(RadarFrame, 'Border')
031local FoeBlip = WaitForChild(RadarFrame, 'FoeBlip')
032local FriendBlip = WaitForChild(RadarFrame, 'FriendBlip')
033local SelfBlip = WaitForChild(RadarFrame, 'SelfBlip')
034 
035-- Any names (keys) not in this list will be deleted (values must evaluate to true)
036local SaveList = {Background = 1, Border = 1, FoeBlip = 1, FriendBlip = 1, SelfBlip = 1}
037 
038local ObjectToBlipTable = {}
039 
040local LastReconstructionTime = 0
041 
042local RunService = Game:GetService('RunService')
043 
044 
045Background.Visible = true
046Border.Visible = true
047SelfBlip.Position = UDim2.new(0.5 - SelfBlip.Size.X.Scale / 2, 0, 0.5 - SelfBlip.Size.Y.Scale / 2, 0)
048 
049local function IsInRange(inversedFrame, pos)
050    local pos = CFrame.new(pos.X, 0, pos.Z)
051    local relativeCFrame = inversedFrame * pos
052    local distanceRatio = relativeCFrame.p.Magnitude / RANGE
053    return distanceRatio < MAX_DIST_RATIO, relativeCFrame
054end
055 
056local function CheckLos()
057    -- Uncomment the following to hide non-visible enemies that are far away
058    --[[
059    if distanceRatio >= 0.7 and player.TeamColor ~= MyPlayer.TeamColor and player.Character then
060        local torso = MyPlayer.Character:FindFirstChild('Torso')
061        local otherTorso = player.Character:FindFirstChild('Torso')
062        local ray = Ray.new(torso.Position, (otherTorso.Position - torso.Position).unit * RANGE)
063        local hit = Workspace:FindPartOnRay(ray, MyPlayer.Character)
064        if not hit or hit.Parent ~= otherTorso.Parent then
065            unit.Visible = false
066        end
067    end
068    --]]
069end
070 
071local function ConstructBlipTable()
072    for _, object in pairs(Radar:GetChildren()) do
073        if object:IsA('ObjectValue') and object.Value and object.Value:IsA('BasePart') then
074            local pos = object.Value.CFrame.p
075            local objGui
076            for _, child in pairs(object:GetChildren()) do
077                if child:IsA('Frame') then
078                    objGui = child:Clone()
079                    objGui.Parent = RadarFrame
080                    ObjectToBlipTable[object.Value] = objGui
081                end
082            end
083        end
084    end
085 
086    for _, player in pairs(PlayersService:GetPlayers()) do
087        if MyPlayer and player ~= MyPlayer and player.Character and player.Character:FindFirstChild('Torso') then
088                unit = FriendBlip:Clone()
089        else
090                unit = FoeBlip:Clone()
091        end
092            unit.Visible = false
093            unit.Name = player.Name
094            unit.Parent = RadarFrame
095            ObjectToBlipTable[player.Character.Torso] = unit
096        end
097    end
098 
099 
100local function ReconstructBlipTable()
101    -- Destroy anything in the frame that isn't going to be updated
102    for _, label in pairs(RadarFrame:GetChildren()) do
103        if not SaveList[label.Name] then
104            label:Destroy()
105        end
106    end
107    ObjectToBlipTable = {}
108    ConstructBlipTable()
109end
110 
111local function UpdateRadar()
112    local frame = Vector3.new(Camera.CoordinateFrame.x, 0, Camera.CoordinateFrame.z)
113    local focus = Vector3.new(Camera.Focus.x, 0, Camera.Focus.z)
114    local frame = CFrame.new(focus, frame)
115    local inversedFrame = frame:inverse()
116 
117    for obj, objGui in pairs(ObjectToBlipTable) do
118        if obj then
119            local pos = obj.CFrame.p
120            if pos and objGui then
121                local isClose, relativeCFrame = IsInRange(inversedFrame, pos)
122                if isClose then
123                    local xScale = 0.5 - ((relativeCFrame.x / RANGE) / 2) - objGui.Size.X.Scale / 2
124                    local yScale = 0.5 - ((relativeCFrame.z / RANGE) / 2) - objGui.Size.Y.Scale / 2
125                    objGui.Position = UDim2.new(xScale, 0, yScale, 0)
126                    objGui.Visible = true
127                else
128                    objGui.Visible = false
129                end
130            end
131        -- if there is no obj but a gui for it
132        elseif objGui then
133            objGui.Visible = false
134        end
135    end
136end
137 
138 
139 
140while true do
141    local now = tick()
142    if tick() - LastReconstructionTime > SECONDS_BETWEEN_RECONSTRUCTION then
143        ReconstructBlipTable()
144        LastReconstructionTime = now
145    end
146    UpdateRadar()
147    wait(TIMESTEP)
148end
 View all 148 lines...
It's a LocalScript inside a ScreenGUI that's in the StarterGUI. The ScreenGUI also has a frame with ImageLabels in it.
LocalScript Issue: The local script works in studio, but not in-game?

1 answer

Answer this question
