Scripting Helpers is winding down operations and is now read-only. More info→

no functions seem to be running anyone know why?

Asked by

fanofpixels 718

7 years ago

i have a script where in the middle of the script there is a function that starts like this:

`1`	`function` `play()`

`2`	`print("playing...")`

it never says "playing..."

and i have put a play() at the bottom

full code:

01local loop_phase = 1
02local playing = false
03local id = script.Id
04 
05while true do
06    wait()
07    if playing then
08        if loop_phase == 1 then
09            print("now playing: "..id.Value..".start")
10            script.Library[id.Value].start:Play()
11            wait(script.Library[id.Value].start.TimeLength)
12            loop_phase = 1
13        elseif loop_phase == 2 then
14            script.Library[id.Value].loop:Play()
15            wait(script.Library[id.Value].loop.TimeLength)
16        end
17    end
18end
19 
20function play()
21    print("playing...")
22    for i=0,50,1 do
23        wait(0.01)
24        if loop_phase == 1 then
25            script.Library[id.Value].start.Volume = script.Library[id.Value].start.Volume - 0.2
26        elseif loop_phase == 2 then
27            script.Library[id.Value].loop.Volume = script.Library[id.Value].loop.Volume - 0.2
28        end
29    end
30    playing = false
31    if loop_phase == 1 then
32        script.Library[id.Value].start:Stop()
33    elseif loop_phase == 2 then
34        script.Library[id.Value].loop:Stop()
35    end
36    script.Library[id.Value].loop.Volume = 10
37    script.Library[id.Value].start.Volume = 10
38 
39    loop_phase = 1
40    playing = true
41end
42 
43play()
 View all 43 lines...

the local id = script.Id is a string value set to "adventure"

the script will locate: script.Library[id.Value]["start"] at some point which basicly means script.Library.start

and start is a sound in a folder called adventure in the script

no errors, or the "playing..." i seriously need help

Because you have a loop and until that loop ends you cannot do anything... greatneil80 2647 — 7y

its working fine now, thanks! (i have learned something very important: loops that never end should come last) fanofpixels 718 — 7y

1 answer

Answered by

RayCurse 1518

7 years ago

Edited 7 years ago

Remember that a script is linear and performs tasks sequentially. In your problem, the problem arises because the script will start the infinite while loop and never end. Thus, the script can't progress to the code after it. If you want to fix this, the simplest and easiest way is to simply move the infinite loop after everything else. This would look like this:

01local loop_phase = 1
02local playing = false
03local id = script.Id
04 
05function play()
06    print("playing...")
07    for i=0,50,1 do
08        wait(0.01)
09        if loop_phase == 1 then
10            script.Library[id.Value].start.Volume = script.Library[id.Value].start.Volume - 0.2
11        elseif loop_phase == 2 then
12            script.Library[id.Value].loop.Volume = script.Library[id.Value].loop.Volume - 0.2
13        end
14    end
15    playing = false
16    if loop_phase == 1 then
17        script.Library[id.Value].start:Stop()
18    elseif loop_phase == 2 then
19        script.Library[id.Value].loop:Stop()
20    end
21    script.Library[id.Value].loop.Volume = 10
22    script.Library[id.Value].start.Volume = 10
23 
24    loop_phase = 1
25    playing = true
26end
27 
28play()
29 
30while true do
31    wait()
32    if playing then
33        if loop_phase == 1 then
34            print("now playing: "..id.Value..".start")
35            script.Library[id.Value].start:Play()
36            wait(script.Library[id.Value].start.TimeLength)
37            loop_phase = 1
38        elseif loop_phase == 2 then
39            script.Library[id.Value].loop:Play()
40            wait(script.Library[id.Value].loop.TimeLength)
41        end
42    end
43end
 View all 43 lines...

Adding to this, if for some reason you can't move the while loop to the end, you could use spawn() or coroutines to run them in a separate thread. mattscy 3725 — 7y

no functions seem to be running anyone know why?

1 answer

Answer this question