Scripting Helpers is winding down operations and is now read-only. More info→

This script freezes my game and I don't know why. Please help?

Asked by

SebbyTheGODKid 198

7 years ago

Edited 7 years ago

The script (posted below) will freeze the server and I don't see why. This code is part of my Build Battle game, so after it is resolved I will censor it, but only because I don't want people stealing my game.

01function doSpecialRound(buildTime, voteTime, intermissionTime)
02    throw("notification","This round will be different!")
03    wait(11)
04    throw("notification","This round you will have to guess what the player is building")   
05    setStatus("Choosing builder...")
06    wait(3)
07    player = get_Child(game.Players,math.random(0,#game.Players:GetChildren()))
08    if player.Character and player.Character.HumanoidRootPart then
09        player.Character:MoveTo(workspace.Teleports.LobbyBase.base.Position)
10    end
11    -- Give tools
12    for i,v in pairs(game.ServerStorage.StamperTools:GetChildren()) do
13        tool = v:Clone()
14        tool.Parent = player.Backpack
15    end
16    ncs = script.Resources.NoChatScript:Clone()
17    ncs.Parent = player.Backpack
18    ncs.Disabled = false
19    workspace.MakeChat:FireAllClients("The bonus round has started! Chat what you think the builder is making!")
20    i = 90
21    category = tostring(cat[ch])
22    for i,v in pairs(game.Players:GetChildren()) do
23        v.PlayerGui.main.Frame.Category.Text = "Mystery"
24    end
25    player.PlayerGui.main.Frame.Category.Text = category
26    -- Chat hook
27    setStatus("Mystery round...")
28    for i,v in pairs(game.Players:GetChildren()) do
29        pcall(function()
30        v.Chatted:connect(function(msg)
31            if string.lower(msg) == string.lower(category) then
32                throw("msg",v.Name .. " has guessed the theme!")
33                workspace.MakeChat("The theme was " .. category)
34                game.PointsService:AwardPoints(v.UserId,100)
35                v.leaderstats.Wins.Value = v.leaderstats.Wins.Value+1
36                for i,v in pairs(game.Players:GetChildren()) do
37                pcall(function()
38                v.Chatted:disconnect() -- Deprecated, but options are limited
39                end)
40                end
41            end
42        end)
43        end)
44    end
45    while i > -1 do
46        for i,v in pairs(game.Players:GetChildren()) do
47            pcall(function()
48            v.PlayerGui.main.Frame.Time = i
49            i=i-1
50            wait(1)
51            end)
52        end
53    end
54end
 View all 54 lines...

EDIT (1):

1local get_Child=function(obj,index)
2    return obj:children()[tonumber(index)]
3end

Beyond me, I would help... if I could AlphaGamer150 101 — 7y

Ok thanks for the quick reply though SebbyTheGODKid 198 — 7y

2 answers

Answered by

128Gigabytes 20

7 years ago

Pretty sure its got to do with the while loop on line 45, no idea what you are trying to do in this loop but its wrong.

For instance, you use i as your timer number but also reuse it in a for loop on line 47 (for i,v) so the timer version of i never gets subtracted from because you only subtract within this loop. Rename one of the i's.

Also line 38, :disconnect is deprecated but :Disconnect() isn't so if you wanna change that.

ah, i thought Disconnect() and disconnec() were the same, thanks for the clarification. And also thanks for the help! SebbyTheGODKid 198 — 7y

Did the help fix your issue or are you still having trouble? 128Gigabytes 20 — 7y

no, sorry. the freeze still occurs SebbyTheGODKid 198 — 7y

Answered by

SebbyTheGODKid 198

7 years ago

Alright, so the problem still occurs, and here is the revised code:

01function doSpecialRound(buildTime, voteTime, intermissionTime)
02    throw("notification","This round will be different!")
03    wait(11)
04    throw("notification","This round you will have to guess what the player is building")   
05    setStatus("Choosing builder...")
06    wait(3)
07    player = get_Child(game.Players,math.random(0,#game.Players:GetChildren()))
08    if player.Character and player.Character.HumanoidRootPart then
09        player.Character:MoveTo(workspace.Teleports.LobbyBase.base.Position)
10    end
11    -- Give tools
12    for i,v in pairs(game.ServerStorage.StamperTools:GetChildren()) do
13        tool = v:Clone()
14        tool.Parent = player.Backpack
15    end
16    ncs = script.Resources.NoChatScript:Clone()
17    ncs.Parent = player.Backpack
18    ncs.Disabled = false
19    workspace.MakeChat:FireAllClients("The bonus round has started! Chat what you think the builder is making!")
20    timer = 90
21    category = tostring(cat[ch])
22    for i,v in pairs(game.Players:GetChildren()) do
23        v.PlayerGui.main.Frame.Category.Text = "Mystery"
24    end
25    player.PlayerGui.main.Frame.Category.Text = category
26    -- Chat hook
27    setStatus("Mystery round...")
28    for i,v in pairs(game.Players:GetChildren()) do
29        pcall(function()
30        v.Chatted:connect(function(msg)
31            if string.lower(msg) == string.lower(category) then
32                throw("msg",v.Name .. " has guessed the theme!")
33                workspace.MakeChat("The theme was " .. category)
34                game.PointsService:AwardPoints(v.UserId,100)
35                v.leaderstats.Wins.Value = v.leaderstats.Wins.Value+1
36                for i,v in pairs(game.Players:GetChildren()) do
37                pcall(function()
38                v.Chatted:disconnect() -- Deprecated, but options are limited
39                end)
40                end
41            end
42        end)
43        end)
44    end
45    while timer > -1 do
46        for _,v in pairs(game.Players:GetChildren()) do
47            pcall(function()
48            v.PlayerGui.main.Frame.Time = timer
49            timer=timer-1
50            wait(1)
51            end)
52        end
53    end
54end
 View all 54 lines...

Is it possible your pcall is failing at line 48 causing line 49 and 50 to not run, so it is a endless loop with no waits? Put the wait and timer subtraction outside the pcall and see what happens. 128Gigabytes 20 — 7y

ok, smart idea SebbyTheGODKid 198 — 7y

Edit the question + comment on previous answer rather than posting another answer plz :) Goulstem 8144 — 7y

Ok the problem is solved! Thanks for all your help. You can see the script in-action on my Build Battle game. (1158750748) SebbyTheGODKid 198 — 7y

This script freezes my game and I don't know why. Please help?

2 answers

Answer this question