A bug that is annoying me a lot! Can someone help me?

Asked by

tobyjing2005 107

7 years ago

What I'm having a problem with is that I made a hammer that allows me to build fences, and so far I'm very happy with the progress! However when I tried it on a local server, it just refuses to work, even printing a string of words, you know, print("Something like this!"). I tried connecting it to the server with a RemoteEvent but it still doesn't work, only on the server! I have no idea why! I might just be blind and stupid but oh well.

I just can't seem to spot the fix. I'm also not sure if it's because of the tool itself or the scripts contained inside because I copied the exact tool but changed the script to just place a brick where you click in the workspace, it works like I expected it to without flaws. Be warned that the script you're about to see is long. 202 lines as of now.

THIS IS CLIENT SIDED!

001local plr = game.Players.LocalPlayer
002local tool = script.Parent
003 
004local mouse = plr:GetMouse()
005 
006local canSelectOption = true
007local canPlaceItem = false
008local isHoldingShift = false
009local isShowingCantPlace = false
010local isSetToGreen = true
011local toolIsEquipped = false
012 
013local previousAngle = 0
014 
015local originalPartColor = {}
016local originalPartTransparency = {}
017local originalPartMaterial = {}
018 
019repeat wait() until plr.PlayerGui.HammerBuildingGui ~= nil
020repeat wait() until game.ServerStorage.Fences ~= nil
021 
022script.Parent.Print:FireServer("Loaded Hammer Script")
023 
024local function resetAllValues()
025    canSelectOption = true
026    canPlaceItem = false
027    isHoldingShift = false
028    isShowingCantPlace = false
029    isSetToGreen = true
030 
031    previousAngle = 0
032 
033    originalPartColor = {}
034    originalPartTransparency = {}
035    originalPartMaterial = {}
036end
037 
038local function changeFenceToRed()
039    pcall(function()
040        script.Parent.Print:FireServer("Changed to red")
041 
042        for i = 1, #fenceSelected:GetChildren() do
043            local parts = fenceSelected:GetChildren()
044 
045            if parts[i]:IsA("BasePart") and parts[i].Name ~= "FenceCollision" then
046                parts[i].Transparency = 0.5
047                parts[i].Material = "SmoothPlastic"
048                parts[i].BrickColor = BrickColor.new(Color3.fromRGB(255,100,100))
049            end
050        end
051    end)
052end
053 
054local function changeFenceToGreen()
055    pcall(function()
056        script.Parent.Print:FireServer("Changed to green")
057 
058        for i = 1, #fenceSelected:GetChildren() do
059            local parts = fenceSelected:GetChildren()
060 
061            if parts[i]:IsA("BasePart") and parts[i].Name ~= "FenceCollision" then
062                parts[i].Transparency = 0.5
063                parts[i].Material = "SmoothPlastic"
064                parts[i].BrickColor = BrickColor.new(Color3.fromRGB(50,255,50))
065            end
066        end
067    end)
068end
069 
070for i, option in pairs(plr.PlayerGui.HammerBuildingGui.Frame.OptionsScrollingFrame:GetChildren()) do
071    if option:IsA("TextButton") and game.ServerStorage.Fences:FindFirstChild(option.Name) then
072        option.MouseButton1Click:connect(function()
073            script.Parent.Print:FireServer("Clicked option: " .. option.Name)
074 
075            script.Parent.Build:FireServer(option, canSelectOption)
076 
077            if canSelectOption == true and toolIsEquipped == true then
078                local function createFence()
079                    canSelectOption = false
080 
081                    fenceSelected = game.ServerStorage.Fences[option.Name]:Clone()
082                    fenceSelected.FenceCollision.CanCollide = false
083                    fenceSelected.Parent = workspace
084 
085                    for i = 1, #fenceSelected:GetChildren() do
086                        local parts = fenceSelected:GetChildren()
087 
088                        if parts[i]:IsA("BasePart") and parts[i].Name ~= "FenceCollision" then
089                            originalPartColor[i] = parts[i].BrickColor
090                            originalPartTransparency[i] = parts[i].Transparency
091                            originalPartMaterial[i] = parts[i].Material
092                        end
093                    end
094 
095                    changeFenceToGreen()
096 
097                    if isHoldingShift == true then
098                        fenceSelected:SetPrimaryPartCFrame(fenceSelected:GetPrimaryPartCFrame() * CFrame.Angles(0,math.rad(previousAngle),0))
099                    end
100 
101                    mouse.TargetFilter = fenceSelected
102 
103                    repeat
104                        fenceSelected:TranslateBy(Vector3.new(mouse.Hit.p.X,((fenceSelected.Settings.FenceHeight.Value / 2) - 0.2) + mouse.Hit.p.Y, mouse.Hit.p.Z) - fenceSelected:GetPrimaryPartCFrame().p)
105 
106                        if mouse.Target and isShowingCantPlace == false then                           
107                            if mouse.Target.Name == "PlaceableVisibility" then
108                                canPlaceItem = true
109 
110                                if isSetToGreen == false then
111                                    isSetToGreen = true
112 
113                                    changeFenceToGreen()
114                                end
115                            else
116                                canPlaceItem = false
117 
118                                if isSetToGreen == true then
119                                    isSetToGreen = false
120 
121                                    changeFenceToRed()
122                                end
123                            end
124                        end
125 
126                        game:GetService("RunService").RenderStepped:Wait()
127                    until canSelectOption == true
128 
129                    if isHoldingShift == true then
130                        createFence()
131                    end
132                end
133 
134                createFence()
135            end
136        end)
137    end
138end
139 
140tool.Equipped:connect(function()
141    script.Parent.Print:FireServer("Equipped tool")
142    toolIsEquipped = true
143 
144    resetAllValues()
145 
146    pcall(function()
147        plr.PlayerGui.HammerBuildingGui.Frame:TweenPosition(UDim2.new(0,5,1,-255), "Out", "Quad", 0.5)
148    end)
149end)
150 
151tool.Unequipped:connect(function()
152    script.Parent.Print:FireServer("Unequipped tool")
153    toolIsEquipped = false
154 
155    resetAllValues()
156    fenceSelected:Destroy()
157 
158    pcall(function()
159        plr.PlayerGui.HammerBuildingGui.Frame:TweenPosition(UDim2.new(0,-300,1,-255), "Out", "Quad", 0.5)
160    end)
161end)
162 
163mouse.Button1Down:connect(function()
164    script.Parent.Print:FireServer("Button1Down")
165 
166    if canSelectOption == false and canPlaceItem == true and plr.leaderstats.Cash.Value >= fenceSelected.Settings.Price.Value and plr.leaderstats.Level.Value >= fenceSelected.Settings.LevelRequired.Value then
167        canSelectOption = true
168 
169        script.Parent.UpdateStats:FireServer(plr.leaderstats, fenceSelected.Settings.Price.Value, fenceSelected.Settings.LevelRequired.Value)
170        script.Parent.Build:FireServer(fenceSelected, originalPartColor, originalPartTransparency, originalPartMaterial)
171    elseif canSelectOption == false and canPlaceItem == true then
172        isShowingCantPlace = true
173        changeFenceToRed()
174        wait(0.1)
175        changeFenceToGreen()
176        isShowingCantPlace = false
177    end
178end)
179 
180game:GetService("UserInputService").InputBegan:connect(function(key)
181    if key.KeyCode == Enum.KeyCode.Q and canSelectOption == false then
182        canSelectOption = true
183        canPlaceItem = false
184 
185        originalPartColor = {}
186        originalPartTransparency = {}
187        originalPartMaterial = {}
188 
189        fenceSelected:Destroy()
190    elseif key.KeyCode == Enum.KeyCode.R and canSelectOption == false and canPlaceItem == true then
191        fenceSelected:SetPrimaryPartCFrame(fenceSelected:GetPrimaryPartCFrame() * CFrame.Angles(0,math.rad(45),0))
192        previousAngle = previousAngle + 45
193    elseif key.KeyCode == Enum.KeyCode.LeftShift then
194        isHoldingShift = true
195    end
196end)
197 
198game:GetService("UserInputService").InputEnded:connect(function(key)
199    if key.KeyCode == Enum.KeyCode.LeftShift then
200        isHoldingShift = false
201    end
202end)
 View all 202 lines...

ATTENTION! Okay, now I've got your attention, I'm just telling you that the next script is server sided.

01script.Parent.Build.OnServerEvent:connect(function(plr, fenceSelected, originalPartColor, originalPartTransparency, originalPartMaterial)
02    for i = 1, #fenceSelected:GetChildren() do
03        local parts = fenceSelected:GetChildren()
04 
05        if parts[i]:IsA("BasePart") and parts[i].Name ~= "FenceCollision" then
06            parts[i].BrickColor = originalPartColor[i]
07            parts[i].Transparency = originalPartTransparency[i]
08            parts[i].Material = originalPartMaterial[i]
09        elseif parts[i]:IsA("BasePart") and parts[i].Name == "FenceCollision" then
10            parts[i].CanCollide = true
11        end
12    end
13end)
14 
15script.Parent.UpdateStats.OnServerEvent:connect(function(plr, stats, price, level)
16    stats.Cash.Value = stats.Cash.Value - price
17end)
18 
19script.Parent.Print.OnServerEvent:connect(function(plr, message)
20    print(message)
21end)
 View all 21 lines...

Any errors? hiimgoodpack 2009 — 7y

Nope, no errors at all. Server and client doesn’t show any errors. tobyjing2005 107 — 7y

A bug that is annoying me a lot! Can someone help me?

1 answer

Answer this question