Scripting Helpers is winding down operations and is now read-only. More info→

Too many 'upvalues' in function, Alternatives possible?

Asked by

Adrian12094 12

7 years ago

So basically I've been trying to make a system with 61 light switches (with FilteringEnabled) that can be switched on/off across a map. The problem is that I tried many possibilities in order to make this function properly. So I tried this method, but it returns an error indicating that the function has too many upvalues. Is there any other possible alternatives to this?

WARNING, MEDIOCRE CODE INCOMING

001-- [[ LIGHT SWITCHES ]] --         
002local switch1 = workspace.LightSwitch1
003local switch2 = workspace.LightSwitch2
004local switch3 = workspace.LightSwitch3
005local switch4 = workspace.LightSwitch4
006local switch5 = workspace.LightSwitch5
007local switch6 = workspace.LightSwitch6
008local switch7 = workspace.LightSwitch7
009local switch8 = workspace.LightSwitch8
010local switch9 = workspace.LightSwitch9
011local switch10 = workspace.LightSwitch10
012local switch11 = workspace.LightSwitch11
013local switch12 = workspace.LightSwitch12
014local switch13 = workspace.LightSwitch13
015local switch14 = workspace.LightSwitch14
016local switch15 = workspace.LightSwitch15
017local switch16 = workspace.LightSwitch16
018local switch17 = workspace.LightSwitch17
019local switch18 = workspace.LightSwitch18
020local switch19 = workspace.LightSwitch19
021local switch20 = workspace.LightSwitch20
022local switch21 = workspace.LightSwitch21
023local switch22 = workspace.LightSwitch22
024local switch23 = workspace.LightSwitch23
025local switch24 = workspace.LightSwitch24
026local switch25 = workspace.LightSwitch25
027local switch26 = workspace.LightSwitch26
028local switch27 = workspace.LightSwitch27
029local switch28 = workspace.LightSwitch28
030local switch29 = workspace.LightSwitch29
031local switch30 = workspace.LightSwitch30
032local switch31 = workspace.LightSwitch31
033local switch32 = workspace.LightSwitch32
034local switch33 = workspace.LightSwitch33
035local switch34 = workspace.LightSwitch34
036local switch35 = workspace.LightSwitch35
037local switch36 = workspace.LightSwitch36
038local switch37 = workspace.LightSwitch37
039local switch38 = workspace.LightSwitch38
040local switch39 = workspace.LightSwitch39
041local switch40 = workspace.LightSwitch40
042local switch41 = workspace.LightSwitch41
043local switch42 = workspace.LightSwitch42
044local switch43 = workspace.LightSwitch43
045local switch44 = workspace.LightSwitch44
046local switch45 = workspace.LightSwitch45
047local switch46 = workspace.LightSwitch46
048local switch47 = workspace.LightSwitch47
049local switch48 = workspace.LightSwitch48
050local switch49 = workspace.LightSwitch49
051local switch50 = workspace.LightSwitch50
052local switch51 = workspace.LightSwitch51
053local switch52 = workspace.LightSwitch52
054local switch53 = workspace.LightSwitch53
055local switch54 = workspace.LightSwitch54
056local switch55 = workspace.LightSwitch55
057local switch56 = workspace.LightSwitch56
058local switch57 = workspace.LightSwitch57
059local switch58 = workspace.LightSwitch58
060local switch59 = workspace.LightSwitch59
061local switch60 = workspace.LightSwitch60
062local switch61 = workspace.LightSwitch61
063 
064 
065-- [[ Normal Variables ]]
066local plr = game.Players.LocalPlayer
067local chr = plr.CharacterAdded:wait()
068local notice = script.Parent.Parent.HUD.Notices.LightSwitch
069local UIS = game:GetService('UserInputService')
070local remote = game.ReplicatedStorage.InGameEvents.LightSwitch
071 
072 
073-- [[ Events ]]
074UIS.InputBegan:Connect(function(input)
075    if input.KeyCode == Enum.KeyCode.E then
076        if (chr.Torso.Position - switch1.Switch.Position).magnitude <= 1.8 then
077            remote:FireServer('1')
078        elseif (chr.Torso.Position - switch2.Switch.Position).magnitude <= 1.8 then
079            remote:FireServer('2')
080        elseif (chr.Torso.Position - switch3.Switch.Position).magnitude <= 1.8 then
081            remote:FireServer('3')
082        elseif (chr.Torso.Position - switch4.Switch.Position).magnitude <= 1.8 then
083            remote:FireServer('4')
084        elseif (chr.Torso.Position - switch5.Switch.Position).magnitude <= 1.8 then
085            remote:FireServer('5')
086        elseif (chr.Torso.Position - switch6.Switch.Position).magnitude <= 1.8 then
087            remote:FireServer('6')
088        elseif (chr.Torso.Position - switch7.Switch.Position).magnitude <= 1.8 then
089            remote:FireServer('7')
090        elseif (chr.Torso.Position - switch8.Switch.Position).magnitude <= 1.8 then
091            remote:FireServer('8')
092        elseif (chr.Torso.Position - switch9.Switch.Position).magnitude <= 1.8 then
093            remote:FireServer('9')
094        elseif (chr.Torso.Position - switch10.Switch.Position).magnitude <= 1.8 then
095            remote:FireServer('10')
096        elseif (chr.Torso.Position - switch11.Switch.Position).magnitude <= 1.8 then
097            remote:FireServer('11')
098        elseif (chr.Torso.Position - switch12.Switch.Position).magnitude <= 1.8 then
099            remote:FireServer('12')
100        elseif (chr.Torso.Position - switch13.Switch.Position).magnitude <= 1.8 then
101            remote:FireServer('13')
102        elseif (chr.Torso.Position - switch14.Switch.Position).magnitude <= 1.8 then
103            remote:FireServer('14')
104        elseif (chr.Torso.Position - switch15.Switch.Position).magnitude <= 1.8 then
105            remote:FireServer('15')
106        elseif (chr.Torso.Position - switch16.Switch.Position).magnitude <= 1.8 then
107            remote:FireServer('16')
108        elseif (chr.Torso.Position - switch17.Switch.Position).magnitude <= 1.8 then
109            remote:FireServer('17')
110        elseif (chr.Torso.Position - switch18.Switch.Position).magnitude <= 1.8 then
111            remote:FireServer('18')
112        elseif (chr.Torso.Position - switch19.Switch.Position).magnitude <= 1.8 then
113            remote:FireServer('19')
114        elseif (chr.Torso.Position - switch20.Switch.Position).magnitude <= 1.8 then
115            remote:FireServer('20')
116        elseif (chr.Torso.Position - switch21.Switch.Position).magnitude <= 1.8 then
117            remote:FireServer('21')
118        elseif (chr.Torso.Position - switch22.Switch.Position).magnitude <= 1.8 then
119            remote:FireServer('22')
120        elseif (chr.Torso.Position - switch23.Switch.Position).magnitude <= 1.8 then
121            remote:FireServer('23')
122        elseif (chr.Torso.Position - switch24.Switch.Position).magnitude <= 1.8 then
123            remote:FireServer('24')
124        elseif (chr.Torso.Position - switch25.Switch.Position).magnitude <= 1.8 then
125            remote:FireServer('25')
126        elseif (chr.Torso.Position - switch26.Switch.Position).magnitude <= 1.8 then
127            remote:FireServer('26')
128        elseif (chr.Torso.Position - switch27.Switch.Position).magnitude <= 1.8 then
129            remote:FireServer('27')
130        elseif (chr.Torso.Position - switch28.Switch.Position).magnitude <= 1.8 then
131            remote:FireServer('28')
132        elseif (chr.Torso.Position - switch29.Switch.Position).magnitude <= 1.8 then
133            remote:FireServer('29')
134        elseif (chr.Torso.Position - switch30.Switch.Position).magnitude <= 1.8 then
135            remote:FireServer('30')
136        elseif (chr.Torso.Position - switch31.Switch.Position).magnitude <= 1.8 then
137            remote:FireServer('31')
138        elseif (chr.Torso.Position - switch32.Switch.Position).magnitude <= 1.8 then
139            remote:FireServer('32')         
140        elseif (chr.Torso.Position - switch33.Switch.Position).magnitude <= 1.8 then
141            remote:FireServer('33')
142        elseif (chr.Torso.Position - switch34.Switch.Position).magnitude <= 1.8 then
143            remote:FireServer('34')
144        elseif (chr.Torso.Position - switch35.Switch.Position).magnitude <= 1.8 then
145            remote:FireServer('35')
146        elseif (chr.Torso.Position - switch36.Switch.Position).magnitude <= 1.8 then
147            remote:FireServer('36')
148        elseif (chr.Torso.Position - switch37.Switch.Position).magnitude <= 1.8 then
149            remote:FireServer('37')
150        elseif (chr.Torso.Position - switch38.Switch.Position).magnitude <= 1.8 then
151            remote:FireServer('38')
152        elseif (chr.Torso.Position - switch39.Switch.Position).magnitude <= 1.8 then
153            remote:FireServer('39')
154        elseif (chr.Torso.Position - switch40.Switch.Position).magnitude <= 1.8 then
155            remote:FireServer('40')
156        elseif (chr.Torso.Position - switch41.Switch.Position).magnitude <= 1.8 then
157            remote:FireServer('41')
158        elseif (chr.Torso.Position - switch42.Switch.Position).magnitude <= 1.8 then
159            remote:FireServer('42')
160        elseif (chr.Torso.Position - switch43.Switch.Position).magnitude <= 1.8 then
161            remote:FireServer('43')
162        elseif (chr.Torso.Position - switch44.Switch.Position).magnitude <= 1.8 then
163            remote:FireServer('44')
164        elseif (chr.Torso.Position - switch45.Switch.Position).magnitude <= 1.8 then
165            remote:FireServer('45')
166        elseif (chr.Torso.Position - switch46.Switch.Position).magnitude <= 1.8 then
167            remote:FireServer('46')
168        elseif (chr.Torso.Position - switch47.Switch.Position).magnitude <= 1.8 then
169            remote:FireServer('47')
170        elseif (chr.Torso.Position - switch48.Switch.Position).magnitude <= 1.8 then
171            remote:FireServer('48')
172        elseif (chr.Torso.Position - switch49.Switch.Position).magnitude <= 1.8 then
173            remote:FireServer('49')
174        elseif (chr.Torso.Position - switch50.Switch.Position).magnitude <= 1.8 then
175            remote:FireServer('50')
176        elseif (chr.Torso.Position - switch51.Switch.Position).magnitude <= 1.8 then
177            remote:FireServer('51')
178        elseif (chr.Torso.Position - switch52.Switch.Position).magnitude <= 1.8 then
179            remote:FireServer('52')
180        elseif (chr.Torso.Position - switch53.Switch.Position).magnitude <= 1.8 then
181            remote:FireServer('53')
182        elseif (chr.Torso.Position - switch54.Switch.Position).magnitude <= 1.8 then
183            remote:FireServer('54')
184        elseif (chr.Torso.Position - switch55.Switch.Position).magnitude <= 1.8 then
185            remote:FireServer('55')
186        elseif (chr.Torso.Position - switch56.Switch.Position).magnitude <= 1.8 then
187            remote:FireServer('56')
188        elseif (chr.Torso.Position - switch57.Switch.Position).magnitude <= 1.8 then
189            remote:FireServer('57')
190        elseif (chr.Torso.Position - switch58.Switch.Position).magnitude <= 1.8 then
191            remote:FireServer('58')
192        elseif (chr.Torso.Position - switch59.Switch.Position).magnitude <= 1.8 then
193            remote:FireServer('59')
194        elseif (chr.Torso.Position - switch60.Switch.Position).magnitude <= 1.8 then
195            remote:FireServer('60')
196        elseif (chr.Torso.Position - switch61.Switch.Position).magnitude <= 1.8 then
197            remote:FireServer('61')
198 
199 
200        end
201    end
202end)
 View all 202 lines...

that's lots of elseif statments, find a way to simplify your code saSlol2436 716 — 7y

plus, put your switches in an array since it just stores things and keeps your code organized saSlol2436 716 — 7y

I really don't know how to simplify the code, i've tried multiple methods and I can't think of another anymore Adrian12094 12 — 7y

bruh use for loops, arrays, tables, get children, and anything else! this code looks very inefficient. abnotaddable 920 — 7y

Ahh your code hurts my eyes. Please us an array raspyjessie 117 — 7y

1 answer

Answered by

whenallthepigsfly 541

7 years ago

First, if you have many similar objects, it's a great idea to put them all in an array. This allows you to access a light switch based on it's number in the array, like so:

1local lightSwitches = {workspace.LightSwitch1,
2                workspace.LightSwitch2,
3                workspace.LightSwitch3,
4                workspace.LightSwitch4,
5                workspace.LightSwitch5} --Continue adding your lights from here...
6print(lightSwitches[1])

Alternatively, you can automate discovery of your lights, using a for-each loop. Don't do this too often, as it is quite expensive. To be more efficient, you could put all your lights into a common folder you could quickly scan through. To do this, you should name them all the same thing. It's not important for you to be able to distinguish between light switches, so this is by far the easiest solution.

01local placeWithAllLights = workspace.folderWithLights --This might be workspace for you if you didn't put your lights in a folder.
02 
03local lightSwitches = {} --Telling the game that this variable will be an array, so it knows what to expect
04for index, object in pairs(placeWithAllLights:GetChildren()) do --i is the index, object is the current value of the array.
05    if object.Name == "LightSwitch" then --check to make sure it is a light switch...
06        table.insert(lightSwitches, object) --add the light switch to the array
07        print("This is a light!")
08    else
09        print("Not a light!")
10    end
11end
12print("Finished scanning for lights, found ", #lightSwitches)

This should give you an array with all of your lights in it. Then, it's a simple matter of scanning through lights when E is pressed, and finding the closest one. This is what it would look like finished:

01local placeWithAllLights = workspace.folderWithLights --This might be workspace for you if you didn't put your lights in a folder.
02 
03local lightSwitches = {} --Telling the game that this variable will be an array, so it knows what to expect
04for index, object in pairs(placeWithAllLights:GetChildren()) do --i is the index, object is the current value of the array.
05    if object.Name == "LightSwitch" then --check to make sure it is a light switch...
06        table.insert(lightSwitches, object) --add the light switch to the array
07        print("This is a light!")
08    else
09        print("Not a light!")
10    end
11end
12print("Finished scanning for lights, found ", #lightSwitches)
13 
14local nearestLightSwitchIndex
15local nearestLightDistance = math.huge
16local range = 1.8 --Define your range in a variable to easily change it later...
17 
18UIS.InputBegan:Connect(function(input)
19    if input.KeyCode == Enum.KeyCode.E then
20        for index, lightSwitch in pairs(lightSwitches) do
21            local distance = (chr.Torso.Position - lightSwitch.Switch.Position).magnitude
22            if distance <= range and distance < nearestLightDistance then --The second part guarantees that we get the absolute closest switch
23                nearestLightSwitchIndex = index
24                nearestLightDistance = distance
25            end
26        end
27    end
28    remote:FireServer(tostring(nearestLightSwitchIndex )) --Finally, convert the number index to a string for compatibility with your in place code, and fire the server.
29end)
 View all 29 lines...

I HIGHLY recommend reading up on for loops and generic for loops, as well as tables/array. They can make life a million times easier in the long run. Hope I helped!

http://wiki.roblox.com/index.php?title=Loops

http://wiki.roblox.com/index.php?title=Generic_for

http://wiki.roblox.com/index.php?title=Table

+1, but note: for loops aren't expensive (GetChildren is a bit, but not worth worrying about if you're not doing it regularly). If you have a folder with *just* light switches, your table of lights can come directly from :GetChildren(), rather than iterating over it and filtering by name. Finally, for the FireServer, I'd recommend sending the light switch itself, rather than its index. chess123mate 5873 — 7y

(Sending the light instead of its index isn't a concern if lights are never added/removed while the game is running.) chess123mate 5873 — 7y

@chess123mate About the check to verify a switch and the strange server firing, I wrote this code to integrate into OPs original script structure as a basically copy-paste job. Seems like a new scripter, and I didn't want to over-complicate things. Thanks for the tip about :GetChildren() though, wasn't aware it was an expensive function :) ! whenallthepigsfly 541 — 7y

Thanks mate Adrian12094 12 — 7y

You coulld do "workspace['LightSwitch'..number]" hiimgoodpack 2009 — 7y

Too many 'upvalues' in function, Alternatives possible?

1 answer

Answer this question