Weapon script dosn't deflect damage, why?

I'm trying to make a weapon, it swings but it doesn't do any damage,when I had the script print what the argument was, it said terrain.

console

Terrain 18:33:52.341 - Humanoid is not a valid member of Workspace 18:33:52.342 - Stack Begin 18:33:52.343 - Script 'Players.Player2.Backpack.axe.damage', Line 5 18:33:52.344 - Stack End

script

1script.Parent.hitbox.Touched:connect(function(p)
2    if script.Parent.CanDamage.Value == true then
3        print(p)
4        script.Parent.CanDamage.Value = false
5        p.Parent.Humanoid:TakeDamage(20)
6    end
7end)

local script

01local CanAttack = true
02 
03script.Parent.Activated:connect(function()
04 
05local attack = script.Parent.Parent.Humanoid:LoadAnimation(script.Attack)
06 
07if CanAttack == true then
08script.Parent.CanDamage.Value = true
09game.Players.LocalPlayer.Character.Humanoid.WalkSpeed = 0
10attack:Play()
11 
12CanAttack = false
13 
14wait(0.4)
15 
16attack:Stop()
17game.Players.LocalPlayer.Character.Humanoid.WalkSpeed = 16
18CanAttack = true
19 
20script.Parent.CanDamage.Value = false
21 
22end
23 
24end)
 View all 24 lines...

welding script (in case)

001local NEVER_BREAK_JOINTS = false
002 
003local function CallOnChildren(Instance, FunctionToCall)
004 
005    FunctionToCall(Instance)
006 
007    for _, Child in next, Instance:GetChildren() do
008        CallOnChildren(Child, FunctionToCall)
009    end
010end
011 
012local function GetNearestParent(Instance, ClassName)
013 
014    local Ancestor = Instance
015    repeat
016        Ancestor = Ancestor.Parent
017        if Ancestor == nil then
018            return nil
019        end
020    until Ancestor:IsA(ClassName)
021 
022    return Ancestor
023end
024 
025local function GetBricks(StartInstance)
026    local List = {}
027 
028    CallOnChildren(StartInstance, function(Item)
029        if Item:IsA("BasePart") then
030            List[#List+1] = Item;
031        end
032    end)
033 
034    return List
035end
036 
037local function Modify(Instance, Values)
038 
039    assert(type(Values) == "table", "Values is not a table");
040 
041    for Index, Value in next, Values do
042        if type(Index) == "number" then
043            Value.Parent = Instance
044        else
045            Instance[Index] = Value
046        end
047    end
048    return Instance
049end
050 
051local function Make(ClassType, Properties)
052    -- Using a syntax hack to create a nice way to Make new items.  
053 
054    return Modify(Instance.new(ClassType), Properties)
055end
056 
057local Surfaces = {"TopSurface", "BottomSurface", "LeftSurface", "RightSurface", "FrontSurface", "BackSurface"}
058local HingSurfaces = {"Hinge", "Motor", "SteppingMotor"}
059 
060local function HasWheelJoint(Part)
061    for _, SurfaceName in pairs(Surfaces) do
062        for _, HingSurfaceName in pairs(HingSurfaces) do
063            if Part[SurfaceName].Name == HingSurfaceName then
064                return true
065            end
066        end
067    end
068 
069    return false
070end
071 
072local function ShouldBreakJoints(Part)
073    --- We do not want to break joints of wheels/hinges. This takes the utmost care to not do this. There are
074    --  definitely some edge cases. 
075 
076    if NEVER_BREAK_JOINTS then
077        return false
078    end
079 
080    if HasWheelJoint(Part) then
081        return false
082    end
083 
084    local Connected = Part:GetConnectedParts()
085 
086    if #Connected == 1 then
087        return false
088    end
089 
090    for _, Item in pairs(Connected) do
091        if HasWheelJoint(Item) then
092            return false
093        elseif not Item:IsDescendantOf(script.Parent) then
094            return false
095        end
096    end
097 
098    return true
099end
100 
101local function WeldTogether(Part0, Part1, JointType, WeldParent)
102 
103    JointType = JointType or "Weld"
104    local RelativeValue = Part1:FindFirstChild("qRelativeCFrameWeldValue")
105 
106    local NewWeld = Part1:FindFirstChild("qCFrameWeldThingy") or Instance.new(JointType)
107    Modify(NewWeld, {
108        Name = "qCFrameWeldThingy";
109        Part0  = Part0;
110        Part1  = Part1;
111        C0     = CFrame.new();--Part0.CFrame:inverse();
112        C1     = RelativeValue and RelativeValue.Value or Part1.CFrame:toObjectSpace(Part0.CFrame); --Part1.CFrame:inverse() * Part0.CFrame;-- Part1.CFrame:inverse();
113        Parent = Part1;
114    })
115 
116    if not RelativeValue then
117        RelativeValue = Make("CFrameValue", {
118            Parent     = Part1;
119            Name       = "qRelativeCFrameWeldValue";
120            Archivable = true;
121            Value      = NewWeld.C1;
122        })
123    end
124 
125    return NewWeld
126end
127 
128local function WeldParts(Parts, MainPart, JointType, DoNotUnanchor)
129 
130    for _, Part in pairs(Parts) do
131        if ShouldBreakJoints(Part) then
132            Part:BreakJoints()
133        end
134    end
135 
136    for _, Part in pairs(Parts) do
137        if Part ~= MainPart then
138            WeldTogether(MainPart, Part, JointType, MainPart)
139        end
140    end
141 
142    if not DoNotUnanchor then
143        for _, Part in pairs(Parts) do
144            Part.Anchored = false
145        end
146        MainPart.Anchored = false
147    end
148end
149 
150local function PerfectionWeld() 
151    local Tool = GetNearestParent(script, "Tool")
152 
153    local Parts = GetBricks(script.Parent)
154    local PrimaryPart = Tool and Tool:FindFirstChild("Handle") and Tool.Handle:IsA("BasePart") and Tool.Handle or script.Parent:IsA("Model") and script.Parent.PrimaryPart or Parts[1]
155 
156    if PrimaryPart then
157        WeldParts(Parts, PrimaryPart, "Weld", false)
158    else
159        warn("qWeld - Unable to weld part")
160    end
161 
162    return Tool
163end
164 
165local Tool = PerfectionWeld()
166 
167 
168if Tool and script.ClassName == "Script" then
169    --- Don't bother with local scripts
170 
171    script.Parent.AncestryChanged:connect(function()
172        PerfectionWeld()
173    end)
174end
 View all 174 lines...

Error messages explain a lot most of the time. hiimgoodpack 2009 — 7y

Weapon script dosn't deflect damage, why?

2 answers

Answer this question